# [PATCH] wildmatch test: remove redundant duplicate test

3 messages from 2017-05-27 to 2017-05-29. Participants: Ævar Arnfjörð Bjarmason, Junio C Hamano.
Thread: https://gitlist.dev/t/46053

## Ævar Arnfjörð Bjarmason, 2017-05-26 20:56

Subject: [PATCH] wildmatch test: remove redundant duplicate test
Message-ID: <20170526205657.15006-1-avarab@gmail.com>
URL: https://gitlist.dev/e/20170526205657.15006-1-avarab%40gmail.com

```
Remove a test line that's exactly the same as the preceding
line.

This was brought in in commit feabcc173b ("Integrate wildmatch to
git", 2012-10-15), these tests are originally copied from rsync.git,
but the duplicate line was never present there, so must have just
snuck in during integration with git by accident.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 t/t3070-wildmatch.sh | 1 -
 1 file changed, 1 deletion(-)

diff --git a/t/t3070-wildmatch.sh b/t/t3070-wildmatch.sh
index ef509df351..7ca69f4bed 100755
--- a/t/t3070-wildmatch.sh
+++ b/t/t3070-wildmatch.sh
@@ -135,7 +135,6 @@ match 1 x '5' '[[:xdigit:]]'
 match 1 x 'f' '[[:xdigit:]]'
 match 1 x 'D' '[[:xdigit:]]'
 match 1 x '_' '[[:alnum:][:alpha:][:blank:][:cntrl:][:digit:][:graph:][:lower:][:print:][:punct:][:space:][:upper:][:xdigit:]]'
-match 1 x '_' '[[:alnum:][:alpha:][:blank:][:cntrl:][:digit:][:graph:][:lower:][:print:][:punct:][:space:][:upper:][:xdigit:]]'
 match 1 x '.' '[^[:alnum:][:alpha:][:blank:][:cntrl:][:digit:][:lower:][:space:][:upper:][:xdigit:]]'
 match 1 x '5' '[a-c[:digit:]x-z]'
 match 1 x 'b' '[a-c[:digit:]x-z]'
-- 
2.13.0.303.g4ebf302169


```

## Junio C Hamano, 2017-05-29 00:54

Subject: Re: [PATCH] wildmatch test: remove redundant duplicate test
Message-ID: <xmqqd1asa3ea.fsf@gitster.mtv.corp.google.com>
URL: https://gitlist.dev/e/xmqqd1asa3ea.fsf%40gitster.mtv.corp.google.com
In-Reply-To: <20170526205657.15006-1-avarab@gmail.com>

```
Thanks.  Did you run "sort | uniq -c" on it or something ;-)?

Will apply.

```

## Ævar Arnfjörð Bjarmason, 2017-05-29 07:22

Subject: Re: [PATCH] wildmatch test: remove redundant duplicate test
Message-ID: <CACBZZX4ptB4_45D425cEzzCipt1Y=_TVskG+73hzwmar12Ai=Q@mail.gmail.com>
URL: https://gitlist.dev/e/CACBZZX4ptB4_45D425cEzzCipt1Y%3D_TVskG%2B73hzwmar12Ai%3DQ%40mail.gmail.com
In-Reply-To: <xmqqd1asa3ea.fsf@gitster.mtv.corp.google.com>

```
On Mon, May 29, 2017 at 2:54 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Thanks.  Did you run "sort | uniq -c" on it or something ;-)?

I've been writing a new backend for wildmatch(). Was wondering what
the difference in these two failing tests was, turns out there was
none.

> Will apply.

Thanks.

```