# [PATCH] completion: add git stash push 3 messages from 2017-05-16 to 2017-05-17. Participants: Thomas Gummerer, Jonathan Nieder, Junio C Hamano. Thread: https://gitlist.dev/t/45984 ## Thomas Gummerer, 2017-05-16 19:59 Subject: [PATCH] completion: add git stash push Message-ID: <20170516195945.745-1-t.gummerer@gmail.com> URL: https://gitlist.dev/e/20170516195945.745-1-t.gummerer%40gmail.com ``` When introducing git stash push in f5727e26e4 ("stash: introduce push verb", 2017-02-19), I forgot to add it to the completion code. Add it now. Signed-off-by: Thomas Gummerer --- contrib/completion/git-completion.bash | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index af658995d5..3f01249116 100644 --- a/contrib/completion/git-completion.bash +++ b/contrib/completion/git-completion.bash @@ -2810,7 +2810,7 @@ _git_show_branch () _git_stash () { local save_opts='--all --keep-index --no-keep-index --quiet --patch --include-untracked' - local subcommands='save list show apply clear drop pop create branch' + local subcommands='push save list show apply clear drop pop create branch' local subcommand="$(__git_find_on_cmdline "$subcommands")" if [ -z "$subcommand" ]; then case "$cur" in @@ -2825,6 +2825,9 @@ _git_stash () esac else case "$subcommand,$cur" in + push,--*) + __gitcomp "$save_opts --message" + ;; save,--*) __gitcomp "$save_opts" ;; -- 2.13.0.rc2.279.g813ba54fc ``` ## Jonathan Nieder, 2017-05-16 20:12 Subject: Re: [PATCH] completion: add git stash push Message-ID: <20170516201211.GQ27400@aiede.svl.corp.google.com> URL: https://gitlist.dev/e/20170516201211.GQ27400%40aiede.svl.corp.google.com In-Reply-To: <20170516195945.745-1-t.gummerer@gmail.com> ``` Thomas Gummerer wrote: > When introducing git stash push in f5727e26e4 ("stash: introduce push > verb", 2017-02-19), I forgot to add it to the completion code. Add it > now. > > Signed-off-by: Thomas Gummerer > --- > contrib/completion/git-completion.bash | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) Reviewed-by: Jonathan Nieder Thanks. ``` ## Junio C Hamano, 2017-05-17 03:16 Subject: Re: [PATCH] completion: add git stash push Message-ID: URL: https://gitlist.dev/e/xmqqy3twxjer.fsf%40gitster.mtv.corp.google.com In-Reply-To: <20170516201211.GQ27400@aiede.svl.corp.google.com> ``` Jonathan Nieder writes: > Thomas Gummerer wrote: > >> When introducing git stash push in f5727e26e4 ("stash: introduce push >> verb", 2017-02-19), I forgot to add it to the completion code. Add it >> now. >> >> Signed-off-by: Thomas Gummerer >> --- >> contrib/completion/git-completion.bash | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) > > Reviewed-by: Jonathan Nieder Thanks, both. Will queue. ```