# Not translatable strings in Git 4 messages from 2017-05-06 to 2017-05-09. Participants: Jordi Mas, Stefan Beller, Jeff King, Junio C Hamano. Thread: https://gitlist.dev/t/45885 ## Jordi Mas, 2017-05-06 08:40 Subject: Not translatable strings in Git Message-ID: URL: https://gitlist.dev/e/f3bfb85c-1722-e720-3d36-40c29a692867%40softcatala.org ``` Hello, When translating git (https://github.com/git/git/tree/master/po) The following strings cannot be translated: remote: Counting objects: 331, done. remote: Compressing objects: 100% (213/213), done. remote: Total 244 (delta 184), reused 34 (delta 29) 27 files changed, 3399 insertions(+), 3320 deletions(-) create mode 100644 build-aux/flatpak/org.gnome.Nautilus-stable.json delete mode 100755 build-aux/meson/check_libgd.sh Since they are not in the PO files. When working on making these strings localisable, I suggest checking that in the same modules there are other hardcoded strings that cannot be localised. Thanks Jordi, --- This email has been checked for viruses by AVG. http://www.avg.com ``` ## Stefan Beller, 2017-05-08 16:49 Subject: Re: Not translatable strings in Git Message-ID: URL: https://gitlist.dev/e/CAGZ79kbtT6QCbd3-MpWiTm3r_cyBOLsa9kvd-KLNr8eEe%2B9v9Q%40mail.gmail.com In-Reply-To: ``` On Sat, May 6, 2017 at 1:40 AM, Jordi Mas wrote: > Hello, > > When translating git (https://github.com/git/git/tree/master/po) > > The following strings cannot be translated: > > remote: Counting objects: 331, done. > remote: Compressing objects: 100% (213/213), done. > remote: Total 244 (delta 184), reused 34 (delta 29) This is what the remote server tells a client, but the client did not tell the server which locale it has. Now consider we have hosting service that hosts projects accessible from a wide range of users, all of them having different locales. Which language should the remote speak? (Not knowing which language the client speaks). > 27 files changed, 3399 insertions(+), 3320 deletions(-) > create mode 100644 build-aux/flatpak/org.gnome.Nautilus-stable.json > delete mode 100755 build-aux/meson/check_libgd.sh These sound like they are done locally and could be translated easily. However I wonder if we have issues with leaky plumbing in the user porcelain. Thanks, Stefan ``` ## Jeff King, 2017-05-09 04:07 Subject: Re: Not translatable strings in Git Message-ID: <20170509040722.dd2yt4254g3raeev@sigill.intra.peff.net> URL: https://gitlist.dev/e/20170509040722.dd2yt4254g3raeev%40sigill.intra.peff.net In-Reply-To: ``` On Mon, May 08, 2017 at 09:49:34AM -0700, Stefan Beller wrote: > On Sat, May 6, 2017 at 1:40 AM, Jordi Mas wrote: > > Hello, > > > > When translating git (https://github.com/git/git/tree/master/po) > > > > The following strings cannot be translated: > > > > remote: Counting objects: 331, done. > > remote: Compressing objects: 100% (213/213), done. > > remote: Total 244 (delta 184), reused 34 (delta 29) > > This is what the remote server tells a client, but the client did not > tell the server which locale it has. > > Now consider we have hosting service that hosts projects accessible from > a wide range of users, all of them having different locales. Which language > should the remote speak? (Not knowing which language the client speaks). In theory the client could pass the locale variables. We probably already do by default over ssh. Likewise we could ask curl to send an HTTP header based on the current locale, and the server could respect that. That probably wouldn't even be that much code. I think it's just something that nobody has bothered to implement so far. > > 27 files changed, 3399 insertions(+), 3320 deletions(-) > > create mode 100644 build-aux/flatpak/org.gnome.Nautilus-stable.json > > delete mode 100755 build-aux/meson/check_libgd.sh > > These sound like they are done locally and could be translated easily. > However I wonder if we have issues with leaky plumbing in the user porcelain. I don't think the diffstat summary is marked for translation at all, plumbing or not. There's some history there: http://public-inbox.org/git/1345922816-20616-1-git-send-email-pclouds@gmail.com/t/#u There was an attempt to re-enable it for local-only commands: http://public-inbox.org/git/alpine.DEB.2.00.1210231323480.602@ds9.cixit.se/ but nobody seems to have responded (I don't have much of an opinion myself). -Peff ``` ## Junio C Hamano, 2017-05-09 04:31 Subject: Re: Not translatable strings in Git Message-ID: URL: https://gitlist.dev/e/xmqq7f1q4pn8.fsf%40gitster.mtv.corp.google.com In-Reply-To: <20170509040722.dd2yt4254g3raeev@sigill.intra.peff.net> ``` Jeff King writes: > I don't think the diffstat summary is marked for translation at all, > plumbing or not. There's some history there: > > http://public-inbox.org/git/1345922816-20616-1-git-send-email-pclouds@gmail.com/t/#u Wow, that's a long thread. > There was an attempt to re-enable it for local-only commands: > > http://public-inbox.org/git/alpine.DEB.2.00.1210231323480.602@ds9.cixit.se/ > > but nobody seems to have responded (I don't have much of an opinion > myself). I still think that the latter is wrong, especially the part that touches log-tree.c, pp_header(), and other lower level things that will be read and interpreted by scripts. The change to diff.c about the diffstat reverts a bugfix made in v1.8.0 timeperiod, it seems. ```