# [PATCH v2] t7400: add !CYGWIN prerequisite to 'add with \\ in path' 2 messages from 2017-04-30 to 2017-05-01. Participants: Ramsay Jones, Junio C Hamano. Thread: https://gitlist.dev/t/45837 ## Ramsay Jones, 2017-04-30 17:29 Subject: [PATCH v2] t7400: add !CYGWIN prerequisite to 'add with \\ in path' Message-ID: URL: https://gitlist.dev/e/bd5e3dc3-14f2-da03-4487-a52d3c0b52fe%40ramsayjones.plus.com ``` Commit cf9e55f494 ("submodule: prevent backslash expantion in submodule names", 07-04-2017) added a test which creates a git repository with some backslash characters in the name. On windows, where the backslash character is a directory separator, it is not possible to create a repository with the name 'sub\with\backslash'. (The NTFS filesystem would probably allow it, but the win32 api does not). The MinGW and Git for Windows versions of git actually create a repository called 'backslash' in the sub-directory 'sub/with'. On cygwin, however, due to the slightly schizophrenic treatment of the backslash character by cygwin-git, this test fails at the 'git init' stage. The git-init command does not recognise the directory separators in the input path (eg. is_dir_sep('\\') is false), so it does not attempt to create the leading directories 'sub/with'. (The call to mkdir('sub\\with\\backslash') actually does recognise the directory separators, but fails because the 'sub/with' directory doesn't exist). In order to suppress the test failure (for now), add the !CYGWIN test prerequisite. Signed-off-by: Ramsay Jones --- Hi Junio, This is the 'v2' re-roll of the 'BSLASHPSEC' patch. :-D ATB, Ramsay Jones t/t7400-submodule-basic.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t7400-submodule-basic.sh b/t/t7400-submodule-basic.sh index c2706fe47..d0357f1d8 100755 --- a/t/t7400-submodule-basic.sh +++ b/t/t7400-submodule-basic.sh @@ -273,7 +273,7 @@ test_expect_success 'submodule add with ./, /.. and // in path' ' test_cmp empty untracked ' -test_expect_success 'submodule add with \\ in path' ' +test_expect_success !CYGWIN 'submodule add with \\ in path' ' test_when_finished "rm -rf parent sub\\with\\backslash" && # Initialize a repo with a backslash in its name -- 2.12.0 ``` ## Junio C Hamano, 2017-05-01 02:03 Subject: Re: [PATCH v2] t7400: add !CYGWIN prerequisite to 'add with \\ in path' Message-ID: URL: https://gitlist.dev/e/xmqqk261ib8y.fsf%40gitster.mtv.corp.google.com In-Reply-To: ``` Ramsay Jones writes: > Commit cf9e55f494 ("submodule: prevent backslash expantion in submodule > names", 07-04-2017) added a test which creates a git repository with > some backslash characters in the name. On windows, where the backslash > character is a directory separator, it is not possible to create a > repository with the name 'sub\with\backslash'. (The NTFS filesystem would > probably allow it, but the win32 api does not). The MinGW and Git for > Windows versions of git actually create a repository called 'backslash' > in the sub-directory 'sub/with'. > > On cygwin, however, due to the slightly schizophrenic treatment of the > backslash character by cygwin-git, this test fails at the 'git init' > stage. The git-init command does not recognise the directory separators > in the input path (eg. is_dir_sep('\\') is false), so it does not > attempt to create the leading directories 'sub/with'. (The call to > mkdir('sub\\with\\backslash') actually does recognise the directory > separators, but fails because the 'sub/with' directory doesn't exist). > > In order to suppress the test failure (for now), add the !CYGWIN test > prerequisite. > > Signed-off-by: Ramsay Jones > --- > > Hi Junio, > > This is the 'v2' re-roll of the 'BSLASHPSEC' patch. :-D > Thanks. > ATB, > Ramsay Jones > > t/t7400-submodule-basic.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/t/t7400-submodule-basic.sh b/t/t7400-submodule-basic.sh > index c2706fe47..d0357f1d8 100755 > --- a/t/t7400-submodule-basic.sh > +++ b/t/t7400-submodule-basic.sh > @@ -273,7 +273,7 @@ test_expect_success 'submodule add with ./, /.. and // in path' ' > test_cmp empty untracked > ' > > -test_expect_success 'submodule add with \\ in path' ' > +test_expect_success !CYGWIN 'submodule add with \\ in path' ' > test_when_finished "rm -rf parent sub\\with\\backslash" && > > # Initialize a repo with a backslash in its name ```