threads / patch / 45831

patchtravis-ci: retry if Git for Windows CI returns HTTP error 502 or 503

Subject: [PATCH v1] travis-ci: retry if Git for Windows CI returns HTTP error 502 or 503

## tl;dr

4 messages between Apr 29, 2017 and May 2, 2017. Diffs are folded; open one to read it.

replies: 3people: 2as markdown or json

Lars Schneider· Apr 29, 2017, 18:48 UTC · lore

The Git for Windows CI web app sometimes returns HTTP errors of "502 bad gateway" or "503 service unavailable" [1]. Wait a little and retry the request if this happens.

[1] https://docs.microsoft.com/en-in/azure/app-service-web/app-service-web-troubleshoot-http-502-http-503
Signed-off-by: Lars Schneider <larsxschneider@gmail.com>
---
Hi,

this should make the Git for Windows build a bit more stable. We saw a few 502's recently. E.g. https://travis-ci.org/git/git/jobs/226669324

I did not add any checks to avoid an endless loop because TravisCI would shutdown the worker if there is no output for more than 10min. Therefore I think we don't need to handle this case ourselves.

Cheers, Lars

Notes:
    Base Ref: next
    Web-Diff: https://github.com/larsxschneider/git/commit/b57ebf31ab
    Checkout: git fetch https://github.com/larsxschneider/git travisci/win-retry-v1 && git checkout b57ebf31ab
 ci/run-windows-build.sh | 12 ++++++++++++
 1 file changed, 12 insertions(+)
Show changes to ci/run-windows-build.sh +12 −1
diff --git a/ci/run-windows-build.sh b/ci/run-windows-build.sh
index e043440799..7a9aa9c6a7 100755
--- a/ci/run-windows-build.sh
+++ b/ci/run-windows-build.sh
@@ -15,6 +15,8 @@ COMMIT=$2
 gfwci () {
 	local CURL_ERROR_CODE HTTP_CODE
 	exec 3>&1
+	while test -z $HTTP_CODE
+	do
 	HTTP_CODE=$(curl \
 		-H "Authentication: Bearer $GFW_CI_TOKEN" \
 		--silent --retry 5 --write-out '%{HTTP_CODE}' \
@@ -22,6 +24,16 @@ gfwci () {
 		"https://git-for-windows-ci.azurewebsites.net/api/TestNow?$1" \
 	)
 	CURL_ERROR_CODE=$?
+		# The GfW CI web app sometimes returns HTTP errors of
+		# "502 bad gateway" or "503 service unavailable".
+		# Wait a little and retry if it happens. More info:
+		# https://docs.microsoft.com/en-in/azure/app-service-web/app-service-web-troubleshoot-http-502-http-503
+		if test $HTTP_CODE -eq 502 || test $HTTP_CODE -eq 503
+		then
+			sleep 10
+			HTTP_CODE=
+		fi
+	done
 	if test $CURL_ERROR_CODE -ne 0
 	then
 		return $CURL_ERROR_CODE

base-commit: 1ea7e62026c5dde4d8be80b2544696fc6aa70121
--
2.12.2
Lars Schneider· May 1, 2017, 11:32 UTC · re: Lars Schneider · lore

Re: [PATCH v1] travis-ci: retry if Git for Windows CI returns HTTP error 502 or 503

Show 58 quoted lines
> On 29 Apr 2017, at 20:48, Lars Schneider <larsxschneider@gmail.com> wrote:
> 
> The Git for Windows CI web app sometimes returns HTTP errors of
> "502 bad gateway" or "503 service unavailable" [1]. Wait a little and
> retry the request if this happens.
> 
> [1] https://docs.microsoft.com/en-in/azure/app-service-web/app-service-web-troubleshoot-http-502-http-503
> 
> Signed-off-by: Lars Schneider <larsxschneider@gmail.com>
> ---
> 
> Hi,
> 
> this should make the Git for Windows build a bit more stable. We saw
> a few 502's recently. E.g. https://travis-ci.org/git/git/jobs/226669324
> 
> I did not add any checks to avoid an endless loop because TravisCI would
> shutdown the worker if there is no output for more than 10min. Therefore
> I think we don't need to handle this case ourselves.
> 
> Cheers,
> Lars
> 
> Notes:
>    Base Ref: next
>    Web-Diff: https://github.com/larsxschneider/git/commit/b57ebf31ab
>    Checkout: git fetch https://github.com/larsxschneider/git travisci/win-retry-v1 && git checkout b57ebf31ab
> 
> ci/run-windows-build.sh | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
> 
> diff --git a/ci/run-windows-build.sh b/ci/run-windows-build.sh
> index e043440799..7a9aa9c6a7 100755
> --- a/ci/run-windows-build.sh
> +++ b/ci/run-windows-build.sh
> @@ -15,6 +15,8 @@ COMMIT=$2
> gfwci () {
> 	local CURL_ERROR_CODE HTTP_CODE
> 	exec 3>&1
> +	while test -z $HTTP_CODE
> +	do
> 	HTTP_CODE=$(curl \
> 		-H "Authentication: Bearer $GFW_CI_TOKEN" \
> 		--silent --retry 5 --write-out '%{HTTP_CODE}' \
> @@ -22,6 +24,16 @@ gfwci () {
> 		"https://git-for-windows-ci.azurewebsites.net/api/TestNow?$1" \
> 	)
> 	CURL_ERROR_CODE=$?
> +		# The GfW CI web app sometimes returns HTTP errors of
> +		# "502 bad gateway" or "503 service unavailable".
> +		# Wait a little and retry if it happens. More info:
> +		# https://docs.microsoft.com/en-in/azure/app-service-web/app-service-web-troubleshoot-http-502-http-503
> +		if test $HTTP_CODE -eq 502 || test $HTTP_CODE -eq 503
> +		then
> +			sleep 10
> +			HTTP_CODE=
> +		fi
> +	done

Please don't move this to next, yet. This seems not to work as expected :-( https://travis-ci.org/git/git/jobs/227513693

- Lars
Junio C Hamano· May 2, 2017, 09:52 UTC · re: Lars Schneider · lore

Re: [PATCH v1] travis-ci: retry if Git for Windows CI returns HTTP error 502 or 503

On Mon, May 1, 2017 at 8:32 PM, Lars Schneider <larsxschneider@gmail.com> wrote:
Show 6 quoted lines
>>
>> this should make the Git for Windows build a bit more stable. We saw
>> a few 502's recently. E.g. https://travis-ci.org/git/git/jobs/226669324
>>
> Please don't move this to next, yet. This seems not to work as expected :-(
> https://travis-ci.org/git/git/jobs/227513693

Sure. I am wondering if your other one to run both asciidoc & asciidoctor tee'ed to log files should be ready to work on 'next', though.

Thanks.
Lars Schneider· May 2, 2017, 10:27 UTC · re: Junio C Hamano · lore

Re: [PATCH v1] travis-ci: retry if Git for Windows CI returns HTTP error 502 or 503

Show 12 quoted lines
> On 02 May 2017, at 11:52, Junio C Hamano <gitster@pobox.com> wrote:
> 
> On Mon, May 1, 2017 at 8:32 PM, Lars Schneider <larsxschneider@gmail.com> wrote:
>>> 
>>> this should make the Git for Windows build a bit more stable. We saw
>>> a few 502's recently. E.g. https://travis-ci.org/git/git/jobs/226669324
>>> 
>> Please don't move this to next, yet. This seems not to work as expected :-(
>> https://travis-ci.org/git/git/jobs/227513693
> 
> Sure. I am wondering if your other one to run both asciidoc & asciidoctor
> tee'ed to log files should be ready to work on 'next', though.

The asciidoc changes are good to go from my point of view: https://travis-ci.org/git/git/jobs/227822259

- Lars

← back to recent threads