threads / patch / 4582

patchrepo-config: Fix late-night bug

Subject: [PATCH] repo-config: Fix late-night bug

## tl;dr

One message between Jun 20, 2006 and Jun 20, 2006. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Johannes Schindelin· Jun 20, 2006, 07:45 UTC · lore
This bug was hidden by the "future-proofing" of the test. Sigh.

When neither GIT_CONFIG nor GIT_CONFIG_LOCAL is set, do not use NULL, but $GIT_DIR/config. Instead of using $GIT_DIR/config when only GIT_CONFIG_LOCAL is set. Sorry.

Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
---
	This time, "only" repo-config was affected, _not_ all users of
	the config file.
 repo-config.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
Show changes to repo-config.c +0 −2
diff --git a/repo-config.c b/repo-config.c
index 03f108f..ab8f1af 100644
--- a/repo-config.c
+++ b/repo-config.c
@@ -74,8 +74,6 @@ static int get_value(const char* key_, c
 		const char *home = getenv("HOME");
 		local = getenv("GIT_CONFIG_LOCAL");
 		if (!local)
-			local = repo_config;
-		else
 			local = repo_config = strdup(git_path("config"));
 		if (home)
 			global = strdup(mkpath("%s/.gitconfig", home));
-- 
1.4.0.g59268-dirty

← back to recent threads