threads / discuss / 45729

Failed shallow submodule clone for fixed SHA1 falls back to checking out HEAD

Subject: Failed shallow submodule clone for fixed SHA1 falls back to checking out HEAD

## tl;dr

3 messages between Apr 18, 2017 and Apr 18, 2017.

replies: 2people: 2as markdown or json

Sebastian Schuberth· Apr 18, 2017, 13:04 UTC · lore

Hi,

this is using "git version 2.12.2.windows.2" on Windows / "git version 2.12.2-639-g584f897" on Linux.

I have configured my superproject with .gitmodules saying

---8<---
[submodule "src/funTest/resources/projects/external/jgnash"]
       path = src/funTest/resources/projects/external/jgnash
       url = https://github.com/ccavanaugh/jgnash.git
       shallow = true
---8<---

and configured the submodule to checkout commit 2aa4cce7d7fd46164030f2b4d244c4b89e77f722 [1]. When doing a fresh clone of my superproject via "git clone --recursive" I get

---8<--- error: Server does not allow request for unadvertised object 2aa4cce7d7fd46164030f2b4d244c4b89e77f722 Fetched in submodule path 'src/funTest/resources/projects/external/jgnash', but it did not contain 2aa4cce7d7fd464030f2b4d244c4b89e77f722. Direct fetching of that commit failed. ---8<---

So far so good, it simply seems that GitHub does not support allowReachableSHA1InWant [2]. The interesting bit is that my submodule checkout still ends up being shallow, but poiting to HEAD:

---8<---
$ cd src/funTest/resources/projects/external/jgnash
$ git log
commit 12036fffb6c620515edd96416363fd1749b5d003 (grafted, HEAD -> master, origin/master, origin/HEAD)
Author: Craig Cavanaugh <jgnash.devel@gmail.com>
Date:   Tue Apr 18 05:33:06 2017 -0400

    Fix typos
---8<---

Wouldn't it make more sense to unshallow the submodule clone in this case and checkout the configured commit 2aa4cce7d7fd46164030f2b4d244c4b89e77f722 afterwards? At least I'd be getting what I asked for in that case, even if at the cost of additional network traffic. Because if I read [3] correctly, the command line option belonging to "submodule.<name>.shallow" is called "--[no-]recommend-shallow", i.e. it's only a recommendation, to falling back to a full clone should be fine.

[1] https://github.com/ccavanaugh/jgnash/commit/2aa4cce7d7fd46164030f2b4d244c4b89e77f722 [2] https://git-scm.com/docs/git-config#git-config-uploadpackallowReachableSHA1InWant [3] https://git-scm.com/docs/git-submodule

Regards, Sebastian

Stefan Beller· Apr 18, 2017, 19:12 UTC · lore

Fwd: Failed shallow submodule clone for fixed SHA1 falls back to checking out HEAD

On Tue, Apr 18, 2017 at 6:04 AM, Sebastian Schuberth <sschuberth@gmail.com> wrote:

Show 21 quoted lines

> Hi,
>
> this is using "git version 2.12.2.windows.2" on Windows / "git version 2.12.2-639-g584f897" on Linux.
>
> I have configured my superproject with .gitmodules saying
>
> ---8<---
> [submodule "src/funTest/resources/projects/external/jgnash"]
>        path = src/funTest/resources/projects/external/jgnash
>        url = https://github.com/ccavanaugh/jgnash.git
>        shallow = true
> ---8<---
>
> and configured the submodule to checkout commit 2aa4cce7d7fd46164030f2b4d244c4b89e77f722 [1]. When doing a fresh clone of my superproject via "git clone --recursive" I get
>
> ---8<---
> error: Server does not allow request for unadvertised object 2aa4cce7d7fd46164030f2b4d244c4b89e77f722
> Fetched in submodule path 'src/funTest/resources/projects/external/jgnash', but it did not contain 2aa4cce7d7fd464030f2b4d244c4b89e77f722. Direct fetching of that commit failed.
> ---8<---
>
> So far so good, it simply seems that GitHub does not support allowReachableSHA1InWant [2].

Maybe the error message should say so: "Bug your host admin to enable allowReachableSHA1InWant".

Show 13 quoted lines

> The interesting bit is that my submodule checkout still ends up being shallow, but poiting to HEAD:
>
> ---8<---
> $ cd src/funTest/resources/projects/external/jgnash
> $ git log
> commit 12036fffb6c620515edd96416363fd1749b5d003 (grafted, HEAD -> master, origin/master, origin/HEAD)
> Author: Craig Cavanaugh <jgnash.devel@gmail.com>
> Date:   Tue Apr 18 05:33:06 2017 -0400
>
>     Fix typos
> ---8<---
>
> Wouldn't it make more sense to unshallow the submodule clone in this case and checkout the configured commit 2aa4cce7d7fd46164030f2b4d244c4b89e77f722 afterwards?

If I remember correctly the conclusion of the discussion at the time was that people are more interested in "less data" rather than "correct data" because otherwise you would not have asked for shallow.

> At least I'd be getting what I asked for in that case, even if at the cost of additional network traffic. Because if I read [3] correctly, the command line option belonging to "submodule.<name>.shallow" is called "--[no-]recommend-shallow", i.e. it's only a recommendation, to falling back to a full clone should be fine.

Heh, good point. Currently that option is more like a "--[no-]follow-shallow-in-gitmodules" without second thought as the "recommend" would elude to.

Thanks, Stefan

Show 8 quoted lines

>
> [1] https://github.com/ccavanaugh/jgnash/commit/2aa4cce7d7fd46164030f2b4d244c4b89e77f722
> [2] https://git-scm.com/docs/git-config#git-config-uploadpackallowReachableSHA1InWant
> [3] https://git-scm.com/docs/git-submodule
>
> Regards,
> Sebastian
>

Sebastian Schuberth· Apr 18, 2017, 19:18 UTC · re: Stefan Beller · lore

Re: Fwd: Failed shallow submodule clone for fixed SHA1 falls back to checking out HEAD

On 2017-04-18 21:12, Stefan Beller wrote:

Show 5 quoted lines

>> Wouldn't it make more sense to unshallow the submodule clone in this case and checkout the configured commit 2aa4cce7d7fd46164030f2b4d244c4b89e77f722 afterwards?
> 
> If I remember correctly the conclusion of the discussion at the time
> was that people are more interested in "less data" rather than
> "correct data" because otherwise you would not have asked for shallow.

I do believe this is an awkward choice. What does it help to get less data if it's the wrong data?

-- 
Sebastian Schuberth