# [PATCH] test-read-cache: setup git dir 2 messages from 2017-04-06 to 2017-04-07. Participants: René Scharfe, Jeff King. Thread: https://gitlist.dev/t/45626 ## René Scharfe, 2017-04-06 20:41 Subject: [PATCH] test-read-cache: setup git dir Message-ID: <020feb89-be3e-1261-d9b5-cad7c38ef2f0@web.de> URL: https://gitlist.dev/e/020feb89-be3e-1261-d9b5-cad7c38ef2f0%40web.de ``` b1ef400e (setup_git_env: avoid blind fall-back to ".git") made programs that tried to access a repository without initializing properly die with a diagnostic message. One offender is test-read-cache, which is used in p0002. Fix it by calling setup_git_directory() before accessing the index. Signed-off-by: Rene Scharfe --- t/helper/test-read-cache.c | 1 + 1 file changed, 1 insertion(+) diff --git a/t/helper/test-read-cache.c b/t/helper/test-read-cache.c index 2a7990efc3..48255eef31 100644 --- a/t/helper/test-read-cache.c +++ b/t/helper/test-read-cache.c @@ -5,6 +5,7 @@ int cmd_main(int argc, const char **argv) int i, cnt = 1; if (argc == 2) cnt = strtol(argv[1], NULL, 0); + setup_git_directory(); for (i = 0; i < cnt; i++) { read_cache(); discard_cache(); -- 2.12.2 ``` ## Jeff King, 2017-04-07 05:22 Subject: Re: [PATCH] test-read-cache: setup git dir Message-ID: <20170407052255.vc6ch633zcdiplgy@sigill.intra.peff.net> URL: https://gitlist.dev/e/20170407052255.vc6ch633zcdiplgy%40sigill.intra.peff.net In-Reply-To: <020feb89-be3e-1261-d9b5-cad7c38ef2f0@web.de> ``` On Thu, Apr 06, 2017 at 10:41:41PM +0200, René Scharfe wrote: > b1ef400e (setup_git_env: avoid blind fall-back to ".git") made programs > that tried to access a repository without initializing properly die with > a diagnostic message. One offender is test-read-cache, which is used in > p0002. Fix it by calling setup_git_directory() before accessing the > index. Right, makes sense. I wondered why we didn't notice this before, but it's because it's _only_ called from the perf suite. -Peff ```