# [PATCH] doc/config: grammar fixes for core.{editor,commentChar} 2 messages from 2017-03-23 to 2017-03-23. Participants: Kyle Meyer, Junio C Hamano. Thread: https://gitlist.dev/t/45485 ## Kyle Meyer, 2017-03-23 17:32 Subject: [PATCH] doc/config: grammar fixes for core.{editor,commentChar} Message-ID: <20170323173216.26176-1-kyle@kyleam.com> URL: https://gitlist.dev/e/20170323173216.26176-1-kyle%40kyleam.com ``` Signed-off-by: Kyle Meyer --- Documentation/config.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentation/config.txt b/Documentation/config.txt index 0d8df5a9f..1df196545 100644 --- a/Documentation/config.txt +++ b/Documentation/config.txt @@ -737,13 +737,13 @@ alternative to having an `init.templateDir` where you've changed default hooks. core.editor:: - Commands such as `commit` and `tag` that lets you edit - messages by launching an editor uses the value of this + Commands such as `commit` and `tag` that let you edit + messages by launching an editor use the value of this variable when it is set, and the environment variable `GIT_EDITOR` is not set. See linkgit:git-var[1]. core.commentChar:: - Commands such as `commit` and `tag` that lets you edit + Commands such as `commit` and `tag` that let you edit messages consider a line that begins with this character commented, and removes them after the editor returns (default '#'). -- 2.12.1 ``` ## Junio C Hamano, 2017-03-23 19:02 Subject: Re: [PATCH] doc/config: grammar fixes for core.{editor,commentChar} Message-ID: URL: https://gitlist.dev/e/xmqqfui3ddeu.fsf%40gitster.mtv.corp.google.com In-Reply-To: <20170323173216.26176-1-kyle@kyleam.com> ``` Kyle Meyer writes: > Signed-off-by: Kyle Meyer > --- Thanks. > Documentation/config.txt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Documentation/config.txt b/Documentation/config.txt > index 0d8df5a9f..1df196545 100644 > --- a/Documentation/config.txt > +++ b/Documentation/config.txt > @@ -737,13 +737,13 @@ alternative to having an `init.templateDir` where you've changed > default hooks. > > core.editor:: > - Commands such as `commit` and `tag` that lets you edit > - messages by launching an editor uses the value of this > + Commands such as `commit` and `tag` that let you edit > + messages by launching an editor use the value of this > variable when it is set, and the environment variable > `GIT_EDITOR` is not set. See linkgit:git-var[1]. > > core.commentChar:: > - Commands such as `commit` and `tag` that lets you edit > + Commands such as `commit` and `tag` that let you edit > messages consider a line that begins with this character > commented, and removes them after the editor returns > (default '#'). ```