# [PATCH] http-push: don't check return value of lookup_unknown_object()

1 messages from 2017-03-18 to 2017-03-18. Participants: René Scharfe.
Thread: https://gitlist.dev/t/45418

## René Scharfe, 2017-03-17 22:12

Subject: [PATCH] http-push: don't check return value of lookup_unknown_object()
Message-ID: <1a7123f5-9017-7602-03f4-5123cdebe541@web.de>
URL: https://gitlist.dev/e/1a7123f5-9017-7602-03f4-5123cdebe541%40web.de

```
This function always returns a reference to an object, creating one if
needed, so remove the unnecessary NULL check.

Signed-off-by: Rene Scharfe <l.s.r@web.de>
---
 http-push.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/http-push.c b/http-push.c
index 704b1c837c..f0e3108f71 100644
--- a/http-push.c
+++ b/http-push.c
@@ -1431,11 +1431,9 @@ static void one_remote_ref(const char *refname)
 	 */
 	if (repo->can_update_info_refs && !has_object_file(&ref->old_oid)) {
 		obj = lookup_unknown_object(ref->old_oid.hash);
-		if (obj) {
-			fprintf(stderr,	"  fetch %s for %s\n",
-				oid_to_hex(&ref->old_oid), refname);
-			add_fetch_request(obj);
-		}
+		fprintf(stderr,	"  fetch %s for %s\n",
+			oid_to_hex(&ref->old_oid), refname);
+		add_fetch_request(obj);
 	}
 
 	ref->next = remote_refs;
-- 
2.12.0


```