On Fri, Mar 03, 2017 at 10:48:38PM +0100, Pavel Machek wrote:
Show 10 quoted lines
>Hi! > >> [auto build test ERROR on linuxtv-media/master] >> [also build test ERROR on v4.10 next-20170303] >> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] >> > >Yes, the patch is against Sakari's ccp2 branch. It should work ok there. > >I don't think you can do much to fix the automated system....
We could, if "git format-patch" can be setup to auto append lines
parent-commit: X
parent-patch-id: YWith that information, as long as the parent commit/patch is public -- either by "git push" or posting patch to mailing lists -- we'll have good chance to find and use it as the base for "git am".
Currently "git format-patch" already has the option "--base=auto" to auto append the more accurate lines
base-commit: P
prerequisite-patch-id: X
prerequisite-patch-id: Y
prerequisite-patch-id: ZThat's the best information git can offer. Unfortunately it cannot ALWAYS work without human aid. What's worse, when it cannot figure out the base-commit, the whole "git format-patch" command will abort like this
$ git format-patch -1
fatal: base commit shouldn't be in revision listThat fatal error makes it not a viable option to always turn on "--base=auto" in .gitconfig.
Without a fully-automated solution, I don't think many people will bother or remember to manually specify base-commit before sending patches out.
To effectively save the robot from "base commit" guessing works, what we can do is to
1) append "parent-commit"/"parent-patch-id" lines when git cannot figure out and append the "base-commit"/"prerequisite-patch-id" lines. So that the test robot always get the information to do its job.
2) advise kernel developers to run this once
git config format.useAutoBase yes
to configure "--base=auto" as the default behavior.
Thanks, Fengguang