threads / patch / 45208

patchdocs/git-gc: fix default value for `--aggressiveDepth`

Subject: [PATCH] docs/git-gc: fix default value for `--aggressiveDepth`

## tl;dr

3 messages between Feb 24, 2017 and Feb 24, 2017. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

Patrick Steinhardt· Feb 24, 2017, 08:46 UTC · lore

In commit 07e7dbf0d (gc: default aggressive depth to 50, 2016-08-11), the default aggressive depth of git-gc has been changed to 50. While git-config(1) has been updated to represent the new default value, git-gc(1) still mentions the old value. This patch fixes it.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
---
 Documentation/git-gc.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to Documentation/git-gc.txt +1 −1

diff --git a/Documentation/git-gc.txt b/Documentation/git-gc.txt
index 852b72c67..571b5a7e3 100644
--- a/Documentation/git-gc.txt
+++ b/Documentation/git-gc.txt
@@ -127,7 +127,7 @@ the documentation for the --window' option in linkgit:git-repack[1] for
 more details.  This defaults to 250.
 
 Similarly, the optional configuration variable `gc.aggressiveDepth`
-controls --depth option in linkgit:git-repack[1]. This defaults to 250.
+controls --depth option in linkgit:git-repack[1]. This defaults to 50.
 
 The optional configuration variable `gc.pruneExpire` controls how old
 the unreferenced loose objects have to be before they are pruned.  The

-- 
2.11.1

Jeff King· Feb 24, 2017, 09:00 UTC · re: Patrick Steinhardt · lore

Re: [PATCH] docs/git-gc: fix default value for `--aggressiveDepth`

On Fri, Feb 24, 2017 at 09:46:45AM +0100, Patrick Steinhardt wrote:

> In commit 07e7dbf0d (gc: default aggressive depth to 50, 2016-08-11),
> the default aggressive depth of git-gc has been changed to 50. While
> git-config(1) has been updated to represent the new default value,
> git-gc(1) still mentions the old value. This patch fixes it.

Thanks, this is obviously an improvement.

(I also grepped for "250" in Documentation; the results are thankfully short, and the only other mentions I saw were referring to the window size).

-Peff

Junio C Hamano· Feb 24, 2017, 17:49 UTC · re: Jeff King · lore

Re: [PATCH] docs/git-gc: fix default value for `--aggressiveDepth`

Jeff King <peff@peff.net> writes:

Show 12 quoted lines

> On Fri, Feb 24, 2017 at 09:46:45AM +0100, Patrick Steinhardt wrote:
>
>> In commit 07e7dbf0d (gc: default aggressive depth to 50, 2016-08-11),
>> the default aggressive depth of git-gc has been changed to 50. While
>> git-config(1) has been updated to represent the new default value,
>> git-gc(1) still mentions the old value. This patch fixes it.
>
> Thanks, this is obviously an improvement.
>
> (I also grepped for "250" in Documentation; the results are thankfully
> short, and the only other mentions I saw were referring to the window
> size).

Thanks, both.  Will queue.