# git email From: parsing (was Re: [GIT PULL] Staging/IIO driver patches for 4.11-rc1) 5 messages from 2017-02-23 to 2017-02-24. Participants: Greg KH, Jeff King, Simon Sandström, Geert Uytterhoeven. Thread: https://gitlist.dev/t/45197 ## Greg KH, 2017-02-23 06:04 Subject: git email From: parsing (was Re: [GIT PULL] Staging/IIO driver patches for 4.11-rc1) Message-ID: <20170223060444.GA26196@kroah.com> URL: https://gitlist.dev/e/20170223060444.GA26196%40kroah.com In-Reply-To: ``` On Wed, Feb 22, 2017 at 11:59:01AM -0800, Linus Torvalds wrote: > On Wed, Feb 22, 2017 at 6:56 AM, Greg KH wrote: > > > > =?UTF-8?q?Simon=20Sandstr=C3=B6m?= (1): > > staging: vt6656: Add missing identifier names > > Wow, your scripts really screwed up that name. > > I'm assuming this is quilt not doing proper character set handling.. > > Because if it's git, we need to get that fixed (but I'm pretty sure > git gets this right - there are various tests for email header > quoting). > > Alternatively, somebody hand-edited some email and moved the From: > header to the body without fixing up the RFC 1342 mail header quoting > (which is very different from how quoting works in the *body* of an > email). > > Poor Simon Sandström. > > Funnily enough, this only exists for one commit. You've got several > other commits from Simon that get his name right. > > What happened? I don't know what happened, I used git for this, I don't use quilt for "normal" patches accepted into my trees anymore, only for stable kernel work. So either the mail is malformed, or git couldn't figure it out, I've attached the original message below, and cc:ed the git mailing list. Also, Simon emailed me after this was committed saying something went wrong, but I couldn't go back and rebase my tree. Simon, did you ever figure out if something was odd on your end? Git developers, any ideas? thanks, greg k-h ``` ## Jeff King, 2017-02-23 06:17 Subject: Re: git email From: parsing (was Re: [GIT PULL] Staging/IIO driver patches for 4.11-rc1) Message-ID: <20170223061702.bzzgrntotppvwdw6@sigill.intra.peff.net> URL: https://gitlist.dev/e/20170223061702.bzzgrntotppvwdw6%40sigill.intra.peff.net In-Reply-To: <20170223060444.GA26196@kroah.com> ``` On Thu, Feb 23, 2017 at 07:04:44AM +0100, Greg KH wrote: > > Poor Simon Sandström. > > > > Funnily enough, this only exists for one commit. You've got several > > other commits from Simon that get his name right. > > > > What happened? > > I don't know what happened, I used git for this, I don't use quilt for > "normal" patches accepted into my trees anymore, only for stable kernel > work. > > So either the mail is malformed, or git couldn't figure it out, I've > attached the original message below, and cc:ed the git mailing list. > > Also, Simon emailed me after this was committed saying something went > wrong, but I couldn't go back and rebase my tree. Simon, did you ever > figure out if something was odd on your end? > > Git developers, any ideas? The problem isn't on the applying end, but rather on the generating end. The From header in the attached mbox is: From: =?us-ascii?B?PT9VVEYtOD9xP1NpbW9uPTIwU2FuZHN0cj1DMz1CNm0/PQ==?= If you de-base64 that, you get: =?UTF-8?q?Simon=20Sandstr=C3=B6m?= So something double-encoded it before it got to your mbox. -Peff ``` ## Simon Sandström, 2017-02-23 07:59 Subject: Re: git email From: parsing (was Re: [GIT PULL] Staging/IIO driver patches for 4.11-rc1) Message-ID: <20170223075859.g6ert55bvbe44dxc@localhost> URL: https://gitlist.dev/e/20170223075859.g6ert55bvbe44dxc%40localhost In-Reply-To: <20170223061702.bzzgrntotppvwdw6@sigill.intra.peff.net> ``` On Thu, Feb 23, 2017 at 01:17:02AM -0500, Jeff King wrote: > On Thu, Feb 23, 2017 at 07:04:44AM +0100, Greg KH wrote: > > > > > I don't know what happened, I used git for this, I don't use quilt for > > "normal" patches accepted into my trees anymore, only for stable kernel > > work. > > > > So either the mail is malformed, or git couldn't figure it out, I've > > attached the original message below, and cc:ed the git mailing list. > > > > Also, Simon emailed me after this was committed saying something went > > wrong, but I couldn't go back and rebase my tree. Simon, did you ever > > figure out if something was odd on your end? > > > > Git developers, any ideas? > > The problem isn't on the applying end, but rather on the generating end. > The From header in the attached mbox is: > > From: =?us-ascii?B?PT9VVEYtOD9xP1NpbW9uPTIwU2FuZHN0cj1DMz1CNm0/PQ==?= > > If you de-base64 that, you get: > > =?UTF-8?q?Simon=20Sandstr=C3=B6m?= > > So something double-encoded it before it got to your mbox. > > -Peff Hi, Yes, Mutt on my end caused this. I used Mutt 1.5.23, and I either had it misconfigured or it simply can't handle files that contains encoded From:/Subject:-fields when you run it with mutt -H . I upgraded to Mutt 1.7.1 which solved the problem. - Simon ``` ## Geert Uytterhoeven, 2017-02-24 11:03 Subject: Re: git email From: parsing (was Re: [GIT PULL] Staging/IIO driver patches for 4.11-rc1) Message-ID: URL: https://gitlist.dev/e/CAMuHMdX%2BxGUD%2BK16VCE%3DywRgN1Zd4MzSr%3DNJ%3D2xz%2B8e_ixyGKQ%40mail.gmail.com In-Reply-To: <20170223061702.bzzgrntotppvwdw6@sigill.intra.peff.net> ``` On Thu, Feb 23, 2017 at 7:17 AM, Jeff King wrote: > On Thu, Feb 23, 2017 at 07:04:44AM +0100, Greg KH wrote: >> > Poor Simon Sandström. >> > >> > Funnily enough, this only exists for one commit. You've got several >> > other commits from Simon that get his name right. >> > >> > What happened? >> >> I don't know what happened, I used git for this, I don't use quilt for >> "normal" patches accepted into my trees anymore, only for stable kernel >> work. >> >> So either the mail is malformed, or git couldn't figure it out, I've >> attached the original message below, and cc:ed the git mailing list. >> >> Also, Simon emailed me after this was committed saying something went >> wrong, but I couldn't go back and rebase my tree. Simon, did you ever >> figure out if something was odd on your end? >> >> Git developers, any ideas? > > The problem isn't on the applying end, but rather on the generating end. > The From header in the attached mbox is: > > From: =?us-ascii?B?PT9VVEYtOD9xP1NpbW9uPTIwU2FuZHN0cj1DMz1CNm0/PQ==?= Slightly related, once in a while I get funny emails through git-commits-head@vger.kernel.org, where the subject is completely screwed up: Subject: \x64\x72\x6D\x2F\x74\x69\x6E\x79\x64\x72\x6D\x3A \x6D\x69\x70\x69\x2D\x64\x62\x69\x3A \x53\x69\x6C\x65\x6E\x63\x65\x3A ‘\x63\x6D\x64’ \x6D\x61\x79 \x62\x65 and some of the mail headers end up in the body as well: =?UTF-8?Q?\x75\x73\x65\x64_\x75\x6E\x69\x6E\x69\x74\x69\x61\x6C\x69\x7A\x65\x64?= Return-Path: "Linux Kernel Mailing List" MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Git-Commit: b401f34314db7c60e6d23ee7771cd090b4ef56c1 X-Git-Parent: 1e8ad3d8da4763b238d09244d4d1177aa640c0d3 X-Git-Refname: refs/heads/master Web: https://git.kernel.org/torvalds/c/b401f34314db7c60e6d23ee7771cd090b4ef56c1 Commit: b401f34314db7c60e6d23ee7771cd090b4ef56c1 Parent: 1e8ad3d8da4763b238d09244d4d1177aa640c0d3 Refname: refs/heads/master Author: Noralf Trønnes AuthorDate: Thu Feb 23 14:29:55 2017 +0100 Committer: Dave Airlie CommitDate: Fri Feb 24 12:08:58 2017 +1000 drm/tinydrm: mipi-dbi: Silence: ‘cmd’ may be used uninitialized My first guess was Noralf's UTF8 last name, but after looking at a few more, they all seem to have UTF8 quotes from gcc output in the oneline summary. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ``` ## Jeff King, 2017-02-24 18:56 Subject: Re: git email From: parsing (was Re: [GIT PULL] Staging/IIO driver patches for 4.11-rc1) Message-ID: <20170224185600.ftfts6y2au3tvzge@sigill.intra.peff.net> URL: https://gitlist.dev/e/20170224185600.ftfts6y2au3tvzge%40sigill.intra.peff.net In-Reply-To: ``` On Fri, Feb 24, 2017 at 12:03:45PM +0100, Geert Uytterhoeven wrote: > > The problem isn't on the applying end, but rather on the generating end. > > The From header in the attached mbox is: > > > > From: =?us-ascii?B?PT9VVEYtOD9xP1NpbW9uPTIwU2FuZHN0cj1DMz1CNm0/PQ==?= > > Slightly related, once in a while I get funny emails through > git-commits-head@vger.kernel.org, where the subject is completely screwed up: > > Subject: \x64\x72\x6D\x2F\x74\x69\x6E\x79\x64\x72\x6D\x3A > \x6D\x69\x70\x69\x2D\x64\x62\x69\x3A \x53\x69\x6C\x65\x6E\x63\x65\x3A > ‘\x63\x6D\x64’ \x6D\x61\x79 \x62\x65 Sorry, I don't have a clue on that one. If you have UTF-8 or other non-ASCII characters in your subject, format-patch will correctly do the rfc2047 encoding (and it should always use QP). And that would kick in here because of the UTF-8 quotes. But that weird "\x" encoding is not in any mail standard I know of (and certainly Git would never do it). The odd thing is that the quotes themselves _aren't_ encoded. Just everything else. One other feature is that subject line is long enough (especially QP-encoded) that it spans two lines: $ git format-patch --stdout -1 b401f34314d | grep -A1 ^Subject Subject: [PATCH] =?UTF-8?q?drm/tinydrm:=20mipi-dbi:=20Silence:=20=E2=80=98?= =?UTF-8?q?cmd=E2=80=99=20may=20be=20used=20uninitialized?= It's possible that something along the way is mis-handling subjects with line-continuation (though why it would escape those characters, I don't know). > and some of the mail headers end up in the body as well: > > =?UTF-8?Q?\x75\x73\x65\x64_\x75\x6E\x69\x6E\x69\x74\x69\x61\x6C\x69\x7A\x65\x64?= That might be related to the whitespace continuation (the first line after the break is the second line of the subject). -Peff ```