# Bug in 'git describe' if I have two tags on the same commit. 4 messages from 2017-02-12 to 2017-02-14. Participants: Istvan Pato, Kevin Daudt, Junio C Hamano. Thread: https://gitlist.dev/t/45118 ## Istvan Pato, 2017-02-12 12:15 Subject: Bug in 'git describe' if I have two tags on the same commit. Message-ID: URL: https://gitlist.dev/e/CAOcUJQwnCJOhUUU2RqJP2H5YxUr4qCEpyDj_XiiQSe4V6rcBmg%40mail.gmail.com ``` I didn't get back the latest tag by 'git describe --tags --always' if I have two tags on the same commit. // repository ppa:git-core/ppa (master)⚡ % cat /etc/lsb-release DISTRIB_ID=Ubuntu DISTRIB_RELEASE=16.04 DISTRIB_CODENAME=xenial DISTRIB_DESCRIPTION="Ubuntu 16.04.2 LTS" (master)⚡ % git --version git version 2.11.0 (master) [1] % git show-ref --tag 76c634390... refs/tags/1.0.0 b77c7cd17... refs/tags/1.1.0 b77c7cd17... refs/tags/1.2.0 (master) % git describe --tags --always 1.1.0-1-ge9e9ced ### Expected: 1.2.0 References: https://www.kernel.org/pub/software/scm/git/docs/RelNotes-1.7.1.1.txt * "git describe" did not tie-break tags that point at the same commit correctly; newer ones are preferred by paying attention to the tagger date now. http://stackoverflow.com/questions/8089002/git-describe-with-two-tags-on-the-same-commit Thanks, Istvan Pato ``` ## Kevin Daudt, 2017-02-13 15:44 Subject: Re: Bug in 'git describe' if I have two tags on the same commit. Message-ID: <20170213154407.GA31568@alpha.ikke.info> URL: https://gitlist.dev/e/20170213154407.GA31568%40alpha.ikke.info In-Reply-To: ``` On Sun, Feb 12, 2017 at 01:15:22PM +0100, Istvan Pato wrote: > I didn't get back the latest tag by 'git describe --tags --always' if > I have two tags on the same commit. > > // repository ppa:git-core/ppa > > (master)⚡ % cat /etc/lsb-release > DISTRIB_ID=Ubuntu > DISTRIB_RELEASE=16.04 > DISTRIB_CODENAME=xenial > DISTRIB_DESCRIPTION="Ubuntu 16.04.2 LTS" > > (master)⚡ % git --version > git version 2.11.0 > > (master) [1] % git show-ref --tag > 76c634390... refs/tags/1.0.0 > b77c7cd17... refs/tags/1.1.0 > b77c7cd17... refs/tags/1.2.0 > > (master) % git describe --tags --always > 1.1.0-1-ge9e9ced > > ### Expected: 1.2.0 > > References: > > https://www.kernel.org/pub/software/scm/git/docs/RelNotes-1.7.1.1.txt > > * "git describe" did not tie-break tags that point at the same commit > correctly; newer ones are preferred by paying attention to the > tagger date now. > > http://stackoverflow.com/questions/8089002/git-describe-with-two-tags-on-the-same-commit > > Thanks, > Istvan Pato Are these lightweight tags? Only annotated tags have a date associated to them, which is where the rel-notes refers to. ``` ## Junio C Hamano, 2017-02-13 20:35 Subject: Re: Bug in 'git describe' if I have two tags on the same commit. Message-ID: URL: https://gitlist.dev/e/xmqqo9y5de1k.fsf%40gitster.mtv.corp.google.com In-Reply-To: <20170213154407.GA31568@alpha.ikke.info> ``` Kevin Daudt writes: > On Sun, Feb 12, 2017 at 01:15:22PM +0100, Istvan Pato wrote: > >> (master) [1] % git show-ref --tag >> 76c634390... refs/tags/1.0.0 >> b77c7cd17... refs/tags/1.1.0 >> b77c7cd17... refs/tags/1.2.0 >> >> (master) % git describe --tags --always >> 1.1.0-1-ge9e9ced >> >> ### Expected: 1.2.0 >> ... > > Are these lightweight tags? Only annotated tags have a date associated > to them, which is where the rel-notes refers to. Good eyes. The fact that the two points at the same object means that even if they were both annotated tags, they have the same tagger dates. If the code that compares the candidates and picks better tag to describe the object with knows the refnames of these "tags", I'd imagine that we could use the versioncmp() logic as the final tie breaker, but I do not offhand remember if the original refname we took the tag (or commit) from is propagated that deep down the callchain. It probably does not, so some code refactoring may be needed if somebody wants to go in that direction. ``` ## Istvan Pato, 2017-02-14 08:07 Subject: Re: Bug in 'git describe' if I have two tags on the same commit. Message-ID: URL: https://gitlist.dev/e/CAOcUJQzEKoCf3T2AVzck1Y4NWb8N9FMqQ%3D%2B6z6-9C4YF8-jQzA%40mail.gmail.com In-Reply-To: ``` This is my fault: this is a lightweight tag. Thank you! 2017-02-13 21:35 GMT+01:00 Junio C Hamano : > Kevin Daudt writes: > >> On Sun, Feb 12, 2017 at 01:15:22PM +0100, Istvan Pato wrote: >> >>> (master) [1] % git show-ref --tag >>> 76c634390... refs/tags/1.0.0 >>> b77c7cd17... refs/tags/1.1.0 >>> b77c7cd17... refs/tags/1.2.0 >>> >>> (master) % git describe --tags --always >>> 1.1.0-1-ge9e9ced >>> >>> ### Expected: 1.2.0 >>> ... >> >> Are these lightweight tags? Only annotated tags have a date associated >> to them, which is where the rel-notes refers to. > > Good eyes. The fact that the two points at the same object means > that even if they were both annotated tags, they have the same > tagger dates. > > If the code that compares the candidates and picks better tag to > describe the object with knows the refnames of these "tags", I'd > imagine that we could use the versioncmp() logic as the final tie > breaker, but I do not offhand remember if the original refname we > took the tag (or commit) from is propagated that deep down the > callchain. It probably does not, so some code refactoring may be > needed if somebody wants to go in that direction. > > > > > ```