# [PATCH] completion: fix git svn authorship switches

1 messages from 2017-02-05 to 2017-02-05. Participants: Eric Wong.
Thread: https://gitlist.dev/t/45050

## Eric Wong, 2017-02-05 02:18

Subject: [PATCH] completion: fix git svn authorship switches
Message-ID: <20170205021857.GA1922@starla>
URL: https://gitlist.dev/e/20170205021857.GA1922%40starla

```
--add-author-from and --use-log-author are for "git svn dcommit",
not "git svn (init|clone)"

Signed-off-by: Eric Wong <e@80x24.org>
---
 contrib/completion/git-completion.bash | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

 Though, I now wonder if allowing those switches to write changes
 in $GIT_CONFIG at init/clone time makes sense...

diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 97d73ad88f..6990e98c44 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -2587,14 +2587,14 @@ _git_svn ()
 			--no-metadata --use-svm-props --use-svnsync-props
 			--log-window-size= --no-checkout --quiet
 			--repack-flags --use-log-author --localtime
+			--add-author-from
 			--ignore-paths= --include-paths= $remote_opts
 			"
 		local init_opts="
 			--template= --shared= --trunk= --tags=
 			--branches= --stdlayout --minimize-url
 			--no-metadata --use-svm-props --use-svnsync-props
-			--rewrite-root= --prefix= --use-log-author
-			--add-author-from $remote_opts
+			--rewrite-root= --prefix= $remote_opts
 			"
 		local cmt_opts="
 			--edit --rmdir --find-copies-harder --copy-similarity=
-- 
EW

```