# [PATCH] receive-pack: call string_list_clear() unconditionally 1 messages from 2017-01-29 to 2017-01-29. Participants: René Scharfe. Thread: https://gitlist.dev/t/45000 ## René Scharfe, 2017-01-29 13:09 Subject: [PATCH] receive-pack: call string_list_clear() unconditionally Message-ID: <3dd27c57-9ba5-fc31-6e7e-414408cd63af@web.de> URL: https://gitlist.dev/e/3dd27c57-9ba5-fc31-6e7e-414408cd63af%40web.de ``` string_list_clear() handles empty lists just fine, so remove the redundant check. Signed-off-by: Rene Scharfe --- builtin/receive-pack.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/builtin/receive-pack.c b/builtin/receive-pack.c index 6b97cbdbe..1dbb8a069 100644 --- a/builtin/receive-pack.c +++ b/builtin/receive-pack.c @@ -1942,8 +1942,7 @@ int cmd_receive_pack(int argc, const char **argv, const char *prefix) run_receive_hook(commands, "post-receive", 1, &push_options); run_update_post_hook(commands); - if (push_options.nr) - string_list_clear(&push_options, 0); + string_list_clear(&push_options, 0); if (auto_gc) { const char *argv_gc_auto[] = { "gc", "--auto", "--quiet", NULL, -- 2.11.0 ```