# [PATCH] git-bisect: allow running in a working tree subdirectory 5 messages from 2017-01-26 to 2017-01-26. Participants: marcandre.lureau@redhat.com, Stefan Beller, Junio C Hamano, Johannes Sixt. Thread: https://gitlist.dev/t/44982 ## marcandre.lureau@redhat.com, 2017-01-26 18:30 Subject: [PATCH] git-bisect: allow running in a working tree subdirectory Message-ID: <20170126183030.28632-1-marcandre.lureau@redhat.com> URL: https://gitlist.dev/e/20170126183030.28632-1-marcandre.lureau%40redhat.com ``` From: Marc-André Lureau It looks like it can do it. Signed-off-by: Marc-André Lureau --- git-bisect.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/git-bisect.sh b/git-bisect.sh index ae3cb013e..b0bd604d4 100755 --- a/git-bisect.sh +++ b/git-bisect.sh @@ -1,5 +1,6 @@ #!/bin/sh +SUBDIRECTORY_OK=Yes USAGE='[help|start|bad|good|new|old|terms|skip|next|reset|visualize|replay|log|run]' LONG_USAGE='git bisect help print this long help message. -- 2.11.0.295.gd7dffce1c.dirty ``` ## Stefan Beller, 2017-01-26 18:46 Subject: Re: [PATCH] git-bisect: allow running in a working tree subdirectory Message-ID: URL: https://gitlist.dev/e/CAGZ79kZkxnoKCyk9teQnEPjsnS7iEorZALY4dXE8Fy78ifur7g%40mail.gmail.com In-Reply-To: <20170126183030.28632-1-marcandre.lureau@redhat.com> ``` + Duy, main author of the worktree feature. On Thu, Jan 26, 2017 at 10:30 AM, wrote: > From: Marc-André Lureau > > It looks like it can do it. > > Signed-off-by: Marc-André Lureau > --- > git-bisect.sh | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/git-bisect.sh b/git-bisect.sh > index ae3cb013e..b0bd604d4 100755 > --- a/git-bisect.sh > +++ b/git-bisect.sh > @@ -1,5 +1,6 @@ > #!/bin/sh > > +SUBDIRECTORY_OK=Yes > USAGE='[help|start|bad|good|new|old|terms|skip|next|reset|visualize|replay|log|run]' > LONG_USAGE='git bisect help > print this long help message. > -- > 2.11.0.295.gd7dffce1c.dirty > ``` ## Junio C Hamano, 2017-01-26 19:34 Subject: Re: [PATCH] git-bisect: allow running in a working tree subdirectory Message-ID: URL: https://gitlist.dev/e/xmqqk29h4nv4.fsf%40gitster.mtv.corp.google.com In-Reply-To: ``` Stefan Beller writes: > + Duy, main author of the worktree feature. > > On Thu, Jan 26, 2017 at 10:30 AM, wrote: >> From: Marc-André Lureau >> >> It looks like it can do it. >> >> Signed-off-by: Marc-André Lureau >> --- I do not think the OP meant by "a working tree subdirectory" using the command in a secondary worktree. SUBDIRECTORY_OK is about "can the command be started in a subdirectory (as opposed to requiring to be run only at the toplevel)?" I am slightly negative on this change, though. The subdirectory you are sitting in when you start your bisection may disappear and reappear as you dig the history, and I do not think the code makes anything special to prevent the disappearing current directory from getting in the way of bisection process. >> git-bisect.sh | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/git-bisect.sh b/git-bisect.sh >> index ae3cb013e..b0bd604d4 100755 >> --- a/git-bisect.sh >> +++ b/git-bisect.sh >> @@ -1,5 +1,6 @@ >> #!/bin/sh >> >> +SUBDIRECTORY_OK=Yes >> USAGE='[help|start|bad|good|new|old|terms|skip|next|reset|visualize|replay|log|run]' >> LONG_USAGE='git bisect help >> print this long help message. >> -- >> 2.11.0.295.gd7dffce1c.dirty >> ``` ## Johannes Sixt, 2017-01-26 21:46 Subject: Re: [PATCH] git-bisect: allow running in a working tree subdirectory Message-ID: <96afaa1d-31d7-0b7e-d2b3-77a455158638@kdbg.org> URL: https://gitlist.dev/e/96afaa1d-31d7-0b7e-d2b3-77a455158638%40kdbg.org In-Reply-To: <20170126183030.28632-1-marcandre.lureau@redhat.com> ``` Am 26.01.2017 um 19:30 schrieb marcandre.lureau@redhat.com: > From: Marc-André Lureau > > It looks like it can do it. > > Signed-off-by: Marc-André Lureau > --- > git-bisect.sh | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/git-bisect.sh b/git-bisect.sh > index ae3cb013e..b0bd604d4 100755 > --- a/git-bisect.sh > +++ b/git-bisect.sh > @@ -1,5 +1,6 @@ > #!/bin/sh > > +SUBDIRECTORY_OK=Yes > USAGE='[help|start|bad|good|new|old|terms|skip|next|reset|visualize|replay|log|run]' > LONG_USAGE='git bisect help > print this long help message. > Does it also work to drive git bisect from a subdirectory and pass a file name (or pathspec) that is relative to that subdirectory rather than relative to the root of the worktree? Can `git bisect good` or `git bisect bad` of later bisection steps be invoked from different subdirectories or the root? -- Hannes ``` ## Junio C Hamano, 2017-01-26 23:22 Subject: Re: [PATCH] git-bisect: allow running in a working tree subdirectory Message-ID: URL: https://gitlist.dev/e/xmqqziid1k51.fsf%40gitster.mtv.corp.google.com In-Reply-To: <96afaa1d-31d7-0b7e-d2b3-77a455158638@kdbg.org> ``` Johannes Sixt writes: > Am 26.01.2017 um 19:30 schrieb marcandre.lureau@redhat.com: >> From: Marc-André Lureau >> >> It looks like it can do it. >> >> Signed-off-by: Marc-André Lureau >> --- >> git-bisect.sh | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/git-bisect.sh b/git-bisect.sh >> index ae3cb013e..b0bd604d4 100755 >> --- a/git-bisect.sh >> +++ b/git-bisect.sh >> @@ -1,5 +1,6 @@ >> #!/bin/sh >> >> +SUBDIRECTORY_OK=Yes >> USAGE='[help|start|bad|good|new|old|terms|skip|next|reset|visualize|replay|log|run]' >> LONG_USAGE='git bisect help >> print this long help message. >> > > Does it also work to drive git bisect from a subdirectory and pass a > file name (or pathspec) that is relative to that subdirectory rather > than relative to the root of the worktree? Can `git bisect good` or > `git bisect bad` of later bisection steps be invoked from different > subdirectories or the root? I think the answers are no and no. Entries in BISECT_NAMES and BISECT_LOG are not getting any prefix. ```