Bug: git-sh-setup giving no such file or directory

Hi

There appears to be an issue with the latest master.

"git submodule init" is producing the following error:

/home/paul.boyle/bin/git/git-sh-setup: line 46: /home/paul.boyle/libexec/git-core/git-sh-i18n: No such file or directory

Broken sha: 8d7a455ed52e2a96debc080dfc011b6bb00db5d2

Checking out an older version works fine.

git checkout 'master@{2016-11-01 18:30:00}'

Sha: 3cdd5d19178a54d2e51b5098d43b57571241d0ab

This can be reproduced simply by:

make clean ; make ; git submodule init

I didn't track it down further than to a commit sometime in the last month.

Details of machine that this is happening on:

[paul.boyle@gonzo git]$ cat /etc/redhat-release

Scientific Linux release 6.8 (Carbon)

[paul.boyle@gonzo git]$ env

SSH_AGENT_PID=29474

HOSTNAME=gonzo

TERM=xterm

SHELL=/bin/bash

HISTSIZE=1000

SSH_CLIENT=

QTDIR=/usr/lib64/qt-3.3

QTINC=/usr/lib64/qt-3.3/include

SSH_TTY=/dev/pts/135

USER=paul.boyle

LS_COLORS=rs=0:di=01;34:ln=01;36:mh=00:pi=40;33:so=01;35:do=01;35:bd=40;33;01:cd=40;33;01:or=40;31;01:mi=01;05;37;41:su=37;41:sg=30;43:ca=30;41:tw=30;42:ow=34;42:st=37;44:ex=01;32:*.tar=01;31:*.tgz=01;31:*.arj=01;31:*.taz=01;31:*.lzh=01;31:*.lzma=01;31:*.tlz=01;31:*.txz=01;31:*.zip=01;31:*.z=01;31:*.Z=01;31:*.dz=01;31:*.gz=01;31:*.lz=01;31:*.xz=01;31:*.bz2=01;31:*.tbz=01;31:*.tbz2=01;31:*.bz=01;31:*.tz=01;31:*.deb=01;31:*.rpm=01;31:*.jar=01;31:*.rar=01;31:*.ace=01;31:*.zoo=01;31:*.cpio=01;31:*.7z=01;31:*.rz=01;31:*.jpg=01;35:*.jpeg=01;35:*.gif=01;35:*.bmp=01;35:*.pbm=01;35:*.pgm=01;35:*.ppm=01;35:*.tga=01;35:*.xbm=01;35:*.xpm=01;35:*.tif=01;35:*.tiff=01;35:*.png=01;35:*.svg=01;35:*.svgz=01;35:*.mng=01;35:*.pcx=01;35:*.mov=01;35:*.mpg=01;35:*.mpeg=01;35:*.m2v=01;35:*.mkv=01;35:*.ogm=01;35:*.mp4=01;35:*.m4v=01;35:*.mp4v=01;35:*.vob=01;35:*.qt=01;35:*.nuv=01;35:*.wmv=01;35:*.asf=01;35:*.rm=01;35:*.rmvb=01;35:*.flc=01;35:*.avi=01;35:*.fli=01;35:*.flv=01;35:*.gl=01;35:*.dl=01;35:*.xcf=01;35:*.xwd=01;35:*.yuv=01;35:*.cgm=01;35:*.emf=01;35:*.axv=01;35:*.anx=01;35:*.ogv=01;35:*.ogx=01;35:*.aac=01;36:*.au=01;36:*.flac=01;36:*.mid=01;36:*.midi=01;36:*.mka=01;36:*.mp3=01;36:*.mpc=01;36:*.ogg=01;36:*.ra=01;36:*.wav=01;36:*.axa=01;36:*.oga=01;36:*.spx=01;36:*.xspf=01;36:

SSH_AUTH_SOCK=/tmp/ssh-oXONs29470/agent.29470

MAIL=/var/spool/mail/paul.boyle

PATH=/home/paul.boyle/bin/git:/home/paul.boyle/bin/tig:/home/paul.boyle/bin:/usr/lib64/qt-3.3/bin:/usr/local/bin:/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/sbin:/home/paul.boyle/bin

PWD=/home/paul.boyle/bin/git

LANG=en_IE.UTF-8

HISTCONTROL=ignoredups

SHLVL=1

HOME=/home/paul.boyle

LOGNAME=paul.boyle

QTLIB=/usr/lib64/qt-3.3/lib

CVS_RSH=ssh

SSH_CONNECTION=

LESSOPEN=||/usr/bin/lesspipe.sh %s

G_BROKEN_FILENAMES=1

OLDPWD=/home/paul.boyle/

_=/bin/env

On Fri, Dec 09, 2016 at 12:00:36PM +0000, Paul Boyle wrote:

Hmm. Did you run "make install"? Or are you trying to run git directly out of the build directory?

If the latter, that has been unsupported for a while, though it mostly works. The "right" way is to either set up GIT_EXEC_PATH as appropriate, or to just .../git/bin-wrappers into your $PATH.

You could probably find the exact commit with git-bisect. However, I'd be surprised if it is anything but 1073094f3 (git-sh-setup: be explicit where to dot-source git-sh-i18n from., 2016-10-29). Before that commit, we found git-sh-i18n in the $PATH, which would work if you were adding git's build directory to your $PATH (but not work for people who actually did an install).

-Peff

This was the source of it. Root cause, a stupid user ;) I'd a PATH setup to the build directory. Changing the path to bin-wrappers fixed it up.

Thanks!

On Fri, Dec 9, 2016 at 1:45 PM, Jeff King <peff@peff.net> wrote: