# [PATCH] Completion: Add support for --submodule=diff 6 messages from 2016-12-04 to 2017-02-06. Participants: peterjclaw@gmail.com, Peter Law, Brandon Williams, Junio C Hamano, Jacob Keller. Thread: https://gitlist.dev/t/44613 ## peterjclaw@gmail.com, 2016-12-04 14:41 Subject: [PATCH] Completion: Add support for --submodule=diff Message-ID: <20161204144127.28452-1-peterjclaw@gmail.com> URL: https://gitlist.dev/e/20161204144127.28452-1-peterjclaw%40gmail.com ``` From: Peter Law Teach git-completion.bash about the 'diff' option to 'git diff --submodule=', which was added in Git 2.11. Signed-off-by: Peter Law --- contrib/completion/git-completion.bash | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index 21016bf8d..ab11e7371 100644 --- a/contrib/completion/git-completion.bash +++ b/contrib/completion/git-completion.bash @@ -1206,7 +1206,7 @@ _git_describe () __git_diff_algorithms="myers minimal patience histogram" -__git_diff_submodule_formats="log short" +__git_diff_submodule_formats="diff log short" __git_diff_common_options="--stat --numstat --shortstat --summary --patch-with-stat --name-only --name-status --color -- 2.11.0 ``` ## Peter Law, 2017-01-30 21:13 Subject: Re: [PATCH] Completion: Add support for --submodule=diff Message-ID: URL: https://gitlist.dev/e/CAKoneT%2BBn%2BMdbeNnPJsu23rbLCZ%3DjxADNVtpNefw9zNYMq26dA%40mail.gmail.com In-Reply-To: <20161204144127.28452-1-peterjclaw@gmail.com> ``` Hi, > Teach git-completion.bash about the 'diff' option to 'git diff > --submodule=', which was added in Git 2.11. I posted this patch back in December, but I've not heard anything. I'm sure as maintainers you're all quite busy, but I was wondering how long it usually takes to get a response to patches? (also whether I'd gotten some part of the submission process wrong?) Thanks, Peter ``` ## Brandon Williams, 2017-01-30 21:43 Subject: Re: [PATCH] Completion: Add support for --submodule=diff Message-ID: <20170130214312.GB35626@google.com> URL: https://gitlist.dev/e/20170130214312.GB35626%40google.com In-Reply-To: ``` On 01/30, Peter Law wrote: > Hi, > > > Teach git-completion.bash about the 'diff' option to 'git diff > > --submodule=', which was added in Git 2.11. > > I posted this patch back in December, but I've not heard anything. I'm > sure as maintainers you're all quite busy, but I was wondering how > long it usually takes to get a response to patches? (also whether I'd > gotten some part of the submission process wrong?) > > Thanks, > Peter It looks like this must have just fallen through the cracks. Your patch looks good to me and works when I test it locally. -- Brandon Williams ``` ## Junio C Hamano, 2017-01-30 23:03 Subject: Re: [PATCH] Completion: Add support for --submodule=diff Message-ID: URL: https://gitlist.dev/e/xmqq4m0gtakk.fsf%40gitster.mtv.corp.google.com In-Reply-To: ``` Peter Law writes: >> Teach git-completion.bash about the 'diff' option to 'git diff >> --submodule=', which was added in Git 2.11. > > I posted this patch back in December, but I've not heard anything. I'm > sure as maintainers you're all quite busy, but I was wondering how > long it usually takes to get a response to patches? (also whether I'd > gotten some part of the submission process wrong?) When there is clear "subsystem maintainer(s)" in the area, I try to refrain from commenting until they speak up, and completion scripts are one of these areas. I usually ping them after a few days but in December with holidays and things people are usually slow, and so was I X-<. Will pick it up. Thanks for a reminder; you absolutely did the right thing (i.e. sending it out with people who are likely to know about the area CC'ed, waiting for a while and then sending a reminder). ``` ## Jacob Keller, 2017-01-31 00:10 Subject: Re: [PATCH] Completion: Add support for --submodule=diff Message-ID: URL: https://gitlist.dev/e/CA%2BP7%2BxqYGigV%3D8k_vS%2B4Y5fS2ORHUjYOnNRsAGYb1BwCx13xzg%40mail.gmail.com In-Reply-To: <20161204144127.28452-1-peterjclaw@gmail.com> ``` On Sun, Dec 4, 2016 at 6:41 AM, wrote: > From: Peter Law > > Teach git-completion.bash about the 'diff' option to 'git diff > --submodule=', which was added in Git 2.11. > > Signed-off-by: Peter Law > --- > contrib/completion/git-completion.bash | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash > index 21016bf8d..ab11e7371 100644 > --- a/contrib/completion/git-completion.bash > +++ b/contrib/completion/git-completion.bash > @@ -1206,7 +1206,7 @@ _git_describe () > > __git_diff_algorithms="myers minimal patience histogram" > > -__git_diff_submodule_formats="log short" > +__git_diff_submodule_formats="diff log short" > > __git_diff_common_options="--stat --numstat --shortstat --summary > --patch-with-stat --name-only --name-status --color > -- > 2.11.0 > Yep, this looks good to me. Thanks, Jake ``` ## Peter Law, 2017-02-06 22:56 Subject: Re: [PATCH] Completion: Add support for --submodule=diff Message-ID: URL: https://gitlist.dev/e/CAKoneTL3-1ohv22mm-RpZ-2sNbFeAV62wOS-JoE0r2Dcn_2E3A%40mail.gmail.com In-Reply-To: ``` Hi, Junio C Hamano wrote: > Peter Law writes: > >>> Teach git-completion.bash about the 'diff' option to 'git diff >>> --submodule=', which was added in Git 2.11. >> >> I posted this patch back in December, but I've not heard anything. I'm >> sure as maintainers you're all quite busy, but I was wondering how >> long it usually takes to get a response to patches? (also whether I'd >> gotten some part of the submission process wrong?) > > When there is clear "subsystem maintainer(s)" in the area, I try to > refrain from commenting until they speak up, and completion scripts > are one of these areas. I usually ping them after a few days but in > December with holidays and things people are usually slow, and so > was I X-<. > > Will pick it up. Thanks for a reminder; you absolutely did the > right thing (i.e. sending it out with people who are likely to know > about the area CC'ed, waiting for a while and then sending a > reminder). Awesome, many thanks! Peter ```