# [PATCH] worktree: mark a file-local symbol with static

2 messages from 2016-12-02 to 2016-12-02. Participants: Ramsay Jones, Stefan Beller.
Thread: https://gitlist.dev/t/44598

## Ramsay Jones, 2016-12-02 20:55

Subject: [PATCH] worktree: mark a file-local symbol with static
Message-ID: <0be15cd5-4ecb-3d87-93ee-d34d2be2d4c6@ramsayjones.plus.com>
URL: https://gitlist.dev/e/0be15cd5-4ecb-3d87-93ee-d34d2be2d4c6%40ramsayjones.plus.com

```

Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---

Hi Stefan,

If you need to re-roll your 'sb/submodule-intern-gitdir'
branch, could you please squash something similar to this
into the relevant patch (commit 2529715dc, "worktree: get
worktrees from submodules", 01-12-2016).

[This is based on pu; ie. on top of merge 86c7f863a, where
Junio as added the 'flags' parameter.]

Thanks!

ATB,
Ramsay Jones

 worktree.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/worktree.c b/worktree.c
index d5c71095e..ba393fe5c 100644
--- a/worktree.c
+++ b/worktree.c
@@ -168,7 +168,7 @@ static int compare_worktree(const void *a_, const void *b_)
 	return fspathcmp((*a)->path, (*b)->path);
 }
 
-struct worktree **get_worktrees_internal(const char *git_common_dir, unsigned flags)
+static struct worktree **get_worktrees_internal(const char *git_common_dir, unsigned flags)
 {
 	struct worktree **list = NULL;
 	struct strbuf path = STRBUF_INIT;
-- 
2.11.0

```

## Stefan Beller, 2016-12-02 21:58

Subject: Re: [PATCH] worktree: mark a file-local symbol with static
Message-ID: <CAGZ79kaXeFOL0k1tqPxk76XLrkRH_ApZPC7V=kKK3xN=mPbxJQ@mail.gmail.com>
URL: https://gitlist.dev/e/CAGZ79kaXeFOL0k1tqPxk76XLrkRH_ApZPC7V%3DkKK3xN%3DmPbxJQ%40mail.gmail.com
In-Reply-To: <0be15cd5-4ecb-3d87-93ee-d34d2be2d4c6@ramsayjones.plus.com>

```
On Fri, Dec 2, 2016 at 12:55 PM, Ramsay Jones
<ramsay@ramsayjones.plus.com> wrote:
>
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi Stefan,
>
> If you need to re-roll your 'sb/submodule-intern-gitdir'
> branch,

I will need to reroll it.

> could you please squash something similar to this
> into the relevant patch (commit 2529715dc, "worktree: get
> worktrees from submodules", 01-12-2016).
>
> [This is based on pu; ie. on top of merge 86c7f863a, where
> Junio as added the 'flags' parameter.]

Oh, ok. I may just reroll the series on top of nd/worktree-list-fixup

Thanks for the annotation!
Stefan

```
