threads / patch / 44533

patchgit-gui: pass the branch name to git merge

Subject: [PATCH] git-gui: pass the branch name to git merge

## tl;dr

6 messages between Nov 22, 2016 and Nov 23, 2016. Diffs are folded; open one to read it.

replies: 5people: 2as markdown or json

Johannes Sixt· Nov 22, 2016, 17:52 UTC · lore

The recent rewrite of the 'git merge' invocation in b5f325cb (git-gui: stop using deprecated merge syntax) replaced the subsidiary call of 'git fmt-merge-msg' to take advantage of the capability of 'git merge' that can construct a merge log message when the rev being merged is FETCH_HEAD.

A disadvantage of this method is, though, that the conflict markers are augmented with a raw SHA1 instead of a symbolic branch name. Revert to the former invocation style so that we get both a useful commit message and a symbolic name in the conflict markers.

Signed-off-by: Johannes Sixt <j6t@kdbg.org>
---
 A minor regression of our effort to get rid of
 deprecated merge syntax. Even though I had done a number of
 merges since then, I noticed this only today because I
 actively looked for the branch name.

 lib/merge.tcl | 13 +++----------
 1 file changed, 3 insertions(+), 10 deletions(-)

Show changes to lib/merge.tcl +3 −10

diff --git a/lib/merge.tcl b/lib/merge.tcl
index 9f253db..39e3fb4 100644
--- a/lib/merge.tcl
+++ b/lib/merge.tcl
@@ -112,16 +112,9 @@ method _start {} {
 	close $fh
 	set _last_merged_branch $branch
 
-	if {[git-version >= "2.5.0"]} {
-		set cmd [list git merge --strategy=recursive FETCH_HEAD]
-	} else {
-		set cmd [list git]
-		lappend cmd merge
-		lappend cmd --strategy=recursive
-		lappend cmd [git fmt-merge-msg <[gitdir FETCH_HEAD]]
-		lappend cmd HEAD
-		lappend cmd $name
-	}
+	set cmd [list git merge --strategy=recursive --no-log -m]
+	lappend cmd [git fmt-merge-msg <[gitdir FETCH_HEAD]]
+	lappend cmd $name
 
 	ui_status [mc "Merging %s and %s..." $current_branch $stitle]
 	set cons [console::new [mc "Merge"] "merge $stitle"]

-- 
2.11.0.rc1.52.g65ffb51

Junio C Hamano· Nov 22, 2016, 19:16 UTC · re: Johannes Sixt · lore

Re: [PATCH] git-gui: pass the branch name to git merge

Johannes Sixt <j6t@kdbg.org> writes:

Show 9 quoted lines

> The recent rewrite of the 'git merge' invocation in b5f325cb
> (git-gui: stop using deprecated merge syntax) replaced the
> subsidiary call of 'git fmt-merge-msg' to take advantage of
> the capability of 'git merge' that can construct a merge log
> message when the rev being merged is FETCH_HEAD.
>
> A disadvantage of this method is, though, that the conflict
> markers are augmented with a raw SHA1 instead of a symbolic
> branch name.

Can't this be handled on the "git merge FETCH_HEAD" codepath instead? The codepath already does enough "magic" things to FETCH_HEAD like skipping 'not-for-merge' entries and also knows about the original refnames the commits to be merged came from.

Johannes Sixt· Nov 22, 2016, 20:40 UTC · re: Junio C Hamano · lore

Re: [PATCH] git-gui: pass the branch name to git merge

Am 22.11.2016 um 20:16 schrieb Junio C Hamano:

> Can't this be handled on the "git merge FETCH_HEAD" codepath
> instead?

Absolutely. Any takers? ;)

-- Hannes

Johannes Sixt· Nov 23, 2016, 19:23 UTC · re: Johannes Sixt · lore

Re: [PATCH] git-gui: pass the branch name to git merge

Am 22.11.2016 um 21:40 schrieb Johannes Sixt:

Show 5 quoted lines

> Am 22.11.2016 um 20:16 schrieb Junio C Hamano:
>> Can't this be handled on the "git merge FETCH_HEAD" codepath
>> instead?
>
> Absolutely. Any takers? ;)

I attempted to fix git merge FETCH_HEAD, but I do not see a trivial solution.

But on second thought, we have an excuse to pick my proposed git-gui change anyway: Without that change and a fix in git-merge only, there is still a regression for all users who use the latest git-gui but some git version between 2.5.0 and the fixed git-merge...

-- Hannes

Junio C Hamano· Nov 23, 2016, 20:05 UTC · re: Johannes Sixt · lore

Re: [PATCH] git-gui: pass the branch name to git merge

Johannes Sixt <j6t@kdbg.org> writes:

Show 14 quoted lines

> Am 22.11.2016 um 21:40 schrieb Johannes Sixt:
>> Am 22.11.2016 um 20:16 schrieb Junio C Hamano:
>>> Can't this be handled on the "git merge FETCH_HEAD" codepath
>>> instead?
>>
>> Absolutely. Any takers? ;)
>
> I attempted to fix git merge FETCH_HEAD, but I do not see a trivial
> solution.
>
> But on second thought, we have an excuse to pick my proposed git-gui
> change anyway: Without that change and a fix in git-merge only, there
> is still a regression for all users who use the latest git-gui but
> some git version between 2.5.0 and the fixed git-merge...

I'll leave it up to Pat, as I do not read tcl very well ;-)

Johannes Sixt· Nov 23, 2016, 22:36 UTC · re: Junio C Hamano · lore

Re: [PATCH] git-gui: pass the branch name to git merge

Am 23.11.2016 um 21:05 schrieb Junio C Hamano:

Show 17 quoted lines

> Johannes Sixt <j6t@kdbg.org> writes:
>> Am 22.11.2016 um 21:40 schrieb Johannes Sixt:
>>> Am 22.11.2016 um 20:16 schrieb Junio C Hamano:
>>>> Can't this be handled on the "git merge FETCH_HEAD" codepath
>>>> instead?
>>>
>>> Absolutely. Any takers? ;)
>>
>> I attempted to fix git merge FETCH_HEAD, but I do not see a trivial
>> solution.
>>
>> But on second thought, we have an excuse to pick my proposed git-gui
>> change anyway: Without that change and a fix in git-merge only, there
>> is still a regression for all users who use the latest git-gui but
>> some git version between 2.5.0 and the fixed git-merge...
> 
> I'll leave it up to Pat, as I do not read tcl very well ;-)

Sure!

In the mean time, here is my attempt to fix git merge FETCH_HEAD. I would feel better if this were just taken as a starter for a real fix by someone who is familiar with the area.

---- 8< ---- [PATCH] merge FETCH_HEAD: keep track of the branch names

'git merge FETCH_HEAD' is treated differently from 'git merge topic' because FETCH_HEAD is not just a regular ref name, but contains the names of the branches being merged. However, 'git merge' does not store the names as the "remote description" of the merge parent structure that is associated with merged commits, like an ordinary 'git merge topic' call does for the command line arguments. A consequence is that conflict markers are not marked up with the branch name, but with a raw object name. Parse off the branch names from the FETCH_HEAD file and store them with the merged commits.

Signed-off-by: Johannes Sixt <j6t@kdbg.org>
---
 builtin/merge.c | 8 ++++++++
 commit.c        | 1 +
 2 files changed, 9 insertions(+)

Show changes to 2 files +9 −0

builtin/merge.c, commit.c

diff --git a/builtin/merge.c b/builtin/merge.c
index b65eeaa87d..328517b091 100644
--- a/builtin/merge.c
+++ b/builtin/merge.c
@@ -1051,9 +1051,17 @@ static void handle_fetch_head(struct commit_list **remotes, struct strbuf *merge
 			continue; /* not-for-merge */
 		else {
 			char saved = merge_names->buf[pos + 40];
+			char eol = ptr ? *ptr : '\0';
 			merge_names->buf[pos + 40] = '\0';
+			if (ptr)
+				*ptr = '\0';
 			commit = get_merge_parent(merge_names->buf + pos);
+			set_merge_remote_desc(commit,
+					merge_names->buf + pos + 40 + 2,
+					merge_remote_util(commit)->obj);
 			merge_names->buf[pos + 40] = saved;
+			if (ptr)
+				*ptr = eol;
 		}
 		if (!commit) {
 			if (ptr)
diff --git a/commit.c b/commit.c
index 856fd4aeef..7ac2ce6518 100644
--- a/commit.c
+++ b/commit.c
@@ -1582,6 +1582,7 @@ void set_merge_remote_desc(struct commit *commit,
 	struct merge_remote_desc *desc;
 	FLEX_ALLOC_STR(desc, name, name);
 	desc->obj = obj;
+	free(commit->util);
 	commit->util = desc;
 }

-- 
2.11.0.rc1.52.g65ffb51