# [GIT GUI l18n 1/2] git-gui: Mark 'All' in remote.tcl for translation

2 messages from 2016-10-13 to 2016-10-14. Participants: Alexander Shopov, Pat Thoyts.
Thread: https://gitlist.dev/t/44294

## Alexander Shopov, 2016-10-13 18:43

Subject: [GIT GUI l18n 1/2] git-gui: Mark 'All' in remote.tcl for translation
Message-ID: <20161013184349.42950-1-ash@kambanaria.org>
URL: https://gitlist.dev/e/20161013184349.42950-1-ash%40kambanaria.org

```
Signed-off-by: Alexander Shopov <ash@kambanaria.org>
---
 lib/remote.tcl | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/remote.tcl b/lib/remote.tcl
index 4e5c784..26af8ae 100644
--- a/lib/remote.tcl
+++ b/lib/remote.tcl
@@ -250,12 +250,12 @@ proc update_all_remotes_menu_entry {} {
 
 			$fetch_m insert end separator
 			$fetch_m insert end command \
-				-label "All" \
+			    -label [mc "All"] \
 				-command fetch_from_all
 
 			$prune_m insert end separator
 			$prune_m insert end command \
-				-label "All" \
+			    -label [mc "All" ]\
 				-command prune_from_all
 		}
 	} else {
-- 
2.10.1


```

## Pat Thoyts, 2016-10-14 00:46

Subject: Re: [GIT GUI l18n 1/2] git-gui: Mark 'All' in remote.tcl for translation
Message-ID: <87a8e73ggb.fsf@red.patthoyts.tk>
URL: https://gitlist.dev/e/87a8e73ggb.fsf%40red.patthoyts.tk
In-Reply-To: <20161013184349.42950-1-ash@kambanaria.org>

```
Alexander Shopov <ash@kambanaria.org> writes:

>Signed-off-by: Alexander Shopov <ash@kambanaria.org>
>---
> lib/remote.tcl | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/lib/remote.tcl b/lib/remote.tcl
>index 4e5c784..26af8ae 100644
>--- a/lib/remote.tcl
>+++ b/lib/remote.tcl
>@@ -250,12 +250,12 @@ proc update_all_remotes_menu_entry {} {
> 
> 			$fetch_m insert end separator
> 			$fetch_m insert end command \
>-				-label "All" \
>+			    -label [mc "All"] \
> 				-command fetch_from_all
> 
> 			$prune_m insert end separator
> 			$prune_m insert end command \
>-				-label "All" \
>+			    -label [mc "All" ]\
> 				-command prune_from_all
> 		}
> 	} else {

OK - this looks fine except the line just above compares the text of
this entry so also needs [mc] adding. I've applied it as:

-- a/lib/remote.tcl
+++ b/lib/remote.tcl
@@ -246,22 +246,22 @@ proc update_all_remotes_menu_entry {} {
        if {$have_remote > 1} {
                make_sure_remote_submenues_exist $remote_m
                if {[$fetch_m type end] eq "command" \
-                       && [$fetch_m entrycget end -label] ne "All"} {
+                               && [$fetch_m entrycget end -label] ne [mc "All"]} {
 
                        $fetch_m insert end separator
                        $fetch_m insert end command \
-                               -label "All" \
+                               -label [mc "All"] \
                                -command fetch_from_all
 
                        $prune_m insert end separator
                        $prune_m insert end command \
-                               -label "All" \
+                               -label [mc "All"] \
                                -command prune_from_all
                }
        } else {
                if {[winfo exists $fetch_m]} {
                        if {[$fetch_m type end] eq "command" \
-                               && [$fetch_m entrycget end -label] eq "All"} {
+                                       && [$fetch_m entrycget end -label] eq [mc "All"]} {
 
                                delete_from_menu $fetch_m end
                                delete_from_menu $fetch_m end


-- 
Pat Thoyts                            http://www.patthoyts.tk/
PGP fingerprint 2C 6E 98 07 2C 59 C8 97  10 CE 11 E6 04 E0 B9 DD

```