threads / discuss / 44198

Setting pager.add=true breaks add --patch

Subject: Setting pager.add=true breaks add --patch

## tl;dr

4 messages between Oct 2, 2016 and Oct 6, 2016.

replies: 3people: 4as markdown or json

Ravi (Tom) Hale· Oct 2, 2016, 10:50 UTC · lore

Given:

1) git version 2.10.0.GIT

2) The following configuration:
=======================
[core]
   pager = less -FRX --tabs=4

[pager]
   add = true
=======================

3) A patch hunk longer than a screen

THEN:

less will be invoked as expected.

However, upon exiting less, I am dropped back to the shell, whereas I would expect to see: Stage this hunk [y,n,q,a,d,/,j,J,g,e,?]?

-- 
Tom Hale

Anatoly Borodin· Oct 2, 2016, 17:00 UTC · re: Ravi (Tom) Hale · lore

Re: Setting pager.add=true breaks add --patch

Hi Ravi,

I've reported this one bug recently:

https://public-inbox.org/git/nrmbrl$hsk$1@blaine.gmane.org/

The developers know about it, but it will require some deeper refactoring.

-- 
Mit freundlichen Grüßen,
Anatoly Borodin

Tom Hale· Oct 6, 2016, 03:55 UTC · re: Anatoly Borodin · lore

Re: Setting pager.add=true breaks add --patch

On 2016-10-03 00:00, Anatoly Borodin wrote:

Show 5 quoted lines

> I've reported this one bug recently:
>
> https://public-inbox.org/git/nrmbrl$hsk$1@blaine.gmane.org/
>
> The developers know about it, but it will require some deeper refactoring.

Thanks Anatoly for reporting this.

[Meta] All: For updates, is there an issue I can watch, or a way to subscribe/monitor only this one thread?

-- 
Cheers,
Tom

Kevin Daudt· Oct 6, 2016, 04:52 UTC · re: Tom Hale · lore

Re: Setting pager.add=true breaks add --patch

On Thu, Oct 06, 2016 at 10:55:11AM +0700, Tom Hale wrote:

Show 12 quoted lines

> On 2016-10-03 00:00, Anatoly Borodin wrote:
> > I've reported this one bug recently:
> > 
> > https://public-inbox.org/git/nrmbrl$hsk$1@blaine.gmane.org/
> > 
> > The developers know about it, but it will require some deeper refactoring.
> 
> Thanks Anatoly for reporting this.
> 
> [Meta] All: For updates, is there an issue I can watch, or a way to
> subscribe/monitor only this one thread?
>

public-inbox.org provides an atom feed[0] which you could add to a reader.

I don't think you can just subscribe to a single thread in the mailing list, but you can ask to be cc-ed in that thread.

[0]:https://public-inbox.org/git/nrmbrl$hsk$1@blaine.gmane.org/t.atom