threads / patch / 44170

patchworktree: honor configuration variables

Subject: [PATCH] worktree: honor configuration variables

## tl;dr

One message between Sep 27, 2016 and Sep 27, 2016. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Junio C Hamano· Sep 27, 2016, 06:49 UTC · lore

The command accesses default_abbrev (defined in environment.c and is updated via core.abbrev configuration), but never makes any call to git_config(). The output from "worktree list" ignores the abbrev setting for this reason.

Make a call to git_config() to read the default set of configuration variables at the beginning of the command.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 builtin/worktree.c | 2 ++
 1 file changed, 2 insertions(+)
Show changes to builtin/worktree.c +2 −0
diff --git a/builtin/worktree.c b/builtin/worktree.c
index 6dcf7bd..5c4854d 100644
--- a/builtin/worktree.c
+++ b/builtin/worktree.c
@@ -528,6 +528,8 @@ int cmd_worktree(int ac, const char **av, const char *prefix)
 		OPT_END()
 	};
 
+	git_config(git_default_config, NULL);
+
 	if (ac < 2)
 		usage_with_options(worktree_usage, options);
 	if (!prefix)
-- 
2.10.0-561-g98a6b79

← back to recent threads