# [PATCH] builtin-grep: pass ignore case option to external grep

2 messages from 2006-06-06 to 2006-06-06. Participants: Robert Fitzsimons, Linus Torvalds.
Thread: https://gitlist.dev/t/4415

## Robert Fitzsimons, 2006-06-06 23:15

Subject: [PATCH] builtin-grep: pass ignore case option to external grep
Message-ID: <20060606231516.GA18405@localhost>
URL: https://gitlist.dev/e/20060606231516.GA18405%40localhost

```
Don't just read the --ignore-case/-i option, pass the flag on to the
external grep program.

Signed-off-by: Robert Fitzsimons <robfitz@273k.net>
---
 builtin-grep.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/builtin-grep.c b/builtin-grep.c
index acc4eea..5fac570 100644
--- a/builtin-grep.c
+++ b/builtin-grep.c
@@ -459,6 +459,8 @@ static int external_grep(struct grep_opt
 		push_arg("-n");
 	if (opt->regflags & REG_EXTENDED)
 		push_arg("-E");
+	if (opt->regflags & REG_ICASE)
+		push_arg("-i");
 	if (opt->word_regexp)
 		push_arg("-w");
 	if (opt->name_only)
-- 
1.3.3.g16a4-dirty

```

## Linus Torvalds, 2006-06-06 23:27

Subject: Re: [PATCH] builtin-grep: pass ignore case option to external grep
Message-ID: <Pine.LNX.4.64.0606061625430.5498@g5.osdl.org>
URL: https://gitlist.dev/e/Pine.LNX.4.64.0606061625430.5498%40g5.osdl.org
In-Reply-To: <20060606231516.GA18405@localhost>

```


On Tue, 6 Jun 2006, Robert Fitzsimons wrote:
>
> Don't just read the --ignore-case/-i option, pass the flag on to the
> external grep program.

Oops. How did we miss that one ;)

Embarrassing.

		Linus

```