# [PATCH] strbuf: use valid pointer in strbuf_remove()

2 messages from 2016-09-13 to 2016-09-13. Participants: René Scharfe, Jeff King.
Thread: https://gitlist.dev/t/44073

## René Scharfe, 2016-09-13 16:40

Subject: [PATCH] strbuf: use valid pointer in strbuf_remove()
Message-ID: <408af1a3-6867-2ff5-c97f-3eb884412ad8@web.de>
URL: https://gitlist.dev/e/408af1a3-6867-2ff5-c97f-3eb884412ad8%40web.de

```
The fourth argument of strbuf_splice() is passed to memcpy(3), which is
not supposed to handle NULL pointers.  Let's be extra careful and use a
valid empty string instead.  It even shortens the source code. :)

Signed-off-by: Rene Scharfe <l.s.r@web.de>
---
 strbuf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/strbuf.c b/strbuf.c
index f3bd571..b839be4 100644
--- a/strbuf.c
+++ b/strbuf.c
@@ -187,7 +187,7 @@ void strbuf_insert(struct strbuf *sb, size_t pos, const void *data, size_t len)
 
 void strbuf_remove(struct strbuf *sb, size_t pos, size_t len)
 {
-	strbuf_splice(sb, pos, len, NULL, 0);
+	strbuf_splice(sb, pos, len, "", 0);
 }
 
 void strbuf_add(struct strbuf *sb, const void *data, size_t len)
-- 
2.10.0

```

## Jeff King, 2016-09-13 18:14

Subject: Re: [PATCH] strbuf: use valid pointer in strbuf_remove()
Message-ID: <20160913181420.ebsiscqk3sbc7axl@sigill.intra.peff.net>
URL: https://gitlist.dev/e/20160913181420.ebsiscqk3sbc7axl%40sigill.intra.peff.net
In-Reply-To: <408af1a3-6867-2ff5-c97f-3eb884412ad8@web.de>

```
On Tue, Sep 13, 2016 at 06:40:22PM +0200, René Scharfe wrote:

> The fourth argument of strbuf_splice() is passed to memcpy(3), which is
> not supposed to handle NULL pointers.  Let's be extra careful and use a
> valid empty string instead.  It even shortens the source code. :)

Heh. Looks obviously correct and like a good thing to do.

-Peff

```