threads / patch / 44028

patchsend-email: use sanitized address for cc

Subject: [PATCH] send-email: use sanitized address for cc

## tl;dr

One message between Sep 7, 2016 and Sep 7, 2016. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

changbin.du@gmail.com· Sep 7, 2016, 06:57 UTC · lore
From: "Du, Changbin" <changbin.du@gmail.com>

Some username in the email address may include a ','. In this case, we need quoting the username field so it will not be parsed as two single addresses by Mail::Address->parse().

For example, my eamil address "Du, Changbin <changbin.du@gmail.com>" can be parsed as two addresses "Du" and "Changbin <changbin.du@gmail.com>" if username is not quoted. ("Du, Changbin" is a legal format of signature in Chinese)

The sanitized address can be used because quote is added automactically.
Signed-off-by: Du, Changbin <changbin.du@gmail.com>
---
 git-send-email.perl | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Show changes to git-send-email.perl +2 −2
diff --git a/git-send-email.perl b/git-send-email.perl
index 6958785..6ec189e 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -1554,9 +1554,9 @@ foreach my $t (@files) {
 				next if $suppress_cc{'sob'} and $what =~ /Signed-off-by/i;
 				next if $suppress_cc{'bodycc'} and $what =~ /Cc/i;
 			}
-			push @cc, $c;
+			push @cc, $sc;
 			printf("(body) Adding cc: %s from line '%s'\n",
-				$c, $_) unless $quiet;
+				$sc, $_) unless $quiet;
 		}
 	}
 	close $fh;
-- 
2.7.4

← back to recent threads