threads / patch / 43915

patchdoc: mention `git -c` in git-config(1)

Subject: [PATCH] doc: mention `git -c` in git-config(1)

## tl;dr

5 messages between Aug 23, 2016 and Sep 12, 2016. Diffs are folded; open one to read it.

replies: 4people: 2as markdown or json

David Glasser· Aug 23, 2016, 17:33 UTC · lore

Signed-off-by: David Glasser <glasser@davidglasser.net>
---
 Documentation/git-config.txt | 3 +++
 1 file changed, 3 insertions(+)

Show changes to Documentation/git-config.txt +3 −0

diff --git a/Documentation/git-config.txt b/Documentation/git-config.txt
index f163113..83f86b9 100644
--- a/Documentation/git-config.txt
+++ b/Documentation/git-config.txt
@@ -263,6 +263,9 @@ The files are read in the order given above, with
last value found taking
 precedence over values read earlier.  When multiple values are taken then all
 values of a key from all files will be used.

+You may override individual configuration parameters when running any git
+command by using the `-c` option. See linkgit:git[1] for details.
+
 All writing options will per default write to the repository specific
 configuration file. Note that this also affects options like `--replace-all`
 and `--unset`. *'git config' will only ever change one file at a time*.

-- 
2.8.1

Junio C Hamano· Aug 23, 2016, 18:02 UTC · re: David Glasser · lore

Re: [PATCH] doc: mention `git -c` in git-config(1)

David Glasser <glasser@davidglasser.net> writes:

Show 11 quoted lines

> Signed-off-by: David Glasser <glasser@davidglasser.net>
> ---
>  Documentation/git-config.txt | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/git-config.txt b/Documentation/git-config.txt
> index f163113..83f86b9 100644
> --- a/Documentation/git-config.txt
> +++ b/Documentation/git-config.txt
> @@ -263,6 +263,9 @@ The files are read in the order given above, with
> last value found taking

No need to resend but the above context line somehow got line-wrapped.

Show 6 quoted lines

>  precedence over values read earlier.  When multiple values are taken then all
>  values of a key from all files will be used.
>
> +You may override individual configuration parameters when running any git
> +command by using the `-c` option. See linkgit:git[1] for details.
> +

This is not a new (as linkgit:git[1] also has it) but "override" is a white lie, and may invite nitpickers. The -c var=val given from the "git" command line is merely tacked at the end of the search order, so it would "override" when the variable is used as a single-valued variable, but when it is used as multi-valued one, it does not.

That might be something we want to fix up further in later patches; the change we see in this patch is good regardless.

Thanks.

>  All writing options will per default write to the repository specific
>  configuration file. Note that this also affects options like `--replace-all`
>  and `--unset`. *'git config' will only ever change one file at a time*.

David Glasser· Sep 12, 2016, 00:33 UTC · re: Junio C Hamano · lore

Re: [PATCH] doc: mention `git -c` in git-config(1)

On Tue, Aug 23, 2016 at 11:02 AM, Junio C Hamano <gitster@pobox.com> wrote:

> David Glasser <glasser@davidglasser.net> writes:
>
> That might be something we want to fix up further in later patches;
> the change we see in this patch is good regardless.

Perhaps I am looking at the wrong branch, but I'm not sure that this got merged? Is there something I should do to move this along?

--dave

-- 
glasser@davidglasser.net | langtonlabs.org | flickr.com/photos/glasser/

Junio C Hamano· Sep 12, 2016, 01:54 UTC · re: David Glasser · lore

Re: [PATCH] doc: mention `git -c` in git-config(1)

David Glasser <glasser@davidglasser.net> writes:

Show 9 quoted lines

> On Tue, Aug 23, 2016 at 11:02 AM, Junio C Hamano <gitster@pobox.com> wrote:
>> David Glasser <glasser@davidglasser.net> writes:
>>
>> That might be something we want to fix up further in later patches;
>> the change we see in this patch is good regardless.
>
>
> Perhaps I am looking at the wrong branch, but I'm not sure that this
> got merged? Is there something I should do to move this along?

Are you asking about "might be something we want to fix up further", which I do not think anybody did (and you certainly didn't)?

The patch that was commented on in that exchange should be part of v2.10.0 already.

$ git blame -s -L264,269 v2.10.0 Documentation/git-config.txt 7da9800f 264) values of a key from all files will be used. 7da9800f 265) ae1f7094 266) You may override individual configuration parameters when running any git ae1f7094 267) command by using the `-c` option. See linkgit:git[1] for details. ae1f7094 268) 17014090 269) All writing options will per default write to the repository specific

$ git show ae1f7094
commit ae1f7094f7a68fcff3d07358d83f5f483f0c300c
Author: David Glasser <glasser@davidglasser.net>
Date:   Tue Aug 23 10:33:21 2016 -0700

    doc: mention `git -c` in git-config(1)
    
    Signed-off-by: David Glasser <glasser@davidglasser.net>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>

Show changes to Documentation/git-config.txt +3 −0

diff --git a/Documentation/git-config.txt b/Documentation/git-config.txt
index 6843114..636b3eb 100644
--- a/Documentation/git-config.txt
+++ b/Documentation/git-config.txt
@@ -263,6 +263,9 @@ The files are read in the order given above, with last value found taking
 precedence over values read earlier.  When multiple values are taken then all
 values of a key from all files will be used.
 
+You may override individual configuration parameters when running any git
+command by using the `-c` option. See linkgit:git[1] for details.
+
 All writing options will per default write to the repository specific
 configuration file. Note that this also affects options like '--replace-all'
 and '--unset'. *'git config' will only ever change one file at a time*.

David Glasser· Sep 12, 2016, 02:19 UTC · re: Junio C Hamano · lore

Re: [PATCH] doc: mention `git -c` in git-config(1)

On Sun, Sep 11, 2016 at 6:54 PM, Junio C Hamano <gitster@pobox.com> wrote:

> The patch that was commented on in that exchange should be part of
> v2.10.0 already.

My mistake: I was accidentally searching for the paragraph I added in config.txt instead of git-config.txt. Thanks and sorry for wasting your time!

--dave

-- 
glasser@davidglasser.net | langtonlabs.org | flickr.com/photos/glasser/