[patch] cg help broken when $PAGER contains space

Eric Blake· Nov 26, 2006, 14:51 UTC · lore

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

With cogito 0.18.1, cg-help line 152 invokes "IFS=$'\n' colorize", which in turn invokes the "pager" shell function from cg-Xlib with IFS set to just a newline. This means that if PAGER contains any spaces, the expansion of ${PAGER:-less} within pager() will not be split, leading to the following less-than-useful help message:

$ echo $PAGER less -s $ cg help /usr/lib/cogito/cg-Xlib: line 193: less -s: command not found $ echo $? 127

This patch fixes the problem:

2006-11-26  Eric Blake  <ebb9@byu.net>

	* cg-help: Don't change IFS when invoking pager.

Show changes to cg-help +1 −3

diff --git a/cg-help b/cg-help
index c2d558f..f428767 100755
- --- a/cg-help
+++ b/cg-help
@@ -149,7 +149,7 @@ BRANCH_COMMANDS="$(ls "$bin_path"/cg-bra
 TAG_COMMANDS="$(ls "$bin_path"/cg-tag* | sed 's#.*/##' | tr '\n' ' ')"
 ADVANCED_COMMANDS="$(ls "$bin_path"/cg-admin-* | sed 's#.*/##' | tr '\n'
' ')"

- -IFS=$'\n' colorize <<__END__
+colorize <<__END__
 The Cogito version control system  $(cg-version)

 Available regular commands:

- --
Life is short - so eat dessert first!

Eric Blake             ebb9@byu.net
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFFaanr84KuGfSFAYARAmfSAKCZ15/oq3rwsPyB/XLNXpUWYzQRiACfeYcC
DFw8ldbHVYs0vZtjynI3/hU=
=rR/p

patchcg help broken when $PAGER contains space