# [PATCH 1/3] shortlog: do not crash on parsing "[PATCH" 1 messages from 2006-11-19 to 2006-11-19. Participants: Johannes Schindelin. Thread: https://gitlist.dev/t/43745 ## Johannes Schindelin, 2006-11-19 16:28 Subject: [PATCH 1/3] shortlog: do not crash on parsing "[PATCH" Message-ID: URL: https://gitlist.dev/e/Pine.LNX.4.63.0611191727560.13772%40wbgn013.biozentrum.uni-wuerzburg.de ``` Annoyingly, it looked for the closing bracket in the author name instead of in the message, and then accessed the NULL pointer. Signed-off-by: Johannes Schindelin --- builtin-shortlog.c | 16 +++++++++------- 1 files changed, 9 insertions(+), 7 deletions(-) diff --git a/builtin-shortlog.c b/builtin-shortlog.c index 48a2a0b..26212b0 100644 --- a/builtin-shortlog.c +++ b/builtin-shortlog.c @@ -108,13 +108,15 @@ static void insert_author_oneline(struct free(buffer); if (!strncmp(oneline, "[PATCH", 6)) { - char *eob = strchr(buffer, ']'); - - while (isspace(eob[1]) && eob[1] != '\n') - eob++; - if (eob - oneline < onelinelen) { - onelinelen -= eob - oneline; - oneline = eob; + char *eob = strchr(oneline, ']'); + + if (eob) { + while (isspace(eob[1]) && eob[1] != '\n') + eob++; + if (eob - oneline < onelinelen) { + onelinelen -= eob - oneline; + oneline = eob; + } } } -- 1.4.4.GIT ```