threads / patch / 43739

patchRe: [GIT PATCH] Makefile missing git-runstatus in PROGRAMS list

Subject: Re: [GIT PATCH] Makefile missing git-runstatus in PROGRAMS list

## tl;dr

2 messages between Nov 14, 2006 and Nov 14, 2006. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Bhavesh Davda· Nov 14, 2006, 20:55 UTC · lore

[GIT PATCH] Makefile missing git-runstatus in PROGRAMS list

Noticed this when trying to use qgit on Linus's kernel git repository. The script git-status depends on git-runstatus being in the path.

Adding git-runstatus to the PROGRAMS list in the Makefile, so that it gets installed along with the other git executables.

After a "sudo make install", qgit is now happy, since git-status is now able to find git-runstatus in /usr/bin.

Thanks
- Bhavesh
Bhavesh P. Davda
Show changes to Makefile +1 −1
diff --git a/Makefile b/Makefile
index 36ce8cd..24a0dc7 100644
--- a/Makefile
+++ b/Makefile
@@ -202,7 +202,7 @@ PROGRAMS = \
 	git-upload-pack$X git-verify-pack$X \
 	git-pack-redundant$X git-var$X \
 	git-describe$X git-merge-tree$X git-imap-send$X \
-	git-merge-recursive$X \
+	git-merge-recursive$X git-runstatus$X \
 	$(EXTRA_PROGRAMS)
 
 # Empty...
Junio C Hamano· Nov 14, 2006, 22:40 UTC · re: Bhavesh Davda · lore
"Bhavesh Davda" <bhavesh@vmware.com> writes:
Show 30 quoted lines
> Noticed this when trying to use qgit on Linus's kernel git repository. The
> script git-status depends on git-runstatus being in the path.
>
> Adding git-runstatus to the PROGRAMS list in the Makefile, so that it gets
> installed along with the other git executables.
>
> After a "sudo make install", qgit is now happy, since git-status is now able
> to find git-runstatus in /usr/bin.
>
> Thanks
>
> - Bhavesh
>
> Bhavesh P. Davda
>
>
>
> diff --git a/Makefile b/Makefile
> index 36ce8cd..24a0dc7 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -202,7 +202,7 @@ PROGRAMS = \
>  	git-upload-pack$X git-verify-pack$X \
>  	git-pack-redundant$X git-var$X \
>  	git-describe$X git-merge-tree$X git-imap-send$X \
> -	git-merge-recursive$X \
> +	git-merge-recursive$X git-runstatus$X \
>  	$(EXTRA_PROGRAMS)
>  
>  # Empty...

This cannot be right. There is builtin-runstatus.o defined as part of BUILTIN_OBJS so you already should have git-runstatus as a hardlink to other binaries such as git-add, git-apply etc. in the same directory as you have them.

I seem to have 55 hardlinks to that file under my ~/bin/.

← back to recent threads