threads / patch / 43717

patch, 5 partsfetch-pack: Properly remove the shallow file when it becomes empty.

Subject: [PATCH 1/5] fetch-pack: Properly remove the shallow file when it becomes empty.

## tl;dr

One message between Nov 24, 2006 and Nov 24, 2006. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Alexandre Julliard· Nov 24, 2006, 14:58 UTC · lore
The code was unlinking the lock file instead.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
---
 fetch-pack.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Show changes to fetch-pack.c +1 −1
diff --git a/fetch-pack.c b/fetch-pack.c
index d00573d..bb310b6 100644
--- a/fetch-pack.c
+++ b/fetch-pack.c
@@ -700,7 +700,7 @@ int main(int argc, char **argv)
 
 		fd = hold_lock_file_for_update(&lock, shallow, 1);
 		if (!write_shallow_commits(fd, 0)) {
-			unlink(lock.filename);
+			unlink(shallow);
 			rollback_lock_file(&lock);
 		} else {
 			close(fd);
-- 
1.4.4.1.ga335e

-- 
Alexandre Julliard

← back to recent threads