threads / patch / 43590

patchls-files: Give hints when errors happen.

Subject: [PATCH] ls-files: Give hints when errors happen.

## tl;dr

One message between Nov 30, 2006 and Nov 30, 2006. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Andreas Ericsson· Nov 30, 2006, 11:28 UTC · lore

Without this patch "git commit file.c file2.c" produces the not so stellar output:

	error: pathspec 'file.c' did not match any.
	error: pathspec 'file2.c' did not match any.
With this patch, the output is changed to:
	error: pathspec 'file.c' did not match any file(s) known to git.
	error: pathspec 'file2.c' did not match any file(s) known to git.
	Did you forget to 'git add'?
Signed-off-by: Andreas Ericsson <ae@op5.se>
---
 builtin-ls-files.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)
Show changes to builtin-ls-files.c +5 −1
diff --git a/builtin-ls-files.c b/builtin-ls-files.c
index ad8c41e..bc79ce4 100644
--- a/builtin-ls-files.c
+++ b/builtin-ls-files.c
@@ -487,10 +487,14 @@ int cmd_ls_files(int argc, const char **argv, const char *prefix)
 		for (num = 0; pathspec[num]; num++) {
 			if (ps_matched[num])
 				continue;
-			error("pathspec '%s' did not match any.",
+			error("pathspec '%s' did not match any file(s) known to git.",
 			      pathspec[num] + prefix_offset);
 			errors++;
 		}
+
+		if (errors)
+			fprintf(stderr, "Did you forget to 'git add'?\n");
+
 		return errors ? 1 : 0;
 	}
 
-- 
1.4.4.1.GIT

← back to recent threads