threads / patch / 43585

patchRe: [PATCH] no need to install manpages as executable

Subject: Re: [PATCH] no need to install manpages as executable

## tl;dr

2 messages between Dec 11, 2006 and Dec 12, 2006. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Chris Wright· Dec 11, 2006, 07:39 UTC · lore

[PATCH] no need to install manpages as executable

No need to install manpages as executable.  Noticed by Ville Skyttä.
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
---
Applies cleanly to maint and master.
 Documentation/Makefile |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Show changes to Documentation/Makefile +2 −2
diff --git a/Documentation/Makefile b/Documentation/Makefile
index c00f5f6..d68bc4a 100644
--- a/Documentation/Makefile
+++ b/Documentation/Makefile
@@ -56,8 +56,8 @@ man7: $(DOC_MAN7)
 
 install: man
 	$(INSTALL) -d -m755 $(DESTDIR)$(man1dir) $(DESTDIR)$(man7dir)
-	$(INSTALL) $(DOC_MAN1) $(DESTDIR)$(man1dir)
-	$(INSTALL) $(DOC_MAN7) $(DESTDIR)$(man7dir)
+	$(INSTALL) -m644 $(DOC_MAN1) $(DESTDIR)$(man1dir)
+	$(INSTALL) -m644 $(DOC_MAN7) $(DESTDIR)$(man7dir)
 
 
Junio C Hamano· Dec 12, 2006, 01:15 UTC · re: Chris Wright · lore
Chris Wright <chrisw@sous-sol.org> writes:
> No need to install manpages as executable.  Noticed by Ville Skyttä.

Thanks. I agree there is no need but I wonder why we even need to specify that explicitly. Well, I guess I did not know that install(1) was that stupid.

← back to recent threads