threads / patch / 4352

patchgit status: print files under untracked dir if -a is given

Subject: [PATCH] git status: print files under untracked dir if -a is given

## tl;dr

3 messages between May 30, 2006 and May 30, 2006. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Yasushi SHOJI· May 30, 2006, 08:46 UTC · lore

git status: print files under untracked dir if -a is given

git status (git-commit.sh) currently doesn't show files under untracked directory. this is inconvenient when adding many files under new directory.

this patch change its behavior to show files under untracked directory if option --all is given.

Signed-off-by: Yasushi SHOJI <yashi@atmark-techno.com>

---

3d3fa8f19c7d9b03b1a6e510970633ec8be7adac
 git-commit.sh |    9 +++++++--
 1 files changed, 7 insertions(+), 2 deletions(-)

3d3fa8f19c7d9b03b1a6e510970633ec8be7adac

Show changes to git-commit.sh +7 −2

diff --git a/git-commit.sh b/git-commit.sh
index 6ef1a9d..0cde305 100755
--- a/git-commit.sh
+++ b/git-commit.sh
@@ -134,13 +134,18 @@ #'
 	report "Changed but not updated" \
 	    "use git-update-index to mark for commit"
 
+	if test -z "$all"
+	then
+	    directory_opt="--directory"
+	fi
+
 	if test -f "$GIT_DIR/info/exclude"
 	then
-	    git-ls-files -z --others --directory \
+	    git-ls-files -z --others $directory_opt \
 		--exclude-from="$GIT_DIR/info/exclude" \
 		--exclude-per-directory=.gitignore
 	else
-	    git-ls-files -z --others --directory \
+	    git-ls-files -z --others $directory_opt \
 		--exclude-per-directory=.gitignore
 	fi |
 	perl -e '$/ = "\0";

-- 
1.3.3.g70f7

Junio C Hamano· May 30, 2006, 09:34 UTC · re: Yasushi SHOJI · lore

Re: [PATCH] git status: print files under untracked dir if -a is given

Yasushi SHOJI <yashi@atmark-techno.com> writes:

Show 10 quoted lines

> git status: print files under untracked dir if -a is given
>
> git status (git-commit.sh) currently doesn't show files under
> untracked directory.  this is inconvenient when adding many files
> under new directory.
>
> this patch change its behavior to show files under untracked directory
> if option --all is given.
>
> Signed-off-by: Yasushi SHOJI <yashi@atmark-techno.com>

I do not quite understand your rationale behind linking -a and "show untracked" behaviour. In many cases, after modifying multiple files "commit -a" is the preferred way to make commits for people who keep their tree clean (meaning, they do not leave unrelated changes to their working tree files), and I suspect your change would clutter their commit log buffer with unrelated files they did not ask to see.

At least this would make things somewhat unpleasant for me to use, since I do "commit -a" often and I have my random notes files under ./+trash subdirectory of the main project (yes, I know I could add /+trash to .gitignore).

We have something different but perhaps related by Matthias Lederhofer to add "git status --untracked" since you did this patch.

        commit 443f8338b9e248353a7095a1096684f1ed106c66
        Author: Matthias Lederhofer <matled@gmx.net>
        Date:   Mon May 22 23:02:06 2006 +0200

Does it solve your problem?

Yasushi SHOJI· May 30, 2006, 12:55 UTC · re: Junio C Hamano · lore

Re: [PATCH] git status: print files under untracked dir if -a is given

Hi Junio,

At Tue, 30 May 2006 02:34:55 -0700, Junio C Hamano wrote:

Show 21 quoted lines

> 
> Yasushi SHOJI <yashi@atmark-techno.com> writes:
> 
> > git status: print files under untracked dir if -a is given
> >
> > git status (git-commit.sh) currently doesn't show files under
> > untracked directory.  this is inconvenient when adding many files
> > under new directory.
> >
> > this patch change its behavior to show files under untracked directory
> > if option --all is given.
> >
> > Signed-off-by: Yasushi SHOJI <yashi@atmark-techno.com>
> 
> I do not quite understand your rationale behind linking -a and
> "show untracked" behaviour.  In many cases, after modifying
> multiple files "commit -a" is the preferred way to make commits
> for people who keep their tree clean (meaning, they do not leave
> unrelated changes to their working tree files), and I suspect
> your change would clutter their commit log buffer with unrelated
> files they did not ask to see.

I assumed "--all" to mean "every single file under a working dir except ignored". so I thought users of "commit -a" wouldn't mind to see files under untracked dir.

but I was wrong. man page clearly states that "... new files you have not told git about are not affected."

# I admit I haven't used -a with commit because of my # misunderstanding. it's nice to know the option is much safer than I # expected.

> At least this would make things somewhat unpleasant for me to
> use, since I do "commit -a" often and I have my random notes
> files under ./+trash subdirectory of the main project (yes, I
> know I could add /+trash to .gitignore).

I wasn't expecting that usage.

Show 9 quoted lines

> We have something different but perhaps related by Matthias
> Lederhofer to add "git status --untracked" since you did this
> patch.
> 
>         commit 443f8338b9e248353a7095a1096684f1ed106c66
>         Author: Matthias Lederhofer <matled@gmx.net>
>         Date:   Mon May 22 23:02:06 2006 +0200
> 
> Does it solve your problem?

yes, it perfectly does.

thanks,
--
       yashi