Re: [PATCH] Minor grammar fixes for git-diff-index.txt

Andy Parkins· Oct 25, 2006, 15:02 UTC · lore

From 9f5b5b3d4925ac5f22a64fd075c50417cff7b496 Mon Sep 17 00:00:00 2001
From: Andy Parkins <andyparkins@gmail.com>
Date: Wed, 25 Oct 2006 15:59:53 +0100
Subject: [PATCH] Minor grammar fixes for git-diff-index.txt
To: git@vger.kernel.org

"what you are going to commit is" doesn't need the "is" and does need a comma.

"can trivially see" is an unecessary split infinitive and "easily" is a more
appropriate adverb.
Signed-off-by: Andy Parkins <andyparkins@gmail.com>
---
This corrects the previous grammar patch - the original use of "where" was 
correct.  You know when you say a word enough and it loses all meaning...

 Documentation/git-diff-index.txt |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Show changes to Documentation/git-diff-index.txt +2 −2

diff --git a/Documentation/git-diff-index.txt 
b/Documentation/git-diff-index.txt
index 9cd43f1..2df581c 100644
--- a/Documentation/git-diff-index.txt
+++ b/Documentation/git-diff-index.txt
@@ -54,7 +54,7 @@ If '--cached' is specified, it allows yo
 
 For example, let's say that you have worked on your working directory, 
updated
 some files in the index and are ready to commit. You want to see exactly
-*what* you are going to commit is without having to write a new tree
+*what* you are going to commit, without having to write a new tree
 object and compare it that way, and to do that, you just do
 
 	git-diff-index --cached HEAD
@@ -68,7 +68,7 @@ matches my working directory. But doing 
   -100644 blob    4161aecc6700a2eb579e842af0b7f22b98443f74        commit.c
   +100644 blob    4161aecc6700a2eb579e842af0b7f22b98443f74        
git-commit.c
 
-You can trivially see that the above is a rename.
+You can see easily that the above is a rename.
 
 In fact, "git-diff-index --cached" *should* always be entirely equivalent to
 actually doing a "git-write-tree" and comparing that. Except this one is much

-- 
1.4.2.3

Junio C Hamano· Oct 25, 2006, 18:42 UTC · re: Andy Parkins · lore

Andy Parkins <andyparkins@gmail.com> writes:

Show 5 quoted lines

> From 9f5b5b3d4925ac5f22a64fd075c50417cff7b496 Mon Sep 17 00:00:00 2001
> From: Andy Parkins <andyparkins@gmail.com>
> Date: Wed, 25 Oct 2006 15:59:53 +0100
> Subject: [PATCH] Minor grammar fixes for git-diff-index.txt
> To: git@vger.kernel.org

We do not want these in-body.

Show 22 quoted lines

>
> "what you are going to commit is" doesn't need the "is" and does need a comma.
>
> "can trivially see" is an unecessary split infinitive and "easily" is a more
> appropriate adverb.
> Signed-off-by: Andy Parkins <andyparkins@gmail.com>
> ---
> This corrects the previous grammar patch - the original use of "where" was 
> correct.  You know when you say a word enough and it loses all meaning...
>
>  Documentation/git-diff-index.txt |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/git-diff-index.txt 
> b/Documentation/git-diff-index.txt
> index 9cd43f1..2df581c 100644
> --- a/Documentation/git-diff-index.txt
> +++ b/Documentation/git-diff-index.txt
> @@ -54,7 +54,7 @@ If '--cached' is specified, it allows yo
>  
>  For example, let's say that you have worked on your working directory, 
> updated

Please check who wrapped this line and correct it. Most likely your MUA.

patchRe: [PATCH] Minor grammar fixes for git-diff-index.txt