threads / patch / 43353

patch: Pass -M to diff in request-pull

Subject: [PATCH]: Pass -M to diff in request-pull

## tl;dr

4 messages between Dec 4, 2006 and Dec 4, 2006. Diffs are folded; open one to read it.

replies: 3people: 3as markdown or json

David Miller· Dec 4, 2006, 07:17 UTC · lore

Linus recommended this, otherwise any renames cause the diffstate output to be rediculious in some circumstances :)

Signed-off-by: David S. Miller <davem@davemloft.net>

Show changes to git-request-pull.sh +0 −1

diff --git a/git-request-pull.sh b/git-request-pull.sh
index 4319e35..4eacc3a 100755
--- a/git-request-pull.sh
+++ b/git-request-pull.sh
@@ -30,4 +30,4 @@ echo "  $url"
 echo
 
 git log  $baserev..$headrev | git-shortlog ;
-git diff --stat --summary $baserev..$headrev

Junio C Hamano· Dec 4, 2006, 08:35 UTC · re: David Miller · lore

Re: [PATCH]: Pass -M to diff in request-pull

David Miller <davem@davemloft.net> writes:

> Linus recommended this, otherwise any renames cause the
> diffstate output to be rediculious in some circumstances :)

Thanks, but "rediculious"?

I think this makes sense, especially as it matches what we show after a git-pull that ought to match the request.

Linus Torvalds· Dec 4, 2006, 16:45 UTC · re: Junio C Hamano · lore

Re: [PATCH]: Pass -M to diff in request-pull

On Mon, 4 Dec 2006, Junio C Hamano wrote:

Show 6 quoted lines

> David Miller <davem@davemloft.net> writes:
> >
> > Linus recommended this, otherwise any renames cause the
> > diffstate output to be rediculious in some circumstances :)
> 
> Thanks, but "rediculious"?

Kernel dewalopers can't speel. We all knew that.

At least we don't do 1337-sp33k.

David Miller· Dec 4, 2006, 17:49 UTC · re: Linus Torvalds · lore

Re: [PATCH]: Pass -M to diff in request-pull

From: Linus Torvalds <torvalds@osdl.org>
Date: Mon, 4 Dec 2006 08:45:28 -0800 (PST)

Show 11 quoted lines

> On Mon, 4 Dec 2006, Junio C Hamano wrote:
> > David Miller <davem@davemloft.net> writes:
> > >
> > > Linus recommended this, otherwise any renames cause the
> > > diffstate output to be rediculious in some circumstances :)
> > 
> > Thanks, but "rediculious"?
> 
> Kernel dewalopers can't speel. We all knew that.
> 
> At least we don't do 1337-sp33k.