threads / discuss / 43294

Re: latest update to git-svn blows up for me

Subject: Re: latest update to git-svn blows up for me

## tl;dr

16 messages between Dec 4, 2006 and Dec 8, 2006.

replies: 15people: 3as markdown or json

Randal L. Schwartz· Dec 4, 2006, 04:00 UTC · lore

latest update to git-svn blows up for me

Does this ring a bell?
Fetching git-svn
        M       trunk/lib/Perl/Critic/Policy/TestingAndDebugging/MisplacedShebang.pm
        M       trunk/lib/Perl/Critic/Policy/TestingAndDebugging/ProhibitShebangWarningsArg.pm
        M       trunk/lib/Perl/Critic/Policy/TestingAndDebugging/RequirePortableShebang.pm
        M       trunk/compilers/past-pm/POST/Compiler.pir
        M       trunk/compilers/past-pm/PAST/Compiler.pir
        M       trunk/compilers/past-pm/PAST-pm.pir
        M       trunk/languages/perl6/src/quote.pir
        M       trunk/languages/perl6/src/classes/Str.pir
        M       trunk/languages/perl6/src/classes/Code.pir
        M       trunk/languages/perl6/src/classes/Num.pir
        M       trunk/languages/plumhead/t/selection.txt
        M       trunk/languages/plumhead/t/superglobals.t
        M       trunk/languages/plumhead/t/strings.t
        M       trunk/languages/tcl/runtime/builtin/clock.pir
no blob information
512 at /opt/git/bin/git-svn line 457
        main::fetch_lib() called at /opt/git/bin/git-svn line 328
        main::fetch() called at /opt/git/bin/git-svn line 973
        main::fetch_child_id('git-svn') called at /opt/git/bin/git-svn line 991
        main::rec_fetch('', '/Volumes/UFS/MIRROR/parrot-GITSVN/.git/svn') called at /opt/git/bin/git-svn line 747
        main::multi_fetch() called at /opt/git/bin/git-svn line 187
512 at /opt/git/bin/git-svn line 980
        main::fetch_child_id('git-svn') called at /opt/git/bin/git-svn line 991
        main::rec_fetch('', '/Volumes/UFS/MIRROR/parrot-GITSVN/.git/svn') called at /opt/git/bin/git-svn line 747
        main::multi_fetch() called at /opt/git/bin/git-svn line 187
-- 
Randal L. Schwartz - Stonehenge Consulting Services, Inc. - +1 503 777 0095
<merlyn@stonehenge.com> <URL:http://www.stonehenge.com/merlyn/>
Perl/Unix/security consulting, Technical writing, Comedy, etc. etc.
Eric Wong· Dec 4, 2006, 07:00 UTC · re: Randal L. Schwartz · lore
"Randal L. Schwartz" <merlyn@stonehenge.com> wrote:
> 
> Does this ring a bell?
Nope.
Show 26 quoted lines
> Fetching git-svn
>         M       trunk/lib/Perl/Critic/Policy/TestingAndDebugging/MisplacedShebang.pm
>         M       trunk/lib/Perl/Critic/Policy/TestingAndDebugging/ProhibitShebangWarningsArg.pm
>         M       trunk/lib/Perl/Critic/Policy/TestingAndDebugging/RequirePortableShebang.pm
>         M       trunk/compilers/past-pm/POST/Compiler.pir
>         M       trunk/compilers/past-pm/PAST/Compiler.pir
>         M       trunk/compilers/past-pm/PAST-pm.pir
>         M       trunk/languages/perl6/src/quote.pir
>         M       trunk/languages/perl6/src/classes/Str.pir
>         M       trunk/languages/perl6/src/classes/Code.pir
>         M       trunk/languages/perl6/src/classes/Num.pir
>         M       trunk/languages/plumhead/t/selection.txt
>         M       trunk/languages/plumhead/t/superglobals.t
>         M       trunk/languages/plumhead/t/strings.t
>         M       trunk/languages/tcl/runtime/builtin/clock.pir
> no blob information
> 512 at /opt/git/bin/git-svn line 457
>         main::fetch_lib() called at /opt/git/bin/git-svn line 328
>         main::fetch() called at /opt/git/bin/git-svn line 973
>         main::fetch_child_id('git-svn') called at /opt/git/bin/git-svn line 991
>         main::rec_fetch('', '/Volumes/UFS/MIRROR/parrot-GITSVN/.git/svn') called at /opt/git/bin/git-svn line 747
>         main::multi_fetch() called at /opt/git/bin/git-svn line 187
> 512 at /opt/git/bin/git-svn line 980
>         main::fetch_child_id('git-svn') called at /opt/git/bin/git-svn line 991
>         main::rec_fetch('', '/Volumes/UFS/MIRROR/parrot-GITSVN/.git/svn') called at /opt/git/bin/git-svn line 747
>         main::multi_fetch() called at /opt/git/bin/git-svn line 187

This is on r15941 of https://svn.perl.org/parrot/trunk ? I can't seem to reproduce this with git svn fetch -r15940:15941

Randal L. Schwartz· Dec 4, 2006, 11:41 UTC · re: Eric Wong · lore
>>>>> "Eric" == Eric Wong <normalperson@yhbt.net> writes:
Eric> "Randal L. Schwartz" <merlyn@stonehenge.com> wrote:
>> 
>> Does this ring a bell?
Eric> Nope.

Eric> This is on r15941 of https://svn.perl.org/parrot/trunk ? I can't seem Eric> to reproduce this with git svn fetch -r15940:15941

No, and that worked for me as well. Apparently, I might have corrupted my metadata because I updated git-svn while I was using it. Is there any way to reset the metadata without having to re-fetch 15000 revisions?

-- 
Randal L. Schwartz - Stonehenge Consulting Services, Inc. - +1 503 777 0095
<merlyn@stonehenge.com> <URL:http://www.stonehenge.com/merlyn/>
Perl/Unix/security consulting, Technical writing, Comedy, etc. etc.
Eric Wong· Dec 4, 2006, 18:12 UTC · re: Randal L. Schwartz · lore
"Randal L. Schwartz" <merlyn@stonehenge.com> wrote:
Show 14 quoted lines
> >>>>> "Eric" == Eric Wong <normalperson@yhbt.net> writes:
> 
> Eric> "Randal L. Schwartz" <merlyn@stonehenge.com> wrote:
> >> 
> >> Does this ring a bell?
> 
> Eric> Nope.
> 
> Eric> This is on r15941 of  https://svn.perl.org/parrot/trunk ?  I can't seem
> Eric> to reproduce this with git svn fetch -r15940:15941
> 
> No, and that worked for me as well.  Apparently, I might have corrupted my
> metadata because I updated git-svn while I was using it.  Is there any way to
> reset the metadata without having to re-fetch 15000 revisions?

rm .git/refs/remotes/$GIT_SVN_ID .git/svn/$GIT_SVN_ID/.rev_db git svn -i $GIT_SVN_ID rebuild

I don't think that updating git-svn while using it is a problem, because Perl won't (to my knowledge) reread it after it's loaded, and git-svn does not re-exec itself (it'll fork, however). Weird... the change (15941) was a property-only change; however.

Randal L. Schwartz· Dec 4, 2006, 19:36 UTC · re: Eric Wong · lore
>>>>> "Eric" == Eric Wong <normalperson@yhbt.net> writes:
Eric> "Randal L. Schwartz" <merlyn@stonehenge.com> wrote:
>> >>>>> "Eric" == Eric Wong <normalperson@yhbt.net> writes:
>> 
Eric> "Randal L. Schwartz" <merlyn@stonehenge.com> wrote:
>> >> 
>> >> Does this ring a bell?
>> 
Eric> Nope.
>> 

Eric> This is on r15941 of https://svn.perl.org/parrot/trunk ? I can't seem Eric> to reproduce this with git svn fetch -r15940:15941

>> 
>> No, and that worked for me as well.  Apparently, I might have corrupted my
>> metadata because I updated git-svn while I was using it.  Is there any way to
>> reset the metadata without having to re-fetch 15000 revisions?

Eric> rm .git/refs/remotes/$GIT_SVN_ID .git/svn/$GIT_SVN_ID/.rev_db Eric> git svn -i $GIT_SVN_ID rebuild

That's not working:
localhost.local:..RROR/parrot-GITSVN % git-svn -i git-svn rebuild
fatal: 'origin': unable to chdir or not a git archive
fatal: unexpected EOF
Failed to find remote refs
256 at /opt/git/bin/git-svn line 2151
        main::safe_qx('git-ls-remote', 'origin', 'refs/remotes/git-svn') called at /opt/git/bin/git-svn line 3404
        main::copy_remote_ref() called at /opt/git/bin/git-svn line 226
        main::rebuild() called at /opt/git/bin/git-svn line 187
-- 
Randal L. Schwartz - Stonehenge Consulting Services, Inc. - +1 503 777 0095
<merlyn@stonehenge.com> <URL:http://www.stonehenge.com/merlyn/>
Perl/Unix/security consulting, Technical writing, Comedy, etc. etc.
Eric Wong· Dec 4, 2006, 19:54 UTC · re: Randal L. Schwartz · lore
"Randal L. Schwartz" <merlyn@stonehenge.com> wrote:
Show 31 quoted lines
> >>>>> "Eric" == Eric Wong <normalperson@yhbt.net> writes:
> 
> Eric> "Randal L. Schwartz" <merlyn@stonehenge.com> wrote:
> >> >>>>> "Eric" == Eric Wong <normalperson@yhbt.net> writes:
> >> 
> Eric> "Randal L. Schwartz" <merlyn@stonehenge.com> wrote:
> >> >> 
> >> >> Does this ring a bell?
> >> 
> Eric> Nope.
> >> 
> Eric> This is on r15941 of  https://svn.perl.org/parrot/trunk ?  I can't seem
> Eric> to reproduce this with git svn fetch -r15940:15941
> >> 
> >> No, and that worked for me as well.  Apparently, I might have corrupted my
> >> metadata because I updated git-svn while I was using it.  Is there any way to
> >> reset the metadata without having to re-fetch 15000 revisions?
> 
> Eric> rm .git/refs/remotes/$GIT_SVN_ID .git/svn/$GIT_SVN_ID/.rev_db
> Eric> git svn -i $GIT_SVN_ID rebuild
> 
> That's not working:
> 
> localhost.local:..RROR/parrot-GITSVN % git-svn -i git-svn rebuild
> fatal: 'origin': unable to chdir or not a git archive
> fatal: unexpected EOF
> Failed to find remote refs
> 256 at /opt/git/bin/git-svn line 2151
>         main::safe_qx('git-ls-remote', 'origin', 'refs/remotes/git-svn') called at /opt/git/bin/git-svn line 3404
>         main::copy_remote_ref() called at /opt/git/bin/git-svn line 226
>         main::rebuild() called at /opt/git/bin/git-svn line 187
Can you try:
git update-ref refs/remotes/git-svn \
  <last commit successfully imported from git-svn>
and running rebuild again?
Randal L. Schwartz· Dec 4, 2006, 20:04 UTC · re: Eric Wong · lore
>>>>> "Eric" == Eric Wong <normalperson@yhbt.net> writes:
Eric> Can you try:

Eric> git update-ref refs/remotes/git-svn \ Eric> <last commit successfully imported from git-svn>

Eric> and running rebuild again?
Yes, and now after seeing 14000 lines scroll by, I tried again:
localhost.local:..RROR/parrot-GITSVN % git-svn multi-fetch                     
Fetching git-svn
        M       trunk/lib/Perl/Critic/Policy/TestingAndDebugging/MisplacedShebang.pm
        M       trunk/lib/Perl/Critic/Policy/TestingAndDebugging/ProhibitShebangWarningsArg.pm
        M       trunk/lib/Perl/Critic/Policy/TestingAndDebugging/RequirePortableShebang.pm
        M       trunk/compilers/past-pm/POST/Compiler.pir
        M       trunk/compilers/past-pm/PAST/Compiler.pir
        M       trunk/compilers/past-pm/PAST-pm.pir
        M       trunk/languages/perl6/src/quote.pir
        M       trunk/languages/perl6/src/classes/Str.pir
        M       trunk/languages/perl6/src/classes/Code.pir
        M       trunk/languages/perl6/src/classes/Num.pir
        M       trunk/languages/plumhead/t/selection.txt
        M       trunk/languages/plumhead/t/superglobals.t
        M       trunk/languages/plumhead/t/strings.t
        M       trunk/languages/tcl/runtime/builtin/clock.pir
no blob information
512 at /opt/git/bin/git-svn line 457
        main::fetch_lib() called at /opt/git/bin/git-svn line 328
        main::fetch() called at /opt/git/bin/git-svn line 973
        main::fetch_child_id('git-svn') called at /opt/git/bin/git-svn line 991
        main::rec_fetch('', '/Volumes/UFS/MIRROR/parrot-GITSVN/.git/svn') called at /opt/git/bin/git-svn line 747
        main::multi_fetch() called at /opt/git/bin/git-svn line 187
512 at /opt/git/bin/git-svn line 980
        main::fetch_child_id('git-svn') called at /opt/git/bin/git-svn line 991
        main::rec_fetch('', '/Volumes/UFS/MIRROR/parrot-GITSVN/.git/svn') called at /opt/git/bin/git-svn line 747
        main::multi_fetch() called at /opt/git/bin/git-svn line 187

Anything you want me to try now? I'm not in a fast net place (at least not for a week), so I can't rebuild from scratch.

-- 
Randal L. Schwartz - Stonehenge Consulting Services, Inc. - +1 503 777 0095
<merlyn@stonehenge.com> <URL:http://www.stonehenge.com/merlyn/>
Perl/Unix/security consulting, Technical writing, Comedy, etc. etc.
Eric Wong· Dec 4, 2006, 20:08 UTC · re: Randal L. Schwartz · lore
"Randal L. Schwartz" <merlyn@stonehenge.com> wrote:
Show 10 quoted lines
> >>>>> "Eric" == Eric Wong <normalperson@yhbt.net> writes:
> 
> Eric> Can you try:
> 
> Eric> git update-ref refs/remotes/git-svn \
> Eric>   <last commit successfully imported from git-svn>
> 
> Eric> and running rebuild again?
> 
> Yes, and now after seeing 14000 lines scroll by, I tried again:
<snip>
> Anything you want me to try now?  I'm not in a fast net place (at
> least not for a week), so I can't rebuild from scratch.

Which version of the SVN libraries are you using? Also, are you tracking https://svn.perl.org/parrot/trunk or just https://svn.perl.org/parrot (top-level)

Randal L. Schwartz· Dec 4, 2006, 20:10 UTC · re: Eric Wong · lore
>>>>> "Eric" == Eric Wong <normalperson@yhbt.net> writes:
Eric> "Randal L. Schwartz" <merlyn@stonehenge.com> wrote:
>> >>>>> "Eric" == Eric Wong <normalperson@yhbt.net> writes:
>> 
Eric> Can you try:
>> 

Eric> git update-ref refs/remotes/git-svn \ Eric> <last commit successfully imported from git-svn>

>> 
Eric> and running rebuild again?
>> 
>> Yes, and now after seeing 14000 lines scroll by, I tried again:
Eric> <snip>
>> Anything you want me to try now?  I'm not in a fast net place (at
>> least not for a week), so I can't rebuild from scratch.
Eric> Which version of the SVN libraries are you using?
SVN::Core is 1.4.2  - not sure what distro that comes from.

Eric> Also, are you Eric> tracking https://svn.perl.org/parrot/trunk or just Eric> https://svn.perl.org/parrot (top-level)

http://svn.perl.org/parrot
-- 
Randal L. Schwartz - Stonehenge Consulting Services, Inc. - +1 503 777 0095
<merlyn@stonehenge.com> <URL:http://www.stonehenge.com/merlyn/>
Perl/Unix/security consulting, Technical writing, Comedy, etc. etc.
Eric Wong· Dec 4, 2006, 20:51 UTC · re: Randal L. Schwartz · lore
"Randal L. Schwartz" <merlyn@stonehenge.com> wrote:
Show 22 quoted lines
> >>>>> "Eric" == Eric Wong <normalperson@yhbt.net> writes:
> 
> Eric> "Randal L. Schwartz" <merlyn@stonehenge.com> wrote:
> >> >>>>> "Eric" == Eric Wong <normalperson@yhbt.net> writes:
> >> 
> Eric> Can you try:
> >> 
> Eric> git update-ref refs/remotes/git-svn \
> Eric> <last commit successfully imported from git-svn>
> >> 
> Eric> and running rebuild again?
> >> 
> >> Yes, and now after seeing 14000 lines scroll by, I tried again:
> 
> Eric> <snip>
> 
> >> Anything you want me to try now?  I'm not in a fast net place (at
> >> least not for a week), so I can't rebuild from scratch.
> 
> Eric> Which version of the SVN libraries are you using?
> 
> SVN::Core is 1.4.2  - not sure what distro that comes from.

Same here.. I'm still waiting for it to fetch and will try to reproduce it here.

Meanwhile, can you re-run and use Data::Dumper to dump out $fb right before it dies with "no blob information"? (in close_file() of SVN::Git::Fetcher).

Also, can you put some trace messages and dump arguments to add_file() and open_file() in that package, too?

Thanks.
Eric Wong· Dec 5, 2006, 04:08 UTC · re: Eric Wong · lore
Eric Wong <normalperson@yhbt.net> wrote:
> Same here..  I'm still waiting for it to fetch and will try to reproduce
> it here.
Update: Nearly 16k revisions later and I still can't reproduce this on
my computer.
Randal L. Schwartz· Dec 5, 2006, 04:19 UTC · re: Eric Wong · lore
>>>>> "Eric" == Eric Wong <normalperson@yhbt.net> writes:
Eric> Eric Wong <normalperson@yhbt.net> wrote:
>> Same here..  I'm still waiting for it to fetch and will try to reproduce
>> it here.

Eric> Update: Nearly 16k revisions later and I still can't reproduce this on Eric> my computer.

I still say it was odd that it happened exactly when I did a git-svn update in the other window. :)

So, maybe I'll just toss this archive. Oh wait, can I back it up a few dozen revs and try to roll forward? That might be interesting.

git-reset --hard HEAD~10 blow away everything you had me blow away last time make git-svn equal to HEAD git-svn rebuild git-svn fetch

Lemme try that.
-- 
Randal L. Schwartz - Stonehenge Consulting Services, Inc. - +1 503 777 0095
<merlyn@stonehenge.com> <URL:http://www.stonehenge.com/merlyn/>
Perl/Unix/security consulting, Technical writing, Comedy, etc. etc.
Randal L. Schwartz· Dec 5, 2006, 04:33 UTC · re: Randal L. Schwartz · lore
>>>>> "Randal" == Randal L Schwartz <merlyn@stonehenge.com> writes:
>>>>> "Eric" == Eric Wong <normalperson@yhbt.net> writes:
Eric> Eric Wong <normalperson@yhbt.net> wrote:
>>> Same here..  I'm still waiting for it to fetch and will try to reproduce
>>> it here.

Eric> Update: Nearly 16k revisions later and I still can't reproduce this on Eric> my computer.

Randal> I still say it was odd that it happened exactly when I did a git-svn Randal> update in the other window. :)

Randal> So, maybe I'll just toss this archive. Oh wait, can I back it up a few dozen Randal> revs and try to roll forward? That might be interesting.

Randal> git-reset --hard HEAD~10 Randal> blow away everything you had me blow away last time Randal> make git-svn equal to HEAD Randal> git-svn rebuild Randal> git-svn fetch

Randal> Lemme try that.

Nope. I reset it back 20 revs, and it correctly fast forwarded until the fatal item again:

            M       trunk/languages/plumhead/past_xml_to_past_pir.xsl
            M       trunk/languages/plumhead/t/hello.t
            A       trunk/languages/plumhead/t/strings.t
            M       trunk/languages/plumhead/t/arithmetics.t
            M       trunk/languages/plumhead/TODO
            M       trunk/languages/plumhead/phc_xml_to_past_xml.xsl
    r15936 = 1933fe5f95d4ff29d9bb086faca9059a765b7abb
            M       trunk/MANIFEST
            M       trunk/MANIFEST.SKIP
    r15937 = 17624a0457339d4eeeecc03632d609b6220ac02d
            M       trunk/languages/plumhead/phc_xml_to_past_xml.xsl
    r15938 = bc577df90b886d8afd89774231cd321a40fd06ed
            M       trunk/languages/tcl/runtime/builtin/string.pir
    r15939 = dddd42d84b38cb5ab9cc8ca377767459f3966a60
            M       trunk/languages/tcl/runtime/builtin/binary.pir
    r15940 = 5cd630a9b67948eb788cb4fdb87998d960977a75
            M       trunk/lib/Perl/Critic/Policy/TestingAndDebugging/MisplacedShebang.pm
            M       trunk/lib/Perl/Critic/Policy/TestingAndDebugging/ProhibitShebangWarningsArg.pm
            M       trunk/lib/Perl/Critic/Policy/TestingAndDebugging/RequirePortableShebang.pm
            M       trunk/compilers/past-pm/POST/Compiler.pir
            M       trunk/compilers/past-pm/PAST/Compiler.pir
            M       trunk/compilers/past-pm/PAST-pm.pir
            M       trunk/languages/perl6/src/quote.pir
            M       trunk/languages/perl6/src/classes/Str.pir
            M       trunk/languages/perl6/src/classes/Code.pir
            M       trunk/languages/perl6/src/classes/Num.pir
            M       trunk/languages/plumhead/t/selection.txt
            M       trunk/languages/plumhead/t/superglobals.t
            M       trunk/languages/plumhead/t/strings.t
            M       trunk/languages/tcl/runtime/builtin/clock.pir
    no blob information
    512 at /opt/git/bin/git-svn line 457
            main::fetch_lib() called at /opt/git/bin/git-svn line 328
            main::fetch() called at /opt/git/bin/git-svn line 973
            main::fetch_child_id('git-svn') called at /opt/git/bin/git-svn line 991
            main::rec_fetch('', '/Volumes/UFS/MIRROR/parrot-GITSVN/.git/svn') called at /opt/git/bin/git-svn line 747
            main::multi_fetch() called at /opt/git/bin/git-svn line 187
    512 at /opt/git/bin/git-svn line 980
            main::fetch_child_id('git-svn') called at /opt/git/bin/git-svn line 991
            main::rec_fetch('', '/Volumes/UFS/MIRROR/parrot-GITSVN/.git/svn') called at /opt/git/bin/git-svn line 747
            main::multi_fetch() called at /opt/git/bin/git-svn line 187
It just hates me, perhaps.
-- 
Randal L. Schwartz - Stonehenge Consulting Services, Inc. - +1 503 777 0095
<merlyn@stonehenge.com> <URL:http://www.stonehenge.com/merlyn/>
Perl/Unix/security consulting, Technical writing, Comedy, etc. etc.
Linus Torvalds· Dec 5, 2006, 16:47 UTC · re: Randal L. Schwartz · lore
On Mon, 4 Dec 2006, Randal L. Schwartz wrote:
> 
> It just hates me, perhaps.
This may be a great moment in time.

We may have reached the point where git is sentient, and passed the Turing test without us even realizing.

Please, somebody tell Sarah Connor.
Eric Wong· Dec 8, 2006, 09:55 UTC · re: Eric Wong · lore

[PATCH] git-svn: extra error check to ensure we open a file correctly

This may be an issue with repositories imported with commit 27a1a8014b842c0d70fdc91c68dd361ca2dfb34c or later, but before commit dad73c0bb9f33323ec1aacf560a6263f1d85f81a.

Signed-off-by: Eric Wong <normalperson@yhbt.net>
---
Eric Wong <normalperson@yhbt.net> wrote:
Show 15 quoted lines
> "Randal L. Schwartz" <merlyn@stonehenge.com> wrote:
> > >>>>> "Eric" == Eric Wong <normalperson@yhbt.net> writes:
> > 
> > Eric> "Randal L. Schwartz" <merlyn@stonehenge.com> wrote:
> > >> 
> > >> Does this ring a bell?
> > 
> > Eric> Nope.
> > 
> > Eric> This is on r15941 of  https://svn.perl.org/parrot/trunk ?  I can't seem
> > Eric> to reproduce this with git svn fetch -r15940:15941
> > 
> > No, and that worked for me as well.  Apparently, I might have corrupted my
> > metadata because I updated git-svn while I was using it.  Is there any way to
> > reset the metadata without having to re-fetch 15000 revisions?

I fear I may have been looking in the wrong place while trying to diagnose merlyn's problem. He did mention he was on a flaky connection and that may have caused the corruption if he had one of those bad versions.

 git-svn.perl |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/git-svn.perl b/git-svn.perl
index 747daf0..ff61b92 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -3438,6 +3438,9 @@ sub open_file {
 	my ($self, $path, $pb, $rev) = @_;
 	my ($mode, $blob) = (safe_qx('git-ls-tree',$self->{c},'--',$path)
 	                     =~ /^(\d{6}) blob ([a-f\d]{40})\t/);
+	unless (defined $mode && defined $blob) {
+		die "$path was not found in commit $self->{c} (r$rev)\n";
+	}
 	{ path => $path, mode_a => $mode, mode_b => $mode, blob => $blob,
 	  pool => SVN::Pool->new, action => 'M' };
 }
-- 
1.4.4.1.g9c35e-dirty

← back to recent threads