Re: git-cvsimport feature request

Nguyen Thai Ngoc Duy· Dec 12, 2006, 12:42 UTC · lore

git-cvsimport feature request

Johannes Schindelin· Dec 12, 2006, 22:05 UTC · lore

Hi,

[readding list...]

On Wed, 13 Dec 2006, Nguyen Thai Ngoc Duy wrote:

> Hi,
> 
> On 12/12/06, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> > It could be done easily, but it is almost as easy to edit the command line
> > to substitute "git " with "git repo-config alias.cvsup '" (note the
> > single apostrophe at the end) and append and apostrophe at the end of the
> > line.
> 
> Thanks. I know that (and am doing that). Just think that it may be
> more convenient typing the command once.

Something like this?

Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>

---

 git-cvsimport.perl |   13 +++++++++++++
 1 files changed, 13 insertions(+), 0 deletions(-)

diff --git a/git-cvsimport.perl b/git-cvsimport.perl
index c5bf2d1..48fd55b 100755
--- a/git-cvsimport.perl
+++ b/git-cvsimport.perl
@@ -85,6 +85,12 @@ sub write_author_info($) {
 	close ($f);
 }
 
+my $alias = "cvsimport";
+foreach my $arg (@ARGV) {
+	$arg =~ s/[ \"]/\\&/g;
+	$alias .= ' ' . $arg;
+}
+
 getopts("hivmkuo:d:p:C:z:s:M:P:A:S:L:") or usage();
 usage if $opt_h;
 
@@ -946,6 +952,9 @@ if (defined $orig_git_index) {
 if ($orig_branch) {
 	print "DONE.\n" if $opt_v;
 	if ($opt_i) {
+		# uncomment this line, if the alias "cvsup" should be
+		# created/updated even with -i
+		#system("git-repo-config", "alias.cvsup", $alias);
 		exit 0;
 	}
 	my $tip_at_end = `git-rev-parse --verify HEAD`;
@@ -971,3 +980,7 @@ if ($orig_branch) {
 		die "checkout failed: $?\n" if $?;
 	}
 }
+
+# so far, so good. store it as alias cvsup
+system("git-repo-config", "alias.cvsup", $alias);