# Re: gitk with arguments fails on OSX 5 messages from 2006-11-29 to 2006-11-29. Participants: Junio C Hamano, Johannes Schindelin, Paul Mackerras, Randal L. Schwartz. Thread: https://gitlist.dev/t/43148 ## Randal L. Schwartz, 2006-11-29 15:04 Subject: gitk with arguments fails on OSX Message-ID: <864psixpj6.fsf@blue.stonehenge.com> URL: https://gitlist.dev/e/864psixpj6.fsf%40blue.stonehenge.com ``` Using the native "wish", gitk fails on OSX 10.4 if given any arguments. For example, the failure for "gitk --all" is: localhost.local:~/MIRROR/git-GIT % gitk --all Error in startup script: unknown option "-state" while executing ".bar.view entryconf 3 -state normal" invoked from within "if {$cmdline_files ne {} || $revtreeargs ne {}} { # create a view for the files/dirs specified on the command line set curview 1 set selec..." (file "/opt/git/bin/gitk" line 6298) What is -state ? What version of tk does it require? -- Randal L. Schwartz - Stonehenge Consulting Services, Inc. - +1 503 777 0095 Perl/Unix/security consulting, Technical writing, Comedy, etc. etc. ``` ## Johannes Schindelin, 2006-11-29 15:10 Subject: Re: gitk with arguments fails on OSX Message-ID: URL: https://gitlist.dev/e/Pine.LNX.4.63.0611291609370.30004%40wbgn013.biozentrum.uni-wuerzburg.de In-Reply-To: <864psixpj6.fsf@blue.stonehenge.com> ``` Hi, On Wed, 29 Nov 2006, Randal L. Schwartz wrote: > > Using the native "wish", gitk fails on OSX 10.4 if given any arguments. > For example, the failure for "gitk --all" is: > > localhost.local:~/MIRROR/git-GIT % gitk --all > Error in startup script: unknown option "-state" > while executing Known problem: http://thread.gmane.org/gmane.comp.version-control.git/31266/focus=31266 Hth, Dscho ``` ## Randal L. Schwartz, 2006-11-29 15:28 Subject: Re: gitk with arguments fails on OSX Message-ID: <86vekyw9ue.fsf@blue.stonehenge.com> URL: https://gitlist.dev/e/86vekyw9ue.fsf%40blue.stonehenge.com In-Reply-To: ``` >>>>> "Johannes" == Johannes Schindelin writes: Johannes> Hi, Johannes> On Wed, 29 Nov 2006, Randal L. Schwartz wrote: >> >> Using the native "wish", gitk fails on OSX 10.4 if given any arguments. >> For example, the failure for "gitk --all" is: >> >> localhost.local:~/MIRROR/git-GIT % gitk --all >> Error in startup script: unknown option "-state" >> while executing Johannes> Known problem: Johannes> http://thread.gmane.org/gmane.comp.version-control.git/31266/focus=31266 The fix works for me. How about mainlining it? From: Randal L. Schwartz Date: Wed, 29 Nov 2006 07:20:04 -0800 Subject: [PATCH] patch from mailing list --- gitk | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/gitk b/gitk index ab383b3..d9df0a3 100755 --- a/gitk +++ b/gitk @@ -1632,8 +1632,8 @@ proc showview {n} { set curview $n set selectedview $n - .bar.view entryconf 2 -state [expr {$n == 0? "disabled": "normal"}] - .bar.view entryconf 3 -state [expr {$n == 0? "disabled": "normal"}] + .bar.view entryconf "Edit*" -state [expr {$n == 0? "disabled": "normal"}] + .bar.view entryconf "Delete*" -state [expr {$n == 0? "disabled": "normal"}] if {![info exists viewdata($n)]} { set pending_select $selid @@ -6305,8 +6305,8 @@ if {$cmdline_files ne {} || $revtreeargs ne {}} { set viewargs(1) $revtreeargs set viewperm(1) 0 addviewmenu 1 - .bar.view entryconf 2 -state normal - .bar.view entryconf 3 -state normal + .bar.view entryconf "Edit*" -state normal + .bar.view entryconf "Delete*" -state normal } if {[info exists permviews]} { -- 1.4.4.1.gf927 -- Randal L. Schwartz - Stonehenge Consulting Services, Inc. - +1 503 777 0095 Perl/Unix/security consulting, Technical writing, Comedy, etc. etc. ``` ## Junio C Hamano, 2006-11-29 20:48 Subject: Re: gitk with arguments fails on OSX Message-ID: <7vejrmou75.fsf@assigned-by-dhcp.cox.net> URL: https://gitlist.dev/e/7vejrmou75.fsf%40assigned-by-dhcp.cox.net In-Reply-To: <86vekyw9ue.fsf@blue.stonehenge.com> ``` merlyn@stonehenge.com (Randal L. Schwartz) writes: >>>>>> "Johannes" == Johannes Schindelin writes: > > Johannes> Hi, > Johannes> On Wed, 29 Nov 2006, Randal L. Schwartz wrote: > >>> >>> Using the native "wish", gitk fails on OSX 10.4 if given any arguments. >>> For example, the failure for "gitk --all" is: >>> >>> localhost.local:~/MIRROR/git-GIT % gitk --all >>> Error in startup script: unknown option "-state" >>> while executing > > Johannes> Known problem: > > Johannes> http://thread.gmane.org/gmane.comp.version-control.git/31266/focus=31266 > > The fix works for me. How about mainlining it? The changes look sane to me. Paul? I prefer to be fed gitk changes through you, if you don't mind. > From: Randal L. Schwartz > Date: Wed, 29 Nov 2006 07:20:04 -0800 > Subject: [PATCH] patch from mailing list > > --- > gitk | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/gitk b/gitk > index ab383b3..d9df0a3 100755 > --- a/gitk > +++ b/gitk > @@ -1632,8 +1632,8 @@ proc showview {n} { > > set curview $n > set selectedview $n > - .bar.view entryconf 2 -state [expr {$n == 0? "disabled": "normal"}] > - .bar.view entryconf 3 -state [expr {$n == 0? "disabled": "normal"}] > + .bar.view entryconf "Edit*" -state [expr {$n == 0? "disabled": "normal"}] > + .bar.view entryconf "Delete*" -state [expr {$n == 0? "disabled": "normal"}] > > if {![info exists viewdata($n)]} { > set pending_select $selid > @@ -6305,8 +6305,8 @@ if {$cmdline_files ne {} || $revtreeargs ne {}} { > set viewargs(1) $revtreeargs > set viewperm(1) 0 > addviewmenu 1 > - .bar.view entryconf 2 -state normal > - .bar.view entryconf 3 -state normal > + .bar.view entryconf "Edit*" -state normal > + .bar.view entryconf "Delete*" -state normal > } > > if {[info exists permviews]} { > -- > 1.4.4.1.gf927 > > > > -- > Randal L. Schwartz - Stonehenge Consulting Services, Inc. - +1 503 777 0095 > > Perl/Unix/security consulting, Technical writing, Comedy, etc. etc. > See PerlTraining.Stonehenge.com for onsite and open-enrollment Perl training! ``` ## Paul Mackerras, 2006-11-29 21:16 Subject: Re: gitk with arguments fails on OSX Message-ID: <17773.63650.734073.958790@cargo.ozlabs.ibm.com> URL: https://gitlist.dev/e/17773.63650.734073.958790%40cargo.ozlabs.ibm.com In-Reply-To: <7vejrmou75.fsf@assigned-by-dhcp.cox.net> ``` Junio C Hamano writes: > The changes look sane to me. > > Paul? I prefer to be fed gitk changes through you, if you don't > mind. I just pushed a somewhat more comprehensive fix to my gitk.git repo on master.kernel.org. (Actually I had checked it in some time ago locally but forgot to do the push, sorry.) Regards, ```