threads / patch / 43123

patchRe: [PATCH] git-cvsserver: fix breakage when calling git merge-file

Subject: Re: [PATCH] git-cvsserver: fix breakage when calling git merge-file

## tl;dr

3 messages between Dec 19, 2006 and Dec 20, 2006. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

Eric Wong· Dec 19, 2006, 22:58 UTC · lore

[PATCH] git-cvsserver: fix breakage when calling git merge-file

In the same vein as 8336afa563fbeff35e531396273065161181f04c, this fixes the the RCS merge to git-merge-file conversion in commit e2b70087.

Signed-off-by: Eric Wong <normalperson@yhbt.net>
---
 git-cvsserver.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Show changes to git-cvsserver.perl +1 −1
diff --git a/git-cvsserver.perl b/git-cvsserver.perl
index 2a8447e..df39512 100755
--- a/git-cvsserver.perl
+++ b/git-cvsserver.perl
@@ -946,7 +946,7 @@ sub req_update
 
             $log->debug("Temporary directory for merge is $dir");
 
-            my $return = system("git merge-file", $file_local, $file_old, $file_new);
+            my $return = system("git", "merge-file", $file_local, $file_old, $file_new);
             $return >>= 8;
 
             if ( $return == 0 )

-- 
1.4.4.2.ga184
Johannes Schindelin· Dec 19, 2006, 23:59 UTC · re: Eric Wong · lore
Hi,
On Tue, 19 Dec 2006, Eric Wong wrote:
> In the same vein as 8336afa563fbeff35e531396273065161181f04c, this fixes 
> the the RCS merge to git-merge-file conversion in commit e2b70087.

Ooops. I should have checked after reading 8336afa if there are more offenders. Alas, I checked now, and there seem none to be left. But everybody can see now why I try to get an all-C Git: I suck at perl.

Ciao, Dscho

Junio C Hamano· Dec 20, 2006, 00:38 UTC · re: Johannes Schindelin · lore
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 8 quoted lines
> On Tue, 19 Dec 2006, Eric Wong wrote:
>
>> In the same vein as 8336afa563fbeff35e531396273065161181f04c, this fixes 
>> the the RCS merge to git-merge-file conversion in commit e2b70087.
>
> Ooops. I should have checked after reading 8336afa if there are more 
> offenders. Alas, I checked now, and there seem none to be left. But 
> everybody can see now why I try to get an all-C Git: I suck at perl.

Well, I should have been more careful to begin with. My apologies.

And thanks both.

← back to recent threads