# [PATCH] config.mak.uname: correct perl path on FreeBSD 8 messages from 2016-07-25 to 2016-07-26. Participants: Nguyễn Thái Ngọc Duy, Junio C Hamano, Duy Nguyen, Eric Wong. Thread: https://gitlist.dev/t/42920 ## Nguyễn Thái Ngọc Duy, 2016-07-25 16:21 Subject: [PATCH] config.mak.uname: correct perl path on FreeBSD Message-ID: <20160725162125.15734-1-pclouds@gmail.com> URL: https://gitlist.dev/e/20160725162125.15734-1-pclouds%40gmail.com ``` It looks the the symlink /usr/bin/perl (to /usr/local/bin/perl) has been removed at least on FreeBSD 10.3. See [1] for more information. [1] https://svnweb.freebsd.org/ports/head/UPDATING?r1=386270&r2=386269&pathrev=386270&diff_format=c Signed-off-by: Nguyễn Thái Ngọc Duy --- Tested with fbsd 10.3, kvm image. But I suppose it's the same as real fbsd. config.mak.uname | 1 + 1 file changed, 1 insertion(+) diff --git a/config.mak.uname b/config.mak.uname index a88f139..4cd62bd 100644 --- a/config.mak.uname +++ b/config.mak.uname @@ -203,6 +203,7 @@ ifeq ($(uname_S),FreeBSD) NO_STRTOUMAX = YesPlease endif PYTHON_PATH = /usr/local/bin/python + PERL_PATH = /usr/local/bin/perl HAVE_PATHS_H = YesPlease GMTIME_UNRELIABLE_ERRORS = UnfortunatelyYes HAVE_BSD_SYSCTL = YesPlease -- 2.9.1.566.gbd532d4 ``` ## Junio C Hamano, 2016-07-25 16:56 Subject: Re: [PATCH] config.mak.uname: correct perl path on FreeBSD Message-ID: URL: https://gitlist.dev/e/CAPc5daWNAWjtfR7CYN3RTeT7VyvgiNX5HED0%3Df3F%3DGT8h4yKPA%40mail.gmail.com In-Reply-To: <20160725162125.15734-1-pclouds@gmail.com> ``` On Mon, Jul 25, 2016 at 9:21 AM, Nguyễn Thái Ngọc Duy wrote: > It looks the the symlink /usr/bin/perl (to /usr/local/bin/perl) has > been removed at least on FreeBSD 10.3. See [1] for more information. > > [1] https://svnweb.freebsd.org/ports/head/UPDATING?r1=386270&r2=386269&pathrev=386270&diff_format=c > > Signed-off-by: Nguyễn Thái Ngọc Duy > --- > Tested with fbsd 10.3, kvm image. But I suppose it's the same as real > fbsd. Thanks; and we know that older (but not too old that we no longer care about) FreeBSD all have /usr/local/bin/perl? ``` ## Duy Nguyen, 2016-07-25 17:27 Subject: Re: [PATCH] config.mak.uname: correct perl path on FreeBSD Message-ID: URL: https://gitlist.dev/e/CACsJy8Df2cBAf0bWe1FLTb9cOqTX3vgNgC%3Dko82rG2in81R-FQ%40mail.gmail.com In-Reply-To: ``` On Mon, Jul 25, 2016 at 6:56 PM, Junio C Hamano wrote: > On Mon, Jul 25, 2016 at 9:21 AM, Nguyễn Thái Ngọc Duy wrote: >> It looks the the symlink /usr/bin/perl (to /usr/local/bin/perl) has >> been removed at least on FreeBSD 10.3. See [1] for more information. >> >> [1] https://svnweb.freebsd.org/ports/head/UPDATING?r1=386270&r2=386269&pathrev=386270&diff_format=c >> >> Signed-off-by: Nguyễn Thái Ngọc Duy >> --- >> Tested with fbsd 10.3, kvm image. But I suppose it's the same as real >> fbsd. > > Thanks; and we know that older (but not too old that we no longer care about) > FreeBSD all have /usr/local/bin/perl? I'm no fbsd expert but from the first sentence in [1] "Perl has been removed from base more than ten years ago..." I would assume it meant "... removed from base, _to_ ports system" which means /usr/local for all package installation (for ten years for perl). So I think we are good. -- Duy ``` ## Junio C Hamano, 2016-07-25 18:11 Subject: Re: [PATCH] config.mak.uname: correct perl path on FreeBSD Message-ID: URL: https://gitlist.dev/e/xmqqinvt610x.fsf%40gitster.mtv.corp.google.com In-Reply-To: ``` Duy Nguyen writes: > On Mon, Jul 25, 2016 at 6:56 PM, Junio C Hamano wrote: >> On Mon, Jul 25, 2016 at 9:21 AM, Nguyễn Thái Ngọc Duy wrote: >>> It looks the the symlink /usr/bin/perl (to /usr/local/bin/perl) has >>> been removed at least on FreeBSD 10.3. See [1] for more information. >>> >>> [1] https://svnweb.freebsd.org/ports/head/UPDATING?r1=386270&r2=386269&pathrev=386270&diff_format=c >>> >>> Signed-off-by: Nguyễn Thái Ngọc Duy >>> --- >>> Tested with fbsd 10.3, kvm image. But I suppose it's the same as real >>> fbsd. >> >> Thanks; and we know that older (but not too old that we no longer care about) >> FreeBSD all have /usr/local/bin/perl? > > I'm no fbsd expert but from the first sentence in [1] "Perl has been > removed from base more than ten years ago..." I would assume it meant > "... removed from base, _to_ ports system" which means /usr/local for > all package installation (for ten years for perl). So I think we are > good. I guess we didn't follow through http://public-inbox.org/git/%3C20160720025630.GA71874%40plume%3E/ and allowed the thread to drift into a tangent? ``` ## Eric Wong, 2016-07-25 20:33 Subject: Re: [PATCH] config.mak.uname: correct perl path on FreeBSD Message-ID: <20160725203316.GA32053@starla> URL: https://gitlist.dev/e/20160725203316.GA32053%40starla In-Reply-To: ``` Junio C Hamano wrote: > Duy Nguyen writes: > > > On Mon, Jul 25, 2016 at 6:56 PM, Junio C Hamano wrote: > >> On Mon, Jul 25, 2016 at 9:21 AM, Nguyễn Thái Ngọc Duy wrote: > >>> It looks the the symlink /usr/bin/perl (to /usr/local/bin/perl) has > >>> been removed at least on FreeBSD 10.3. See [1] for more information. > >>> > >>> [1] https://svnweb.freebsd.org/ports/head/UPDATING?r1=386270&r2=386269&pathrev=386270&diff_format=c Ah, I missed that. I guess that explains why nobody complained about the problem sooner. > >>> Signed-off-by: Nguyễn Thái Ngọc Duy > >>> --- > >>> Tested with fbsd 10.3, kvm image. But I suppose it's the same as real > >>> fbsd. > >> > >> Thanks; and we know that older (but not too old that we no longer care about) > >> FreeBSD all have /usr/local/bin/perl? > > > > I'm no fbsd expert but from the first sentence in [1] "Perl has been > > removed from base more than ten years ago..." I would assume it meant > > "... removed from base, _to_ ports system" which means /usr/local for > > all package installation (for ten years for perl). So I think we are > > good. > > I guess we didn't follow through > > http://public-inbox.org/git/%3C20160720025630.GA71874%40plume%3E/ > > and allowed the thread to drift into a tangent? +Cc Dscho I've been meaning to followup on that, but had connectivity problems to my VM last week. I still prefer we use numeric comparisons for version numbers since numbers are... numeric. IOW, I prefer we go with my original patch. ``` ## Junio C Hamano, 2016-07-25 20:42 Subject: Re: [PATCH] config.mak.uname: correct perl path on FreeBSD Message-ID: URL: https://gitlist.dev/e/xmqqoa5l4fh0.fsf%40gitster.mtv.corp.google.com In-Reply-To: <20160725203316.GA32053@starla> ``` Eric Wong writes: > Junio C Hamano wrote: >> Duy Nguyen writes: >> >> > On Mon, Jul 25, 2016 at 6:56 PM, Junio C Hamano wrote: >> >> On Mon, Jul 25, 2016 at 9:21 AM, Nguyễn Thái Ngọc Duy wrote: >> >>> It looks the the symlink /usr/bin/perl (to /usr/local/bin/perl) has >> >>> been removed at least on FreeBSD 10.3. See [1] for more information. >> >>> >> >>> [1] https://svnweb.freebsd.org/ports/head/UPDATING?r1=386270&r2=386269&pathrev=386270&diff_format=c > > Ah, I missed that. I guess that explains why nobody complained > about the problem sooner. > >> >>> Signed-off-by: Nguyễn Thái Ngọc Duy >> >>> --- >> >>> Tested with fbsd 10.3, kvm image. But I suppose it's the same as real >> >>> fbsd. >> >> >> >> Thanks; and we know that older (but not too old that we no longer care about) >> >> FreeBSD all have /usr/local/bin/perl? >> > >> > I'm no fbsd expert but from the first sentence in [1] "Perl has been >> > removed from base more than ten years ago..." I would assume it meant >> > "... removed from base, _to_ ports system" which means /usr/local for >> > all package installation (for ten years for perl). So I think we are >> > good. >> >> I guess we didn't follow through >> >> http://public-inbox.org/git/%3C20160720025630.GA71874%40plume%3E/ >> >> and allowed the thread to drift into a tangent? > > +Cc Dscho > > I've been meaning to followup on that, but had connectivity > problems to my VM last week. I still prefer we use numeric > comparisons for version numbers since numbers are... numeric. > IOW, I prefer we go with my original patch. I tend to agree with you if we have to do "systems older than this should use /usr/bin, others should use /usr/local/bin", but this different incarnation of the same topic seems to claim that older ones had /usr/local/bin forever anyway, and that was what made the patch interesting. ``` ## Eric Wong, 2016-07-26 06:18 Subject: Re: [PATCH] config.mak.uname: correct perl path on FreeBSD Message-ID: <20160726061854.GA13334@starla> URL: https://gitlist.dev/e/20160726061854.GA13334%40starla In-Reply-To: ``` Junio C Hamano wrote: > Eric Wong writes: > > Junio C Hamano wrote: > >> Duy Nguyen writes: > >> > On Mon, Jul 25, 2016 at 6:56 PM, Junio C Hamano wrote: > >> >> On Mon, Jul 25, 2016 at 9:21 AM, Nguyễn Thái Ngọc Duy wrote: > > about the problem sooner. > > > >> >>> Signed-off-by: Nguyễn Thái Ngọc Duy > >> >>> --- > >> >>> Tested with fbsd 10.3, kvm image. But I suppose it's the same as real > >> >>> fbsd. > >> >> > >> >> Thanks; and we know that older (but not too old that we no longer care about) > >> >> FreeBSD all have /usr/local/bin/perl? > >> > > >> > I'm no fbsd expert but from the first sentence in [1] "Perl has been > >> > removed from base more than ten years ago..." I would assume it meant > >> > "... removed from base, _to_ ports system" which means /usr/local for > >> > all package installation (for ten years for perl). So I think we are > >> > good. > >> > >> I guess we didn't follow through > >> > >> http://public-inbox.org/git/%3C20160720025630.GA71874%40plume%3E/ > >> > >> and allowed the thread to drift into a tangent? > > > > +Cc Dscho > > > > I've been meaning to followup on that, but had connectivity > > problems to my VM last week. I still prefer we use numeric > > comparisons for version numbers since numbers are... numeric. > > IOW, I prefer we go with my original patch. > > I tend to agree with you if we have to do "systems older than this > should use /usr/bin, others should use /usr/local/bin", but this > different incarnation of the same topic seems to claim that older > ones had /usr/local/bin forever anyway, and that was what made the > patch interesting. I dug around the freebsd history (git://github.com/freebsd/freebsd.git) (~1.5G) and the 3.x and 4.x releases with perl in base still contained many references to /usr/local/bin/perl It also seems FreeBSD 2.x releases were also perl-less in base; so yes, I'm alright with Duy's patch :) ``` ## Junio C Hamano, 2016-07-26 06:47 Subject: Re: [PATCH] config.mak.uname: correct perl path on FreeBSD Message-ID: URL: https://gitlist.dev/e/xmqq8two3nh7.fsf%40gitster.mtv.corp.google.com In-Reply-To: <20160726061854.GA13334@starla> ``` Eric Wong writes: > I dug around the freebsd history (git://github.com/freebsd/freebsd.git) > (~1.5G) and the 3.x and 4.x releases with perl in base still contained > many references to /usr/local/bin/perl > > It also seems FreeBSD 2.x releases were also perl-less in base; > so yes, I'm alright with Duy's patch :) Thanks for a quick digging to converge to the simplest solution. Will replace and merge to 'next' soonish. ```