# bogus "fatal: Not a git repository" 2 messages from 2006-05-25 to 2006-05-25. Participants: Linus Torvalds, Johannes Schindelin. Thread: https://gitlist.dev/t/4291 ## Linus Torvalds, 2006-05-25 15:22 Subject: bogus "fatal: Not a git repository" Message-ID: URL: https://gitlist.dev/e/Pine.LNX.4.64.0605250804390.5623%40g5.osdl.org ``` I was just testing that "git ls-remote" change by Junio, and when you're not in a git repository, it gives this totally bogus warning. The _target_ obviously has to be a git repository, but there's no reason why you'd have to be in a local git repo when doing an ls-remote. The reason is commit 73136b2e8a8ee024320c5ac6a0f14f912432bf03 by Dscho: it adds calls to git-repo-config in git-parse-remote.sh to get the remote shorthands etc. Now, either we should just hide and ignore the error from git-repo-config (probably bad, because some errors _are_ valid - like git-repo-config failing due to bad syntax in the config file), or we should just make git-repo-config quietly handle the case of not being in a git repository. This does the latter: just quietly accepting (and doing nothing - trying to set a value will result in the lock-file failing) our lot in life sounds better than dying with a bogus error message. Signed-off-by: Linus Torvalds --- diff --git a/repo-config.c b/repo-config.c index 127afd7..08fc4cc 100644 --- a/repo-config.c +++ b/repo-config.c @@ -108,7 +108,8 @@ static int get_value(const char* key_, c int main(int argc, const char **argv) { - setup_git_directory(); + int nongit = 0; + setup_git_directory_gently(&nongit); while (1 < argc) { if (!strcmp(argv[1], "--int")) ``` ## Johannes Schindelin, 2006-05-25 21:38 Subject: Re: bogus "fatal: Not a git repository" Message-ID: URL: https://gitlist.dev/e/Pine.LNX.4.63.0605252336590.31700%40wbgn013.biozentrum.uni-wuerzburg.de In-Reply-To: ``` Hi, On Thu, 25 May 2006, Linus Torvalds wrote: > The reason is commit 73136b2e8a8ee024320c5ac6a0f14f912432bf03 by Dscho: it > adds calls to git-repo-config in git-parse-remote.sh to get the remote > shorthands etc. Yes, I did not think of that special case. Sorry. If you need it, here is Acked-By: Johannes Schindelin Ciao, Dscho ```