# [PATCH] Documentation/Makefile: remove extra / 2 messages from 2006-05-25 to 2006-05-25. Participants: Martin Waitz, Junio C Hamano. Thread: https://gitlist.dev/t/4289 ## Martin Waitz, 2006-05-25 12:37 Subject: [PATCH] Documentation/Makefile: remove extra / Message-ID: <20060525123746.GA14325@admingilde.org> URL: https://gitlist.dev/e/20060525123746.GA14325%40admingilde.org ``` As both DESTDIR and the prefix are supposed to be absolute pathnames they can simply be concatenated without an extra / (like in the main Makefile). The extra slash may even break installation on Windows. Signed-off-by: Martin Waitz --- Documentation/Makefile | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentation/Makefile b/Documentation/Makefile index 2a08f59..2b0efe7 100644 --- a/Documentation/Makefile +++ b/Documentation/Makefile @@ -52,9 +52,9 @@ man1: $(DOC_MAN1) man7: $(DOC_MAN7) install: man - $(INSTALL) -d -m755 $(DESTDIR)/$(man1) $(DESTDIR)/$(man7) - $(INSTALL) $(DOC_MAN1) $(DESTDIR)/$(man1) - $(INSTALL) $(DOC_MAN7) $(DESTDIR)/$(man7) + $(INSTALL) -d -m755 $(DESTDIR)$(man1) $(DESTDIR)$(man7) + $(INSTALL) $(DOC_MAN1) $(DESTDIR)$(man1) + $(INSTALL) $(DOC_MAN7) $(DESTDIR)$(man7) # -- 1.3.3.g29c7 -- Martin Waitz ``` ## Junio C Hamano, 2006-05-25 20:45 Subject: Re: [PATCH] Documentation/Makefile: remove extra / Message-ID: <7v3bexu930.fsf@assigned-by-dhcp.cox.net> URL: https://gitlist.dev/e/7v3bexu930.fsf%40assigned-by-dhcp.cox.net In-Reply-To: <20060525123746.GA14325@admingilde.org> ``` Martin Waitz writes: > As both DESTDIR and the prefix are supposed to be absolute pathnames > they can simply be concatenated without an extra / (like in the main Makefile). > The extra slash may even break installation on Windows. > > Signed-off-by: Martin Waitz > --- > Documentation/Makefile | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Documentation/Makefile b/Documentation/Makefile > index 2a08f59..2b0efe7 100644 > --- a/Documentation/Makefile > +++ b/Documentation/Makefile > @@ -52,9 +52,9 @@ man1: $(DOC_MAN1) > man7: $(DOC_MAN7) > > install: man > - $(INSTALL) -d -m755 $(DESTDIR)/$(man1) $(DESTDIR)/$(man7) > - $(INSTALL) $(DOC_MAN1) $(DESTDIR)/$(man1) > - $(INSTALL) $(DOC_MAN7) $(DESTDIR)/$(man7) > + $(INSTALL) -d -m755 $(DESTDIR)$(man1) $(DESTDIR)$(man7) > + $(INSTALL) $(DOC_MAN1) $(DESTDIR)$(man1) > + $(INSTALL) $(DOC_MAN7) $(DESTDIR)$(man7) This unfortunately breaks a workaround I did in the main Makefile for dist-doc target, but I agree it is a good change. ```