threads / patch / 42871

patchconfigure.ac: stronger test for pthread linkage

Subject: [PATCH] configure.ac: stronger test for pthread linkage

## tl;dr

One message between Jul 18, 2016 and Jul 18, 2016. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Eric Wong· Jul 18, 2016, 10:22 UTC · lore

We need to test linkage of pthread_create and pthread_join, as pthread_mutex_* and pthread_key_* functions do not need extra linkage under FreeBSD 10.3, leading to a false-positive of the empty case.

Signed-off-by: Eric Wong <e@80x24.org>
---
 configure.ac | 5 +++++
 1 file changed, 5 insertions(+)
Show changes to configure.ac +5 −0
diff --git a/configure.ac b/configure.ac
index c279025..aa9c91d 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1108,14 +1108,19 @@ GIT_CONF_SUBST([HAVE_BSD_SYSCTL])
 AC_DEFUN([PTHREADTEST_SRC], [
 AC_LANG_PROGRAM([[
 #include <pthread.h>
+static void *noop(void *ignore) { return ignore; }
 ]], [[
 	pthread_mutex_t test_mutex;
 	pthread_key_t test_key;
+	pthread_t th;
 	int retcode = 0;
+	void *ret = (void *)0;
 	retcode |= pthread_key_create(&test_key, (void *)0);
 	retcode |= pthread_mutex_init(&test_mutex,(void *)0);
 	retcode |= pthread_mutex_lock(&test_mutex);
 	retcode |= pthread_mutex_unlock(&test_mutex);
+	retcode |= pthread_create(&th, ret, noop, ret);
+	retcode |= pthread_join(th, &ret);
 	return retcode;
 ]])])
 
-- 
EW

← back to recent threads