# [PATCH] Fix running tests with --valgrind 2 messages from 2016-07-11 to 2016-07-11. Participants: Johannes Schindelin, Duy Nguyen. Thread: https://gitlist.dev/t/42817 ## Johannes Schindelin, 2016-07-11 11:45 Subject: [PATCH] Fix running tests with --valgrind Message-ID: <80e5a1b53844d82c48eb16c88a962d9d693e0491.1468237495.git.johannes.schindelin@gmx.de> URL: https://gitlist.dev/e/80e5a1b53844d82c48eb16c88a962d9d693e0491.1468237495.git.johannes.schindelin%40gmx.de ``` We forgot to adjust this code path after moving the test helpers to t/helper/. Signed-off-by: Johannes Schindelin --- Published-As: https://github.com/dscho/git/releases/tag/valgrind-and-test-helpers-v1 t/test-lib.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/test-lib.sh b/t/test-lib.sh index 0055ebb..493a92b 100644 --- a/t/test-lib.sh +++ b/t/test-lib.sh @@ -798,7 +798,7 @@ then # override all git executables in TEST_DIRECTORY/.. GIT_VALGRIND=$TEST_DIRECTORY/valgrind mkdir -p "$GIT_VALGRIND"/bin - for file in $GIT_BUILD_DIR/git* $GIT_BUILD_DIR/test-* + for file in $GIT_BUILD_DIR/git* $GIT_BUILD_DIR/t/helper/test-* do make_valgrind_symlink $file done -- 2.9.0.278.g1caae67 base-commit: 5c589a73de4394ad125a4effac227b3aec856fa1 ``` ## Duy Nguyen, 2016-07-11 15:29 Subject: Re: [PATCH] Fix running tests with --valgrind Message-ID: URL: https://gitlist.dev/e/CACsJy8D5K5rbpXXrf-JXVrJCBXXgf78%2B_QeYUhOcAZW1hM%3D6CA%40mail.gmail.com In-Reply-To: <80e5a1b53844d82c48eb16c88a962d9d693e0491.1468237495.git.johannes.schindelin@gmx.de> ``` On Mon, Jul 11, 2016 at 1:45 PM, Johannes Schindelin wrote: > We forgot to adjust this code path after moving the test helpers to > t/helper/. Oops. Yet it looks like the right thing to do. > > Signed-off-by: Johannes Schindelin > --- > Published-As: https://github.com/dscho/git/releases/tag/valgrind-and-test-helpers-v1 > t/test-lib.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/t/test-lib.sh b/t/test-lib.sh > index 0055ebb..493a92b 100644 > --- a/t/test-lib.sh > +++ b/t/test-lib.sh > @@ -798,7 +798,7 @@ then > # override all git executables in TEST_DIRECTORY/.. > GIT_VALGRIND=$TEST_DIRECTORY/valgrind > mkdir -p "$GIT_VALGRIND"/bin > - for file in $GIT_BUILD_DIR/git* $GIT_BUILD_DIR/test-* > + for file in $GIT_BUILD_DIR/git* $GIT_BUILD_DIR/t/helper/test-* > do > make_valgrind_symlink $file > done > -- > 2.9.0.278.g1caae67 > > base-commit: 5c589a73de4394ad125a4effac227b3aec856fa1 -- Duy ```