# [PATCH] guilt: fix portability problem with using find -perm +111 2 messages from 2016-07-09 to 2016-07-10. Participants: Theodore Ts'o, Johannes Schindelin. Thread: https://gitlist.dev/t/42811 ## Theodore Ts'o, 2016-07-09 22:18 Subject: [PATCH] guilt: fix portability problem with using find -perm +111 Message-ID: <1468102715-465-1-git-send-email-tytso@mit.edu> URL: https://gitlist.dev/e/1468102715-465-1-git-send-email-tytso%40mit.edu ``` GNU find no longers accepts -perm +111, even though the rest of the world (MacOS, Solaris, BSD) still do. Workaround this problem by using -executable if the system find utility will accept it. Signed-off-by: Theodore Ts'o --- guilt | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/guilt b/guilt index 38d426b..b90f02d 100755 --- a/guilt +++ b/guilt @@ -73,8 +73,17 @@ GUILT_PATH="$(dirname "$0")" guilt_commands() { - find "$GUILT_PATH/../lib/guilt" -maxdepth 1 -name "guilt-*" -type f -perm +111 2> /dev/null | sed -e "s/.*\\/$GUILT-//" - find "$GUILT_PATH" -maxdepth 1 -name "guilt-*" -type f -perm +111 | sed -e "s/.*\\/$GUILT-//" + # GNU Find no longer accepts -perm +111, even though the rest + # world (MacOS, Solaris, BSD, etc.) does. Sigh. Using -executable + # is arugably better, but it is a GNU extension. Since this isn't + # a fast path and guilt doesn't use autoconf, test for it as needed. + if find . -maxdepth 0 -executable > /dev/null 2>&1 ; then + exe_test="-executable" + else + exe_test="-find +111" + fi + find "$GUILT_PATH/../lib/guilt" -maxdepth 1 -name "guilt-*" -type f $exe_test 2> /dev/null | sed -e "s/.*\\/$GUILT-//" + find "$GUILT_PATH" -maxdepth 1 -name "guilt-*" -type f $exe_test | sed -e "s/.*\\/$GUILT-//" } # by default, we shouldn't fail -- 2.5.0 ``` ## Johannes Schindelin, 2016-07-10 07:01 Subject: Re: [PATCH] guilt: fix portability problem with using find -perm +111 Message-ID: URL: https://gitlist.dev/e/alpine.DEB.2.20.1607100900320.6426%40virtualbox In-Reply-To: <1468102715-465-1-git-send-email-tytso@mit.edu> ``` Hi Ted, On Sat, 9 Jul 2016, Theodore Ts'o wrote: > + # is arugably better, but it is a GNU extension. Since this isn't s/arugably/arguably/ Ciao, Dscho ```