threads / patch / 42809

patchworktree: use strbuf_add_absolute_path() directly

Subject: [PATCH] worktree: use strbuf_add_absolute_path() directly

## tl;dr

One message between Jul 9, 2016 and Jul 9, 2016. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

René Scharfe· Jul 9, 2016, 15:43 UTC · lore

absolute_path() is a wrapper for strbuf_add_absolute_path(). Call the latter directly for adding absolute paths to a strbuf. That's shorter and avoids an extra string copy.

Signed-off-by: Rene Scharfe <l.s.r@web.de>
---
 worktree.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Show changes to worktree.c +2 −2
diff --git a/worktree.c b/worktree.c
index e2a94e0..b819baf 100644
--- a/worktree.c
+++ b/worktree.c
@@ -80,7 +80,7 @@ static struct worktree *get_main_worktree(void)
 	int is_bare = 0;
 	int is_detached = 0;
 
-	strbuf_addstr(&worktree_path, absolute_path(get_git_common_dir()));
+	strbuf_add_absolute_path(&worktree_path, get_git_common_dir());
 	is_bare = !strbuf_strip_suffix(&worktree_path, "/.git");
 	if (is_bare)
 		strbuf_strip_suffix(&worktree_path, "/.");
@@ -125,7 +125,7 @@ static struct worktree *get_linked_worktree(const char *id)
 	strbuf_rtrim(&worktree_path);
 	if (!strbuf_strip_suffix(&worktree_path, "/.git")) {
 		strbuf_reset(&worktree_path);
-		strbuf_addstr(&worktree_path, absolute_path("."));
+		strbuf_add_absolute_path(&worktree_path, ".");
 		strbuf_strip_suffix(&worktree_path, "/.");
 	}
 
-- 
2.9.0

← back to recent threads