# bug: compactionheuristic config var case issue 3 messages from 2016-06-16 to 2016-06-16. Participants: Brian Lalor, Duy Nguyen, Jeff King. Thread: https://gitlist.dev/t/42615 ## Brian Lalor, 2016-06-15 10:39 Subject: bug: compactionheuristic config var case issue Message-ID: <8C006106-EED2-48B5-B9A5-6FCEB64597C1@bravo5.org> URL: https://gitlist.dev/e/8C006106-EED2-48B5-B9A5-6FCEB64597C1%40bravo5.org ``` I’m very happy to see the new compaction heuristic option; it’s the way I always thought diffs should read! The config option in the documentation references “diff.compactionHeuristic”, but diff.c does a case-sensitive comparison on “diff.compactionheuristic” (note the case of the “h” in “heuristic”) and `git diff` does not honor the config. Confusingly, `git config diff.compactionheuristic` returns true when diff.compactionHeuristic is set in ~/.gitconfig. When diff.compactionheuristic is set to true in ~/.gitconfig, the desired behavior is achieved. Thank you all for Git: it’s hard to remember the terrible world we lived in before it existed. :-) ``` ## Duy Nguyen, 2016-06-15 12:33 Subject: Re: bug: compactionheuristic config var case issue Message-ID: URL: https://gitlist.dev/e/CACsJy8Dp_s9avkkA4x%3DEfTjkObBNF8sB3zhkdgXmjkipDNdvNw%40mail.gmail.com In-Reply-To: <8C006106-EED2-48B5-B9A5-6FCEB64597C1@bravo5.org> ``` On Wed, Jun 15, 2016 at 5:39 PM, Brian Lalor wrote: > I’m very happy to see the new compaction heuristic option; it’s the way I always thought diffs should read! > > The config option in the documentation references “diff.compactionHeuristic”, but diff.c does a case-sensitive comparison on “diff.compactionheuristic” (note the case of the “h” in “heuristic”) I think this misled you. All configuration variable names are lower-cased before they reach that strcmp() call, the whole picture is more like strcmp(tolower(var), "diff.compactionheuristic"), which I believe is correct. > and `git diff` does not honor the config. Confusingly, `git config diff.compactionheuristic` returns true when diff.compactionHeuristic is set in ~/.gitconfig. When diff.compactionheuristic is set to true in ~/.gitconfig, the desired behavior is achieved. > > Thank you all for Git: it’s hard to remember the terrible world we lived in before it existed. :-) -- Duy ``` ## Jeff King, 2016-06-16 09:48 Subject: Re: bug: compactionheuristic config var case issue Message-ID: <20160616094815.GH15851@sigill.intra.peff.net> URL: https://gitlist.dev/e/20160616094815.GH15851%40sigill.intra.peff.net In-Reply-To: ``` On Wed, Jun 15, 2016 at 07:33:31PM +0700, Duy Nguyen wrote: > On Wed, Jun 15, 2016 at 5:39 PM, Brian Lalor wrote: > > I’m very happy to see the new compaction heuristic option; it’s the way I always thought diffs should read! > > > > The config option in the documentation references > > “diff.compactionHeuristic”, but diff.c does a case-sensitive > > comparison on “diff.compactionheuristic” (note the case of the “h” > > in “heuristic”) > > I think this misled you. All configuration variable names are > lower-cased before they reach that strcmp() call, the whole picture is > more like strcmp(tolower(var), "diff.compactionheuristic"), which I > believe is correct. Yep, that is correct. Config keys are case-insensitive (except for the middle portion "Y" of a key like "X.Y.Z"), and the downcasing happens before they even hit the config callbacks. > > and `git diff` does not honor the config. Confusingly, `git config > > diff.compactionheuristic` returns true when diff.compactionHeuristic > > is set in ~/.gitconfig. When diff.compactionheuristic is set to > > true in ~/.gitconfig, the desired behavior is achieved. Brian, do you have a case you can share where it is not working as expected? Config isn't enabled automatically for plumbing commands like diff-tree. So some commands may not respect it, but "git diff" definitely should. -Peff ```