threads / announce / 42611

[ANNOUNCE] Sharness v1.0.0

Subject: [ANNOUNCE] Sharness v1.0.0

## tl;dr

8 messages between Jun 16, 2016 and Jun 16, 2016.

replies: 7people: 5as markdown or json

Christian Couder· Jun 14, 2016, 19:34 UTC · lore

Hi,

Version 1.0.0 of Sharness [1] -- the test harness library derived from Git's test lib -- is released.

This release contains many upstream fixes and improvements from Git and a lot of specific user contributed features [2].

It's the first release since v0.3.0 in April 2013 [3].

Sharness was first announced on this list in July 2012 [4]. It was created from Git's test lib in April 2011 by Mathias Lafeldt who improved and maintained it until a few days ago.

Thanks a lot Mathias!

Thanks also to all the other contributors (by alphabetical order) since the beginning:

Alexander Sulfrian Dennis Kaarsemaker Jeff King John Keeping Konstantin Koroviev Mark A. Grondona Matthieu Moy Maxim Bublis Richard Hansen Roman Neuhauser Simon Chiang

Thanks also to all the Git contributors who improved test-lib.sh as many of the features and fixes come from upstream!

Enjoy, Christian.

[1] https://github.com/chriscool/sharness [2] https://github.com/chriscool/sharness/blob/master/CHANGELOG.md [3] http://thread.gmane.org/gmane.comp.version-control.git/219944/ [4] http://thread.gmane.org/gmane.comp.version-control.git/201591/

Stefan Beller· Jun 14, 2016, 19:48 UTC · re: Christian Couder · lore

Re: [ANNOUNCE] Sharness v1.0.0

On Tue, Jun 14, 2016 at 12:34 PM, Christian Couder <christian.couder@gmail.com> wrote:

Show 15 quoted lines

> Hi,
>
> Version 1.0.0 of Sharness [1] -- the test harness library derived from
> Git's test lib -- is released.
>
> This release contains many upstream fixes and improvements from Git
> and a lot of specific user contributed features [2].
>
> It's the first release since v0.3.0 in April 2013 [3].
>
> Sharness was first announced on this list in July 2012 [4]. It was
> created from Git's test lib in April 2011 by Mathias Lafeldt who
> improved and maintained it until a few days ago.
>
> Thanks a lot Mathias!

Thanks for picking up the work, Christian!

Is there any word out there from Mathias on making you the designated new maintainer? (I cannot tell if this is a genuine maintainer change, or a [hostile] fork by reading this email, and I don't know much of the context, as I did not know git Git test suite was a stand alone thing)

Thanks, Stefan

Show 30 quoted lines

>
> Thanks also to all the other contributors (by alphabetical order)
> since the beginning:
>
> Alexander Sulfrian
> Dennis Kaarsemaker
> Jeff King
> John Keeping
> Konstantin Koroviev
> Mark A. Grondona
> Matthieu Moy
> Maxim Bublis
> Richard Hansen
> Roman Neuhauser
> Simon Chiang
>
> Thanks also to all the Git contributors who improved test-lib.sh as
> many of the features and fixes come from upstream!
>
> Enjoy,
> Christian.
>
> [1] https://github.com/chriscool/sharness
> [2] https://github.com/chriscool/sharness/blob/master/CHANGELOG.md
> [3] http://thread.gmane.org/gmane.comp.version-control.git/219944/
> [4] http://thread.gmane.org/gmane.comp.version-control.git/201591/
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Christian Couder· Jun 14, 2016, 21:13 UTC · re: Stefan Beller · lore

Re: [ANNOUNCE] Sharness v1.0.0

On Tue, Jun 14, 2016 at 9:48 PM, Stefan Beller <sbeller@google.com> wrote:

Show 14 quoted lines

> On Tue, Jun 14, 2016 at 12:34 PM, Christian Couder
> <christian.couder@gmail.com> wrote:
>>
>> Sharness was first announced on this list in July 2012 [4]. It was
>> created from Git's test lib in April 2011 by Mathias Lafeldt who
>> improved and maintained it until a few days ago.
>>
>> Thanks a lot Mathias!
>
> Thanks for picking up the work, Christian!
>
> Is there any word out there from Mathias on making you the designated
> new maintainer? (I cannot tell if this is a genuine maintainer change, or
> a [hostile] fork by reading this email, and I don't know much of the context,

Mathias gave me commiter rights on the repo (https://github.com/mlafeldt/sharness at that time) one year ago.

A few days ago, as I wanted since last December to release v1.0.0, but was uneasy to do so without at least a LGTM from him, I contacted him by private email and he decided to transfer the repo to https://github.com/chriscool/sharness, to give me maintainership and to step down completely. So yeah this is a genuine maintainer change and not an hostile fork at all. (I cc'ed Mathias again so he can confirm if he wants.)

> as I did not know git Git test suite was a stand alone thing)

I am not sure it qualifies as a stand alone thing there are some differences and for now some features are going from Git's test-lib.sh into Sharness but not the other way around.

Mathias Lafeldt· Jun 15, 2016, 09:03 UTC · re: Christian Couder · lore

Re: [ANNOUNCE] Sharness v1.0.0

>> Is there any word out there from Mathias on making you the designated
>> new maintainer? (I cannot tell if this is a genuine maintainer change, or
>> a [hostile] fork by reading this email, and I don't know much of the context,

Yes, it's 100% genuine. I handed over maintenance to Christian Couder.

Here's a signed commit to prove the transfer: https://github.com/chriscool/sharness/pull/55

(Sorry for double posting, the mailing list didn't like my first email.)

-- 
-Mathias
https://tinyletter.com/production-ready

Jeff King· Jun 14, 2016, 21:34 UTC · re: Christian Couder · lore

Re: [ANNOUNCE] Sharness v1.0.0

On Tue, Jun 14, 2016 at 09:34:17PM +0200, Christian Couder wrote:

> Version 1.0.0 of Sharness [1] -- the test harness library derived from
> Git's test lib -- is released.

Cool. Git's test harness is something I really miss having in other projects. I'm glad this project exists. :)

> This release contains many upstream fixes and improvements from Git
> and a lot of specific user contributed features [2].

It looks like it takes some manual work to massage upstream improvements into Sharness.

I don't think the Git project would ever want to say "sharness is the upstream, and we are now just a user of it". But I wonder if we could break down test-lib.sh to keep the Git-specific parts separate, which would make it easier for sharness to pull the other bits as a whole.

I dunno. I guess it would depend on how invasive the patches were, but I would not be opposed to such a thing. I suspect the separation might actually make our test setup more clear.

-Peff

Junio C Hamano· Jun 14, 2016, 21:43 UTC · re: Jeff King · lore

Re: [ANNOUNCE] Sharness v1.0.0

Jeff King <peff@peff.net> writes:

> I don't think the Git project would ever want to say "sharness is the
> upstream, and we are now just a user of it". But I wonder if we could
> break down test-lib.sh to keep the Git-specific parts separate, which
> would make it easier for sharness to pull the other bits as a whole.

I took a quick look around, and it seems that this is an outdated fork made without getting much of the improvement from its upstream since it forked. It does not seem to have lazy prerequisite, for example.

Jeff King· Jun 14, 2016, 21:46 UTC · re: Junio C Hamano · lore

Re: [ANNOUNCE] Sharness v1.0.0

On Tue, Jun 14, 2016 at 02:43:19PM -0700, Junio C Hamano wrote:

Show 11 quoted lines

> Jeff King <peff@peff.net> writes:
> 
> > I don't think the Git project would ever want to say "sharness is the
> > upstream, and we are now just a user of it". But I wonder if we could
> > break down test-lib.sh to keep the Git-specific parts separate, which
> > would make it easier for sharness to pull the other bits as a whole.
> 
> I took a quick look around, and it seems that this is an outdated
> fork made without getting much of the improvement from its upstream
> since it forked.  It does not seem to have lazy prerequisite, for
> example.

Yeah, I don't think it has kept up with our work. My statement above was "I don't think we'd _ever_ want to consider sharness the upstream, even if it were up to date", but obviously there would be a lot of work to even get it there.

-Peff

Junio C Hamano· Jun 14, 2016, 21:50 UTC · re: Jeff King · lore

Re: [ANNOUNCE] Sharness v1.0.0

Jeff King <peff@peff.net> writes:

> Yeah, I don't think it has kept up with our work. My statement above was
> "I don't think we'd _ever_ want to consider sharness the upstream, even
> if it were up to date", but obviously there would be a lot of work to
> even get it there.

I actually was a lot more optimistic when they started, and if it were up to date, I would have at least tried to see what the damage to our t/ part will be if we swapped t/test-lib{,-functions}.sh with it, which was the original reason why I took a look until I found out that it did not have some things.